Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Noir debugger (brillig) #3404

Closed
wants to merge 31 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
16ff63e
feat: implement basic debugger for brillig bytecode
dmvict Oct 5, 2023
48d5b1b
chore: update realization of `noirc_dbg`, remove extra dependencies, …
dmvict Oct 9, 2023
8128032
feat: implement basic repl for app, compile, execute, see registers a…
dmvict Oct 10, 2023
c20c721
chore: update realization, take into account changes in vm
dmvict Oct 11, 2023
2f597b9
Merge branch 'master' of https://github.com/noir-lang/noir into debugger
dmvict Oct 13, 2023
72a42bd
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict Oct 24, 2023
e250f13
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict Oct 25, 2023
eb5c4d6
chore: update realization, store initial witnesses to memory, checked…
dmvict Oct 25, 2023
71ca87f
chore: update realization of inputs generation, split it into memory …
dmvict Oct 26, 2023
d117e7c
chore: update realization, move code to library, make app more flexib…
dmvict Oct 26, 2023
81e13df
chore: update files, add documentation
dmvict Oct 30, 2023
04d7272
chore: add basic integration tests for crate `noirc_dbg`
dmvict Oct 30, 2023
ca66fe0
Merge branch 'master' into a_debugger
dmvict Nov 1, 2023
1781053
chore: update realization to make app server accessible and testable,…
dmvict Nov 1, 2023
0b6d26e
chore: extend tests of crate `noirc_dbg`, add new assets and test rou…
dmvict Nov 1, 2023
fd07f98
chore: update realization, make it more user friendly, add tests and …
dmvict Nov 1, 2023
e618b70
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict Nov 10, 2023
1a86c17
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict Nov 15, 2023
b27c06c
feat: add vs plugin files, start adapter
dmvict Nov 15, 2023
110986b
feat: add logging of commands in dap
dmvict Nov 15, 2023
a0be45b
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict Nov 17, 2023
ae2df59
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict Nov 20, 2023
818fa14
feat: add support for memory reading and variables autoupdate
dmvict Nov 20, 2023
b83c53d
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict Nov 21, 2023
1fab7c5
feat: update logic, add support of main features
dmvict Nov 21, 2023
70e9b77
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict Nov 22, 2023
70e2760
feat: add support of breakpoints, improve repl
dmvict Nov 22, 2023
cf81edd
chore: add `Cargo.lock` file to pr to pass clippy checks
dmvict Nov 22, 2023
61cb304
chore: fix formatting of file
dmvict Nov 22, 2023
410f84d
fix: fix tests after changes in module
dmvict Nov 22, 2023
6d0e5dc
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict Nov 28, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,548 changes: 1,073 additions & 475 deletions Cargo.lock

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ members = [
"tooling/nargo_toml",
"tooling/noirc_abi",
"tooling/noirc_abi_wasm",
"tooling/noirc_dbg",
# ACVM
"acvm-repo/acir_field",
"acvm-repo/acir",
Expand Down
29 changes: 29 additions & 0 deletions tooling/noirc_dbg/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
[package]
name = "noirc_dbg"
description = "Debugger for Noir"
version.workspace = true
authors.workspace = true
edition.workspace = true
license.workspace = true

[dependencies]
acvm = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need to use a fork?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need to use a fork?

Hello @kevaundray

Yes, the pr still need the fork. I described the changes in the first post in the issue #3094.
Here is the code that allows to compile the brillig bytecode.
I think we should continue discussion about integration of this changes in the other issue/pr.
Once the changes will be properly integrated into repo I'll be able to remove the fork from dependencies.

barretenberg_blackbox_solver = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" }
fm = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" }
nargo_toml = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" }
noirc_abi = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" }
noirc_evaluator = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" }
noirc_errors = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" }
noirc_frontend = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" }
noirc_driver = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e", features = [ "brillig" ] }
noirc_printable_type = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" }
nargo = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" }
serde_json.workspace = true
thiserror.workspace = true

crossbeam = "0.8.2"
dap = "0.4.1-alpha1"
base64.workspace = true

[features]
dap = []
Loading
Loading