-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Noir debugger (brillig) #3404
Closed
Closed
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
16ff63e
feat: implement basic debugger for brillig bytecode
dmvict 48d5b1b
chore: update realization of `noirc_dbg`, remove extra dependencies, …
dmvict 8128032
feat: implement basic repl for app, compile, execute, see registers a…
dmvict c20c721
chore: update realization, take into account changes in vm
dmvict 2f597b9
Merge branch 'master' of https://github.com/noir-lang/noir into debugger
dmvict 72a42bd
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict e250f13
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict eb5c4d6
chore: update realization, store initial witnesses to memory, checked…
dmvict 71ca87f
chore: update realization of inputs generation, split it into memory …
dmvict d117e7c
chore: update realization, move code to library, make app more flexib…
dmvict 81e13df
chore: update files, add documentation
dmvict 04d7272
chore: add basic integration tests for crate `noirc_dbg`
dmvict ca66fe0
Merge branch 'master' into a_debugger
dmvict 1781053
chore: update realization to make app server accessible and testable,…
dmvict 0b6d26e
chore: extend tests of crate `noirc_dbg`, add new assets and test rou…
dmvict fd07f98
chore: update realization, make it more user friendly, add tests and …
dmvict e618b70
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict 1a86c17
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict b27c06c
feat: add vs plugin files, start adapter
dmvict 110986b
feat: add logging of commands in dap
dmvict a0be45b
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict ae2df59
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict 818fa14
feat: add support for memory reading and variables autoupdate
dmvict b83c53d
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict 1fab7c5
feat: update logic, add support of main features
dmvict 70e9b77
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict 70e2760
feat: add support of breakpoints, improve repl
dmvict cf81edd
chore: add `Cargo.lock` file to pr to pass clippy checks
dmvict 61cb304
chore: fix formatting of file
dmvict 410f84d
fix: fix tests after changes in module
dmvict 6d0e5dc
Merge branch 'master' of https://github.com/noir-lang/noir into a_deb…
dmvict File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
[package] | ||
name = "noirc_dbg" | ||
description = "Debugger for Noir" | ||
version.workspace = true | ||
authors.workspace = true | ||
edition.workspace = true | ||
license.workspace = true | ||
|
||
[dependencies] | ||
acvm = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" } | ||
barretenberg_blackbox_solver = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" } | ||
fm = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" } | ||
nargo_toml = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" } | ||
noirc_abi = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" } | ||
noirc_evaluator = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" } | ||
noirc_errors = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" } | ||
noirc_frontend = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" } | ||
noirc_driver = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e", features = [ "brillig" ] } | ||
noirc_printable_type = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" } | ||
nargo = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" } | ||
serde_json.workspace = true | ||
thiserror.workspace = true | ||
|
||
crossbeam = "0.8.2" | ||
dap = "0.4.1-alpha1" | ||
base64.workspace = true | ||
|
||
[features] | ||
dap = [] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this still need to use a fork?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @kevaundray
Yes, the pr still need the fork. I described the changes in the first post in the issue #3094.
Here is the code that allows to compile the brillig bytecode.
I think we should continue discussion about integration of this changes in the other issue/pr.
Once the changes will be properly integrated into repo I'll be able to remove the fork from dependencies.