fix: Slice coercions

compiler/noirc_frontend/src/hir_def/types.rs

@@ -1510,7 +1510,7 @@
                 Type::Tuple(fields)
             }
             Type::Forall(typevars, typ) => {
                 // Trying to substitute_helper a variable de, substitute_bound_typevarsfined within a nested Forall
                 // is usually impossible and indicative of an error in the type checker somewhere.
                 for var in typevars {
                     assert!(!type_bindings.contains_key(&var.id()));
@@ -1662,14 +1662,19 @@
     let as_slice = HirExpression::Ident(HirIdent::non_trait_method(as_slice_id, location));
     let func = interner.push_expr(as_slice);
 
-    let arguments = vec![expression];
+    // Copy the expression and give it a new ExprId. The old one
+    // will be mutated in place into a Call expression.
+    let argument = interner.expression(&expression);
+    let argument = interner.push_expr(argument);
+    interner.push_expr_type(argument, array_type.clone());
+    interner.push_expr_location(argument, location.span, location.file);
+
+    let arguments = vec![argument];
     let call = HirExpression::Call(HirCallExpression { func, arguments, location });
-    let call = interner.push_expr(call);
+    interner.replace_expr(&expression, call);
 
-    interner.push_expr_location(call, location.span, location.file);
     interner.push_expr_location(func, location.span, location.file);
-
-    interner.push_expr_type(call, target_type.clone());
+    interner.push_expr_type(expression, target_type.clone());
 
     let func_type = Type::Function(vec![array_type], Box::new(target_type), Box::new(Type::Unit));
     interner.push_expr_type(func, func_type);

test_programs/execution_success/slice_coercion/Nargo.toml

@@ -0,0 +1,7 @@
+[package]
+name = "slice_coercion"
+type = "bin"
+authors = [""]
+compiler_version = ">=0.25.0"
+
+[dependencies]

test_programs/execution_success/slice_coercion/Prover.toml

@@ -0,0 +1,2 @@
+first = 3
+expected = 3

test_programs/execution_success/slice_coercion/src/main.nr

@@ -0,0 +1,19 @@
+struct Hasher {
+    fields: [Field],
+}
+
+impl Hasher {
+    pub fn new() -> Self {
+        Self { fields: [] }
+    }
+
+    pub fn add(&mut self, field: Field) {
+        self.fields = self.fields.push_back(field);
+    }
+}
+
+fn main(expected: pub Field, first: Field) {
+    let mut hasher = Hasher::new();
+    hasher.add(first);
+    assert(hasher.fields[0] == expected);
+}