Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Slice coercions #4640

Merged
merged 4 commits into from
Mar 26, 2024
Merged

fix: Slice coercions #4640

merged 4 commits into from
Mar 26, 2024

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Mar 26, 2024

Description

Problem*

Resolves #4639

Summary*

The array to slice coercion was broken - and it seemingly has always been so. The coercion never actually called replace_expr to replace the original expression with the as_slice(original_expr) coercion.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm
Copy link
Contributor

@jfecher Looks like you may need to rename your test to slice_coercion

@jfecher jfecher changed the title Fix slice coercion fix: Slice coercions Mar 26, 2024
michaeljklein
michaeljklein approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@michaeljklein michaeljklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfecher jfecher added this pull request to the merge queue Mar 26, 2024
Merged via the queue into master with commit c0bae17 Mar 26, 2024
43 checks passed
@jfecher jfecher deleted the jf/fix-slice-coercion branch March 26, 2024 19:50
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Mar 27, 2024
@AztecBot
[1 changes] chore: delete R1CSTransformer (noir-lang/noir#4649)
a268f1d 
fix: Slice coercions (noir-lang/noir#4640)
chore(ci): add warning sticky comment (noir-lang/noir#4647)
fix(ssa): Fix slice intrinsic handling in the capacity tracker  (noir-lang/noir#4643)
chore: fix versioning of `bn254_blackbox_solver` crate (noir-lang/noir#4638)
chore: fix acvm crates reporting errors as JS packages (noir-lang/noir#4637)
chore: Release Noir(0.26.0) (noir-lang/noir#4526)
chore: convert `BlockExpression` into a standard struct (noir-lang/noir#4623)
chore(github): Improve PR template "document later" checkbox description (noir-lang/noir#4625)
chore: Update integers.md to note support for Fields using `from_integer` (noir-lang/noir#4536)
chore: update docs with function names to match version 0.25.0 specifications (noir-lang/noir#4466)
feat: add specific error for attempting `string[x] = ".."` (noir-lang/noir#4611)
fix(ssa): Use accurate type during SSA AsSlice simplficiation (noir-lang/noir#4610)
@AztecBot AztecBot mentioned this pull request Mar 27, 2024
Merged
TomAFrench added a commit that referenced this pull request Mar 27, 2024
@TomAFrench
Merge branch 'master' into tf/unsafe-blocks
429aba6 
* master:
  chore: delete `R1CSTransformer` (#4649)
  fix: Slice coercions (#4640)
  chore(ci): add warning sticky comment (#4647)
  fix(ssa): Fix slice intrinsic handling in the capacity tracker  (#4643)
  chore: fix versioning of `bn254_blackbox_solver` crate (#4638)
  chore: fix acvm crates reporting errors as JS packages (#4637)
  chore: Release Noir(0.26.0) (#4526)
  chore: convert `BlockExpression` into a standard struct (#4623)
  chore(github): Improve PR template "document later" checkbox description (#4625)
  chore: Update integers.md to note support for Fields using `from_integer` (#4536)
  chore: update docs with function names to match version 0.25.0 specifications (#4466)
  feat: add specific error for attempting `string[x] = ".."` (#4611)
  fix(ssa): Use accurate type during SSA AsSlice simplficiation (#4610)
  feat: Sync from aztec-packages (#4581)
  chore: regression test for #2540 (#4602)
  chore: fix up benchmarking scripts (#4601)
  feat: Add experimental `quote` expression to parser (#4595)
  chore(ci): fix long debugger test times (#4599)
sirasistant added a commit to AztecProtocol/aztec-packages that referenced this pull request Mar 27, 2024
@AztecBot @sirasistant
feat: Sync from noir (#5475)
27bd8d3 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: delete `R1CSTransformer`
(noir-lang/noir#4649)
fix: Slice coercions (noir-lang/noir#4640)
chore(ci): add warning sticky comment
(noir-lang/noir#4647)
fix(ssa): Fix slice intrinsic handling in the capacity tracker
(noir-lang/noir#4643)
chore: fix versioning of `bn254_blackbox_solver` crate
(noir-lang/noir#4638)
chore: fix acvm crates reporting errors as JS packages
(noir-lang/noir#4637)
chore: Release Noir(0.26.0)
(noir-lang/noir#4526)
chore: convert `BlockExpression` into a standard struct
(noir-lang/noir#4623)
chore(github): Improve PR template "document later" checkbox description
(noir-lang/noir#4625)
chore: Update integers.md to note support for Fields using
`from_integer` (noir-lang/noir#4536)
chore: update docs with function names to match version 0.25.0
specifications (noir-lang/noir#4466)
feat: add specific error for attempting `string[x] = ".."`
(noir-lang/noir#4611)
fix(ssa): Use accurate type during SSA AsSlice simplficiation
(noir-lang/noir#4610)
END_COMMIT_OVERRIDE

---------

Co-authored-by: sirasistant <sirasistant@gmail.com>
@AztecBot AztecBot mentioned this pull request Mar 27, 2024
Merged
AztecBot added a commit that referenced this pull request Mar 27, 2024
@AztecBot @sirasistant
feat: Sync from noir (AztecProtocol/aztec-packages#5475)
70f5c8e 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: delete `R1CSTransformer`
(#4649)
fix: Slice coercions (#4640)
chore(ci): add warning sticky comment
(#4647)
fix(ssa): Fix slice intrinsic handling in the capacity tracker
(#4643)
chore: fix versioning of `bn254_blackbox_solver` crate
(#4638)
chore: fix acvm crates reporting errors as JS packages
(#4637)
chore: Release Noir(0.26.0)
(#4526)
chore: convert `BlockExpression` into a standard struct
(#4623)
chore(github): Improve PR template "document later" checkbox description
(#4625)
chore: Update integers.md to note support for Fields using
`from_integer` (#4536)
chore: update docs with function names to match version 0.25.0
specifications (#4466)
feat: add specific error for attempting `string[x] = ".."`
(#4611)
fix(ssa): Use accurate type during SSA AsSlice simplficiation
(#4610)
END_COMMIT_OVERRIDE

---------

Co-authored-by: sirasistant <sirasistant@gmail.com>
@kevaundray kevaundray mentioned this pull request Mar 27, 2024
Merged
sirasistant pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Mar 27, 2024
@AztecBot
chore(master): Release 0.32.0 (#5455)
a87f847 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.32.0</summary>

##
[0.32.0](aztec-package-v0.31.0...aztec-package-v0.32.0)
(2024-03-27)


### Features

* Sequencer checks list of allowed FPCs
([#5310](#5310))
([adf20dc](adf20dc)),
closes
[#5000](#5000)
</details>

<details><summary>barretenberg.js: 0.32.0</summary>

##
[0.32.0](barretenberg.js-v0.31.0...barretenberg.js-v0.32.0)
(2024-03-27)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.32.0</summary>

##
[0.32.0](aztec-cli-v0.31.0...aztec-cli-v0.32.0)
(2024-03-27)


### Miscellaneous

* **aztec-cli:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.32.0</summary>

##
[0.32.0](aztec-packages-v0.31.0...aztec-packages-v0.32.0)
(2024-03-27)


### ⚠ BREAKING CHANGES

* Brillig typed memory
([#5395](#5395))

### Features

* Add specific error for attempting `string[x] = ".."`
(noir-lang/noir#4611)
([27bd8d3](27bd8d3))
* **avm:** Dynamic gas costs for arithmetic, calldatacopy, and set
([#5473](#5473))
([bbd33fb](bbd33fb))
* **avm:** EQ opcode output u8 and execution
([#5402](#5402))
([3450e24](3450e24)),
closes
[#5290](#5290)
* Benchmark tx size with fee
([#5414](#5414))
([543f8a2](543f8a2)),
closes
[#5403](#5403)
* Brillig typed memory
([#5395](#5395))
([16b0bdd](16b0bdd))
* Sequencer checks list of allowed FPCs
([#5310](#5310))
([adf20dc](adf20dc)),
closes
[#5000](#5000)


### Bug Fixes

* `l1-contracts/bootstrap.sh`
([#5479](#5479))
([f7d1d70](f7d1d70))
* Add FPC to allowlist
([#5464](#5464))
([424960f](424960f))
* **ci:** Fix earthly ctest
([#5424](#5424))
([9cac8a4](9cac8a4))
* Docs example e2e test
([#5456](#5456))
([ae5126a](ae5126a))
* Serial bb builds for mac
([#5462](#5462))
([4317819](4317819))
* Slice coercions (noir-lang/noir#4640)
([27bd8d3](27bd8d3))
* **ssa:** Fix slice intrinsic handling in the capacity tracker
(noir-lang/noir#4643)
([27bd8d3](27bd8d3))
* **ssa:** Use accurate type during SSA AsSlice simplficiation
(noir-lang/noir#4610)
([27bd8d3](27bd8d3))


### Miscellaneous

* Append-only merkle tree generics
([#5355](#5355))
([ef7bf79](ef7bf79))
* **avm:** Deterministic codegen from pil and some renaming
([#5476](#5476))
([ba834a4](ba834a4))
* **avm:** Test cleanup and update yp to allow for zero gas
([#5459](#5459))
([1829741](1829741))
* **avm:** Unify noir macros flow
([#5461](#5461))
([54aee58](54aee58))
* **ci:** Add missing dependency to circleci config
([#5437](#5437))
([753cb78](753cb78))
* **ci:** Add warning sticky comment
(noir-lang/noir#4647)
([27bd8d3](27bd8d3))
* Convert `BlockExpression` into a standard struct
(noir-lang/noir#4623)
([27bd8d3](27bd8d3))
* Delete `R1CSTransformer` (noir-lang/noir#4649)
([27bd8d3](27bd8d3))
* Fallback to building barretenberg targets sequentially when RAM
constrained
([#5426](#5426))
([29588e0](29588e0))
* Fix acvm crates reporting errors as JS packages
(noir-lang/noir#4637)
([27bd8d3](27bd8d3))
* Fix versioning of `bn254_blackbox_solver` crate
(noir-lang/noir#4638)
([27bd8d3](27bd8d3))
* **github:** Improve PR template "document later" checkbox description
(noir-lang/noir#4625)
([27bd8d3](27bd8d3))
* Introduce selectors to enable range checks of 8-bit and 16-bit sizes
([#5465](#5465))
([ef44674](ef44674))
* Leveraging `Bufferable` in `pedersenHash(...)` and
`sha256ToField(...)`
([#5444](#5444))
([0e0748c](0e0748c))
* Release Noir(0.26.0) (noir-lang/noir#4526)
([27bd8d3](27bd8d3))
* Renaming rand() as unsafe_rand()
([#5457](#5457))
([19ad2bb](19ad2bb)),
closes
[#3746](#3746)
* Replace relative paths to noir-protocol-circuits
([d332ad1](d332ad1))
* Timestamp as u64 instead of a Field
([#5453](#5453))
([d80dbbf](d80dbbf)),
closes
[#5446](#5446)
* Typed encrypted and unencrypted L2 log containers
([#5422](#5422))
([a4d4ee8](a4d4ee8))
* Update docs with function names to match version 0.25.0 specifications
(noir-lang/noir#4466)
([27bd8d3](27bd8d3))
* Update integers.md to note support for Fields using `from_integer`
(noir-lang/noir#4536)
([27bd8d3](27bd8d3))


### Documentation

* **yp:** Spec how bytecode is encoded in class registerer
([#5471](#5471))
([e3bced2](e3bced2))
</details>

<details><summary>barretenberg: 0.32.0</summary>

##
[0.32.0](barretenberg-v0.31.0...barretenberg-v0.32.0)
(2024-03-27)


### ⚠ BREAKING CHANGES

* Brillig typed memory
([#5395](#5395))

### Features

* **avm:** EQ opcode output u8 and execution
([#5402](#5402))
([3450e24](3450e24)),
closes
[#5290](#5290)
* Brillig typed memory
([#5395](#5395))
([16b0bdd](16b0bdd))


### Bug Fixes

* **ci:** Fix earthly ctest
([#5424](#5424))
([9cac8a4](9cac8a4))
* Serial bb builds for mac
([#5462](#5462))
([4317819](4317819))


### Miscellaneous

* **avm:** Deterministic codegen from pil and some renaming
([#5476](#5476))
([ba834a4](ba834a4))
* Fallback to building barretenberg targets sequentially when RAM
constrained
([#5426](#5426))
([29588e0](29588e0))
* Introduce selectors to enable range checks of 8-bit and 16-bit sizes
([#5465](#5465))
([ef44674](ef44674))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit that referenced this pull request Mar 27, 2024
@AztecBot
chore(master): Release 0.32.0 (AztecProtocol/aztec-packages#5455)
d95a430 
🤖 I have created a release *beep* *boop*
---

<details><summary>aztec-package: 0.32.0</summary>

##
[0.32.0](AztecProtocol/aztec-packages@aztec-package-v0.31.0...aztec-package-v0.32.0)
(2024-03-27)

### Features

* Sequencer checks list of allowed FPCs
([#5310](AztecProtocol/aztec-packages#5310))
([adf20dc](AztecProtocol/aztec-packages@adf20dc)),
closes
[#5000](AztecProtocol/aztec-packages#5000)
</details>

<details><summary>barretenberg.js: 0.32.0</summary>

##
[0.32.0](AztecProtocol/aztec-packages@barretenberg.js-v0.31.0...barretenberg.js-v0.32.0)
(2024-03-27)

### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.32.0</summary>

##
[0.32.0](AztecProtocol/aztec-packages@aztec-cli-v0.31.0...aztec-cli-v0.32.0)
(2024-03-27)

### Miscellaneous

* **aztec-cli:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.32.0</summary>

##
[0.32.0](AztecProtocol/aztec-packages@aztec-packages-v0.31.0...aztec-packages-v0.32.0)
(2024-03-27)

### ⚠ BREAKING CHANGES

* Brillig typed memory
([#5395](AztecProtocol/aztec-packages#5395))

### Features

* Add specific error for attempting `string[x] = ".."`
(#4611)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* **avm:** Dynamic gas costs for arithmetic, calldatacopy, and set
([#5473](AztecProtocol/aztec-packages#5473))
([bbd33fb](AztecProtocol/aztec-packages@bbd33fb))
* **avm:** EQ opcode output u8 and execution
([#5402](AztecProtocol/aztec-packages#5402))
([3450e24](AztecProtocol/aztec-packages@3450e24)),
closes
[#5290](AztecProtocol/aztec-packages#5290)
* Benchmark tx size with fee
([#5414](AztecProtocol/aztec-packages#5414))
([543f8a2](AztecProtocol/aztec-packages@543f8a2)),
closes
[#5403](AztecProtocol/aztec-packages#5403)
* Brillig typed memory
([#5395](AztecProtocol/aztec-packages#5395))
([16b0bdd](AztecProtocol/aztec-packages@16b0bdd))
* Sequencer checks list of allowed FPCs
([#5310](AztecProtocol/aztec-packages#5310))
([adf20dc](AztecProtocol/aztec-packages@adf20dc)),
closes
[#5000](AztecProtocol/aztec-packages#5000)

### Bug Fixes

* `l1-contracts/bootstrap.sh`
([#5479](AztecProtocol/aztec-packages#5479))
([f7d1d70](AztecProtocol/aztec-packages@f7d1d70))
* Add FPC to allowlist
([#5464](AztecProtocol/aztec-packages#5464))
([424960f](AztecProtocol/aztec-packages@424960f))
* **ci:** Fix earthly ctest
([#5424](AztecProtocol/aztec-packages#5424))
([9cac8a4](AztecProtocol/aztec-packages@9cac8a4))
* Docs example e2e test
([#5456](AztecProtocol/aztec-packages#5456))
([ae5126a](AztecProtocol/aztec-packages@ae5126a))
* Serial bb builds for mac
([#5462](AztecProtocol/aztec-packages#5462))
([4317819](AztecProtocol/aztec-packages@4317819))
* Slice coercions (#4640)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* **ssa:** Fix slice intrinsic handling in the capacity tracker
(#4643)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* **ssa:** Use accurate type during SSA AsSlice simplficiation
(#4610)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))

### Miscellaneous

* Append-only merkle tree generics
([#5355](AztecProtocol/aztec-packages#5355))
([ef7bf79](AztecProtocol/aztec-packages@ef7bf79))
* **avm:** Deterministic codegen from pil and some renaming
([#5476](AztecProtocol/aztec-packages#5476))
([ba834a4](AztecProtocol/aztec-packages@ba834a4))
* **avm:** Test cleanup and update yp to allow for zero gas
([#5459](AztecProtocol/aztec-packages#5459))
([1829741](AztecProtocol/aztec-packages@1829741))
* **avm:** Unify noir macros flow
([#5461](AztecProtocol/aztec-packages#5461))
([54aee58](AztecProtocol/aztec-packages@54aee58))
* **ci:** Add missing dependency to circleci config
([#5437](AztecProtocol/aztec-packages#5437))
([753cb78](AztecProtocol/aztec-packages@753cb78))
* **ci:** Add warning sticky comment
(#4647)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Convert `BlockExpression` into a standard struct
(#4623)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Delete `R1CSTransformer` (#4649)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Fallback to building barretenberg targets sequentially when RAM
constrained
([#5426](AztecProtocol/aztec-packages#5426))
([29588e0](AztecProtocol/aztec-packages@29588e0))
* Fix acvm crates reporting errors as JS packages
(#4637)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Fix versioning of `bn254_blackbox_solver` crate
(#4638)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* **github:** Improve PR template "document later" checkbox description
(#4625)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Introduce selectors to enable range checks of 8-bit and 16-bit sizes
([#5465](AztecProtocol/aztec-packages#5465))
([ef44674](AztecProtocol/aztec-packages@ef44674))
* Leveraging `Bufferable` in `pedersenHash(...)` and
`sha256ToField(...)`
([#5444](AztecProtocol/aztec-packages#5444))
([0e0748c](AztecProtocol/aztec-packages@0e0748c))
* Release Noir(0.26.0) (#4526)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Renaming rand() as unsafe_rand()
([#5457](AztecProtocol/aztec-packages#5457))
([19ad2bb](AztecProtocol/aztec-packages@19ad2bb)),
closes
[#3746](AztecProtocol/aztec-packages#3746)
* Replace relative paths to noir-protocol-circuits
([d332ad1](AztecProtocol/aztec-packages@d332ad1))
* Timestamp as u64 instead of a Field
([#5453](AztecProtocol/aztec-packages#5453))
([d80dbbf](AztecProtocol/aztec-packages@d80dbbf)),
closes
[#5446](AztecProtocol/aztec-packages#5446)
* Typed encrypted and unencrypted L2 log containers
([#5422](AztecProtocol/aztec-packages#5422))
([a4d4ee8](AztecProtocol/aztec-packages@a4d4ee8))
* Update docs with function names to match version 0.25.0 specifications
(#4466)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Update integers.md to note support for Fields using `from_integer`
(#4536)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))

### Documentation

* **yp:** Spec how bytecode is encoded in class registerer
([#5471](AztecProtocol/aztec-packages#5471))
([e3bced2](AztecProtocol/aztec-packages@e3bced2))
</details>

<details><summary>barretenberg: 0.32.0</summary>

##
[0.32.0](AztecProtocol/aztec-packages@barretenberg-v0.31.0...barretenberg-v0.32.0)
(2024-03-27)

### ⚠ BREAKING CHANGES

* Brillig typed memory
([#5395](AztecProtocol/aztec-packages#5395))

### Features

* **avm:** EQ opcode output u8 and execution
([#5402](AztecProtocol/aztec-packages#5402))
([3450e24](AztecProtocol/aztec-packages@3450e24)),
closes
[#5290](AztecProtocol/aztec-packages#5290)
* Brillig typed memory
([#5395](AztecProtocol/aztec-packages#5395))
([16b0bdd](AztecProtocol/aztec-packages@16b0bdd))

### Bug Fixes

* **ci:** Fix earthly ctest
([#5424](AztecProtocol/aztec-packages#5424))
([9cac8a4](AztecProtocol/aztec-packages@9cac8a4))
* Serial bb builds for mac
([#5462](AztecProtocol/aztec-packages#5462))
([4317819](AztecProtocol/aztec-packages@4317819))

### Miscellaneous

* **avm:** Deterministic codegen from pil and some renaming
([#5476](AztecProtocol/aztec-packages#5476))
([ba834a4](AztecProtocol/aztec-packages@ba834a4))
* Fallback to building barretenberg targets sequentially when RAM
constrained
([#5426](AztecProtocol/aztec-packages#5426))
([29588e0](AztecProtocol/aztec-packages@29588e0))
* Introduce selectors to enable range checks of 8-bit and 16-bit sizes
([#5465](AztecProtocol/aztec-packages#5465))
([ef44674](AztecProtocol/aztec-packages@ef44674))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Mar 27, 2024
@AztecBot
[1 changes] chore: install dependencies for building docs dependencies (
70ef581 
noir-lang/noir#4646)

chore: add missing brace to workflow (noir-lang/noir#4654)
chore: delete `R1CSTransformer` (noir-lang/noir#4649)
fix: Slice coercions (noir-lang/noir#4640)
chore(ci): add warning sticky comment (noir-lang/noir#4647)
fix(ssa): Fix slice intrinsic handling in the capacity tracker  (noir-lang/noir#4643)
chore: fix versioning of `bn254_blackbox_solver` crate (noir-lang/noir#4638)
chore: fix acvm crates reporting errors as JS packages (noir-lang/noir#4637)
chore: Release Noir(0.26.0) (noir-lang/noir#4526)
chore: convert `BlockExpression` into a standard struct (noir-lang/noir#4623)
chore(github): Improve PR template "document later" checkbox description (noir-lang/noir#4625)
chore: Update integers.md to note support for Fields using `from_integer` (noir-lang/noir#4536)
chore: update docs with function names to match version 0.25.0 specifications (noir-lang/noir#4466)
feat: add specific error for attempting `string[x] = ".."` (noir-lang/noir#4611)
fix(ssa): Use accurate type during SSA AsSlice simplficiation (noir-lang/noir#4610)
@AztecBot AztecBot mentioned this pull request Mar 27, 2024
Closed
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Mar 28, 2024
@AztecBot
chore(master): Release 0.32.0 (#5455)
65ccd3a 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.32.0</summary>

##
[0.32.0](AztecProtocol/aztec-packages@aztec-package-v0.31.0...aztec-package-v0.32.0)
(2024-03-27)


### Features

* Sequencer checks list of allowed FPCs
([#5310](AztecProtocol/aztec-packages#5310))
([adf20dc](AztecProtocol/aztec-packages@adf20dc)),
closes
[#5000](AztecProtocol/aztec-packages#5000)
</details>

<details><summary>barretenberg.js: 0.32.0</summary>

##
[0.32.0](AztecProtocol/aztec-packages@barretenberg.js-v0.31.0...barretenberg.js-v0.32.0)
(2024-03-27)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.32.0</summary>

##
[0.32.0](AztecProtocol/aztec-packages@aztec-cli-v0.31.0...aztec-cli-v0.32.0)
(2024-03-27)


### Miscellaneous

* **aztec-cli:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.32.0</summary>

##
[0.32.0](AztecProtocol/aztec-packages@aztec-packages-v0.31.0...aztec-packages-v0.32.0)
(2024-03-27)


### ⚠ BREAKING CHANGES

* Brillig typed memory
([#5395](AztecProtocol/aztec-packages#5395))

### Features

* Add specific error for attempting `string[x] = ".."`
(noir-lang/noir#4611)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* **avm:** Dynamic gas costs for arithmetic, calldatacopy, and set
([#5473](AztecProtocol/aztec-packages#5473))
([bbd33fb](AztecProtocol/aztec-packages@bbd33fb))
* **avm:** EQ opcode output u8 and execution
([#5402](AztecProtocol/aztec-packages#5402))
([3450e24](AztecProtocol/aztec-packages@3450e24)),
closes
[#5290](AztecProtocol/aztec-packages#5290)
* Benchmark tx size with fee
([#5414](AztecProtocol/aztec-packages#5414))
([543f8a2](AztecProtocol/aztec-packages@543f8a2)),
closes
[#5403](AztecProtocol/aztec-packages#5403)
* Brillig typed memory
([#5395](AztecProtocol/aztec-packages#5395))
([16b0bdd](AztecProtocol/aztec-packages@16b0bdd))
* Sequencer checks list of allowed FPCs
([#5310](AztecProtocol/aztec-packages#5310))
([adf20dc](AztecProtocol/aztec-packages@adf20dc)),
closes
[#5000](AztecProtocol/aztec-packages#5000)


### Bug Fixes

* `l1-contracts/bootstrap.sh`
([#5479](AztecProtocol/aztec-packages#5479))
([f7d1d70](AztecProtocol/aztec-packages@f7d1d70))
* Add FPC to allowlist
([#5464](AztecProtocol/aztec-packages#5464))
([424960f](AztecProtocol/aztec-packages@424960f))
* **ci:** Fix earthly ctest
([#5424](AztecProtocol/aztec-packages#5424))
([9cac8a4](AztecProtocol/aztec-packages@9cac8a4))
* Docs example e2e test
([#5456](AztecProtocol/aztec-packages#5456))
([ae5126a](AztecProtocol/aztec-packages@ae5126a))
* Serial bb builds for mac
([#5462](AztecProtocol/aztec-packages#5462))
([4317819](AztecProtocol/aztec-packages@4317819))
* Slice coercions (noir-lang/noir#4640)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* **ssa:** Fix slice intrinsic handling in the capacity tracker
(noir-lang/noir#4643)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* **ssa:** Use accurate type during SSA AsSlice simplficiation
(noir-lang/noir#4610)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))


### Miscellaneous

* Append-only merkle tree generics
([#5355](AztecProtocol/aztec-packages#5355))
([ef7bf79](AztecProtocol/aztec-packages@ef7bf79))
* **avm:** Deterministic codegen from pil and some renaming
([#5476](AztecProtocol/aztec-packages#5476))
([ba834a4](AztecProtocol/aztec-packages@ba834a4))
* **avm:** Test cleanup and update yp to allow for zero gas
([#5459](AztecProtocol/aztec-packages#5459))
([1829741](AztecProtocol/aztec-packages@1829741))
* **avm:** Unify noir macros flow
([#5461](AztecProtocol/aztec-packages#5461))
([54aee58](AztecProtocol/aztec-packages@54aee58))
* **ci:** Add missing dependency to circleci config
([#5437](AztecProtocol/aztec-packages#5437))
([753cb78](AztecProtocol/aztec-packages@753cb78))
* **ci:** Add warning sticky comment
(noir-lang/noir#4647)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Convert `BlockExpression` into a standard struct
(noir-lang/noir#4623)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Delete `R1CSTransformer` (noir-lang/noir#4649)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Fallback to building barretenberg targets sequentially when RAM
constrained
([#5426](AztecProtocol/aztec-packages#5426))
([29588e0](AztecProtocol/aztec-packages@29588e0))
* Fix acvm crates reporting errors as JS packages
(noir-lang/noir#4637)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Fix versioning of `bn254_blackbox_solver` crate
(noir-lang/noir#4638)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* **github:** Improve PR template "document later" checkbox description
(noir-lang/noir#4625)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Introduce selectors to enable range checks of 8-bit and 16-bit sizes
([#5465](AztecProtocol/aztec-packages#5465))
([ef44674](AztecProtocol/aztec-packages@ef44674))
* Leveraging `Bufferable` in `pedersenHash(...)` and
`sha256ToField(...)`
([#5444](AztecProtocol/aztec-packages#5444))
([0e0748c](AztecProtocol/aztec-packages@0e0748c))
* Release Noir(0.26.0) (noir-lang/noir#4526)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Renaming rand() as unsafe_rand()
([#5457](AztecProtocol/aztec-packages#5457))
([19ad2bb](AztecProtocol/aztec-packages@19ad2bb)),
closes
[#3746](AztecProtocol/aztec-packages#3746)
* Replace relative paths to noir-protocol-circuits
([d332ad1](AztecProtocol/aztec-packages@d332ad1))
* Timestamp as u64 instead of a Field
([#5453](AztecProtocol/aztec-packages#5453))
([d80dbbf](AztecProtocol/aztec-packages@d80dbbf)),
closes
[#5446](AztecProtocol/aztec-packages#5446)
* Typed encrypted and unencrypted L2 log containers
([#5422](AztecProtocol/aztec-packages#5422))
([a4d4ee8](AztecProtocol/aztec-packages@a4d4ee8))
* Update docs with function names to match version 0.25.0 specifications
(noir-lang/noir#4466)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))
* Update integers.md to note support for Fields using `from_integer`
(noir-lang/noir#4536)
([27bd8d3](AztecProtocol/aztec-packages@27bd8d3))


### Documentation

* **yp:** Spec how bytecode is encoded in class registerer
([#5471](AztecProtocol/aztec-packages#5471))
([e3bced2](AztecProtocol/aztec-packages@e3bced2))
</details>

<details><summary>barretenberg: 0.32.0</summary>

##
[0.32.0](AztecProtocol/aztec-packages@barretenberg-v0.31.0...barretenberg-v0.32.0)
(2024-03-27)


### ⚠ BREAKING CHANGES

* Brillig typed memory
([#5395](AztecProtocol/aztec-packages#5395))

### Features

* **avm:** EQ opcode output u8 and execution
([#5402](AztecProtocol/aztec-packages#5402))
([3450e24](AztecProtocol/aztec-packages@3450e24)),
closes
[#5290](AztecProtocol/aztec-packages#5290)
* Brillig typed memory
([#5395](AztecProtocol/aztec-packages#5395))
([16b0bdd](AztecProtocol/aztec-packages@16b0bdd))


### Bug Fixes

* **ci:** Fix earthly ctest
([#5424](AztecProtocol/aztec-packages#5424))
([9cac8a4](AztecProtocol/aztec-packages@9cac8a4))
* Serial bb builds for mac
([#5462](AztecProtocol/aztec-packages#5462))
([4317819](AztecProtocol/aztec-packages@4317819))


### Miscellaneous

* **avm:** Deterministic codegen from pil and some renaming
([#5476](AztecProtocol/aztec-packages#5476))
([ba834a4](AztecProtocol/aztec-packages@ba834a4))
* Fallback to building barretenberg targets sequentially when RAM
constrained
([#5426](AztecProtocol/aztec-packages#5426))
([29588e0](AztecProtocol/aztec-packages@29588e0))
* Introduce selectors to enable range checks of 8-bit and 16-bit sizes
([#5465](AztecProtocol/aztec-packages#5465))
([ef44674](AztecProtocol/aztec-packages@ef44674))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
TomAFrench pushed a commit that referenced this pull request Apr 3, 2024
@jfecher @TomAFrench
fix: Slice coercions (#4640)
a61ccb0 
# Description

## Problem\*

Resolves #4639 

## Summary\*

The array to slice coercion was broken - and it seemingly has always
been so. The coercion never actually called `replace_expr` to replace
the original expression with the `as_slice(original_expr)` coercion.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
github-merge-queue bot pushed a commit that referenced this pull request Apr 10, 2024
@kevaundray
chore: Release Noir(0.27.0) (#4632)
606ff44 
🤖 I have created a release *beep* *boop*
---


<details><summary>0.27.0</summary>

## [0.27.0](v0.26.0...v0.27.0)
(2024-04-10)


### ⚠ BREAKING CHANGES

* Brillig typed memory
(AztecProtocol/aztec-packages#5395)

### Features

* **acir_gen:** Fold attribute at compile-time and initial non inlined
ACIR (AztecProtocol/aztec-packages#5341)
([a0f7474](a0f7474))
* **acvm_js:** Execute program
([#4694](#4694))
([386f6d0](386f6d0))
* **acvm:** Execute multiple circuits
(AztecProtocol/aztec-packages#5380)
([a0f7474](a0f7474))
* Add `remove_enable_side_effects` SSA pass
([#4224](#4224))
([94952db](94952db))
* Allow slices to brillig entry points
([#4713](#4713))
([62423d5](62423d5))
* Brillig typed memory
(AztecProtocol/aztec-packages#5395)
([0bc18c4](0bc18c4))
* **docs:** Documenting noir codegen
([#4454](#4454))
([24f6d85](24f6d85))
* Improve nargo check cli with --override flag and feedback for existing
files ([#4575](#4575))
([5e7fbd4](5e7fbd4))
* Improve optimisations on range constraints
([#4690](#4690))
([96b8110](96b8110))
* Improve SSA type-awareness in EQ and MUL instructions
([#4691](#4691))
([669f1a0](669f1a0))
* **nargo:** Multiple circuits info for binary programs
([#4719](#4719))
([50d2735](50d2735))


### Bug Fixes

* "Types in a binary operation should match, but found T and T"
([#4648](#4648))
([30c9f31](30c9f31))
* **acvm:** Mark outputs of Opcode::Call solvable
([#4708](#4708))
([8fea405](8fea405))
* Correct ICE panic messages in brillig `convert_black_box_call`
([#4761](#4761))
([f3eee6c](f3eee6c))
* Error when a type variable is unbound during monomorphization instead
of defaulting to Field
([#4674](#4674))
([03cdba4](03cdba4))
* Field comparisons
([#4704](#4704))
([079cb2a](079cb2a))
* Impl search no longer selects an impl if multiple are applicable
([#4662](#4662))
([0150600](0150600))
* Last use analysis & make it an SSA pass
([#4686](#4686))
([0d3d5fd](0d3d5fd))
* Slice coercions
([#4640](#4640))
([c0bae17](c0bae17))
* **ssa:** Accurate constant type for slice dummy data in flattening
([#4661](#4661))
([b87654e](b87654e))
* **ssa:** Do not use get_value_max_num_bits when we want pure type
information ([#4700](#4700))
([b55a580](b55a580))
* **ssa:** Fix slice intrinsic handling in the capacity tracker
([#4643](#4643))
([1b50ce1](1b50ce1))
* Unknown slice lengths coming from as_slice
([#4725](#4725))
([f21129e](f21129e))
* Update commit for noir-gates-diff
([#4773](#4773))
([a9766c5](a9766c5))
</details>

<details><summary>0.43.0</summary>

## [0.43.0](v0.42.0...v0.43.0)
(2024-04-10)


### ⚠ BREAKING CHANGES

* Brillig typed memory
(AztecProtocol/aztec-packages#5395)
* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
* automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
* Acir call opcode
(AztecProtocol/aztec-packages#4773)
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
* Internal as a macro
(AztecProtocol/aztec-packages#4898)
* move noir out of yarn-project
(AztecProtocol/aztec-packages#4479)
* note type ids
(AztecProtocol/aztec-packages#4500)
* rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
* init storage macro
(AztecProtocol/aztec-packages#4200)
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
* Sync commits from `aztec-packages`
([#4144](#4144))
* Breaking changes from aztec-packages
([#3955](#3955))
* Rename Arithmetic opcode to AssertZero
([#3840](#3840))
* Remove unused methods on ACIR opcodes
([#3841](#3841))

### Features

* Acir call opcode
(AztecProtocol/aztec-packages#4773)
([c3c9e19](c3c9e19))
* **acir_gen:** Fold attribute at compile-time and initial non inlined
ACIR (AztecProtocol/aztec-packages#5341)
([a0f7474](a0f7474))
* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
([13eb71b](13eb71b))
* **acvm_js:** Execute program
([#4694](#4694))
([386f6d0](386f6d0))
* **acvm:** Execute multiple circuits
(AztecProtocol/aztec-packages#5380)
([a0f7474](a0f7474))
* Add bit size to const opcode
(AztecProtocol/aztec-packages#4385)
([158c8ce](158c8ce))
* Add CMOV instruction to brillig and brillig gen
(AztecProtocol/aztec-packages#5308)
([13eb71b](13eb71b))
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
([158c8ce](158c8ce))
* Add instrumentation for tracking variables in debugging
([#4122](#4122))
([c58d691](c58d691))
* Add poseidon2 opcode implementation for acvm/brillig, and Noir
([#4398](#4398))
([10e8292](10e8292))
* Add support for overriding expression width
([#4117](#4117))
([c8026d5](c8026d5))
* Added cast opcode and cast calldata
(AztecProtocol/aztec-packages#4423)
([78ef013](78ef013))
* Allow brillig to read arrays directly from memory
(AztecProtocol/aztec-packages#4460)
([158c8ce](158c8ce))
* Allow nested arrays and vectors in Brillig foreign calls
(AztecProtocol/aztec-packages#4478)
([158c8ce](158c8ce))
* Allow variables and stack trace inspection in the debugger
([#4184](#4184))
([bf263fc](bf263fc))
* Automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
([13eb71b](13eb71b))
* **avm:** Back in avm context with macro - refactor context
(AztecProtocol/aztec-packages#4438)
([158c8ce](158c8ce))
* **avm:** Brillig CONST of size &gt; u128
(AztecProtocol/aztec-packages#5217)
([c3c9e19](c3c9e19))
* **aztec-nr:** Initial work for aztec public vm macro
(AztecProtocol/aztec-packages#4400)
([158c8ce](158c8ce))
* Backpropagate constants in ACIR during optimization
([#3926](#3926))
([aad0da0](aad0da0))
* Breaking changes from aztec-packages
([#3955](#3955))
([5be049e](5be049e))
* Brillig IR refactor
(AztecProtocol/aztec-packages#5233)
([c3c9e19](c3c9e19))
* Brillig typed memory
(AztecProtocol/aztec-packages#5395)
([0bc18c4](0bc18c4))
* Check initializer msg.sender matches deployer from address preimage
(AztecProtocol/aztec-packages#5222)
([c3c9e19](c3c9e19))
* Evaluation of dynamic assert messages
([#4101](#4101))
([c284e01](c284e01))
* Init storage macro
(AztecProtocol/aztec-packages#4200)
([158c8ce](158c8ce))
* Initial Earthly CI
(AztecProtocol/aztec-packages#5069)
([c3c9e19](c3c9e19))
* Internal as a macro
(AztecProtocol/aztec-packages#4898)
([5f57ebb](5f57ebb))
* New brillig field operations and refactor of binary operations
(AztecProtocol/aztec-packages#5208)
([c3c9e19](c3c9e19))
* Note type ids
(AztecProtocol/aztec-packages#4500)
([78ef013](78ef013))
* Remove range constraints from witnesses which are constrained to be
constants ([#3928](#3928))
([afe9c7a](afe9c7a))
* Remove replacement of boolean range opcodes with `AssertZero` opcodes
([#4107](#4107))
([dac0e87](dac0e87))
* Signed integer division and modulus in brillig gen
(AztecProtocol/aztec-packages#5279)
([c3c9e19](c3c9e19))
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
([c3c9e19](c3c9e19))
* Sync `aztec-packages`
([#4011](#4011))
([fee2452](fee2452))
* Sync commits from `aztec-packages`
([#4068](#4068))
([7a8f3a3](7a8f3a3))
* Sync commits from `aztec-packages`
([#4144](#4144))
([0205d3b](0205d3b))
* Sync from aztec-packages
([#4483](#4483))
([fe8f277](fe8f277))
* Sync from noir
(AztecProtocol/aztec-packages#5234)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5286)
([c3c9e19](c3c9e19))


### Bug Fixes

* **acvm:** Mark outputs of Opcode::Call solvable
([#4708](#4708))
([8fea405](8fea405))
* Noir test incorrect reporting
(AztecProtocol/aztec-packages#4925)
([5f57ebb](5f57ebb))
* Remove panic from `init_log_level` in `acvm_js`
([#4195](#4195))
([2e26530](2e26530))
* Return error rather instead of panicking on invalid circuit
([#3976](#3976))
([67201bf](67201bf))


### Miscellaneous Chores

* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
([158c8ce](158c8ce))
* Move noir out of yarn-project
(AztecProtocol/aztec-packages#4479)
([78ef013](78ef013))
* Remove unused methods on ACIR opcodes
([#3841](#3841))
([9e5d0e8](9e5d0e8))
* Rename Arithmetic opcode to AssertZero
([#3840](#3840))
([836f171](836f171))
* Rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
([158c8ce](158c8ce))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljklein michaeljklein michaeljklein approved these changes

@vezenovm vezenovm Awaiting requested review from vezenovm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array to slice coercion regression
3 participants
@jfecher @vezenovm @michaeljklein