refactor: append-only merkle tree generics #5355

alexghr · 2024-03-20T23:12:29Z

Give Merkle Trees generic type arguments for the leaves they store.

alexghr · 2024-03-20T23:12:42Z

refactor: append-only merkle tree generics #5355 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexghr and the rest of your teammates on Graphite

AztecBot · 2024-03-20T23:36:58Z

Benchmark results

Metrics with a significant change:

note_trial_decrypting_time_in_ms (32): 98.5 (+162%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 16b0bdd7 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,418	6,418	6,412
l1_rollup_execution_gas	585,751	585,751	585,745
l2_block_processing_time_in_ms	1,338 (+2%)	4,708 (-1%)	9,003 (+1%)
note_successful_decrypting_time_in_ms	187 (+4%)	531 (+2%)	997 (-1%)
note_trial_decrypting_time_in_ms	94.1 (+13%)	⚠️ 98.5 (+162%)	65.2 (+71%)
l2_block_building_time_in_ms	13,893 (+2%)	51,223 (+2%)	101,856 (+2%)
l2_block_rollup_simulation_time_in_ms	7,981 (+2%)	27,921 (+1%)	54,958 (+1%)
l2_block_public_tx_process_time_in_ms	5,886 (+3%)	23,250 (+2%)	46,801 (+4%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,936 (+6%)	26,263 (-2%)
note_history_successful_decrypting_time_in_ms	1,262 (-4%)	2,480
note_history_trial_decrypting_time_in_ms	101 (-7%)	156 (+3%)
node_database_size_in_bytes	18,649,168	35,106,896 (+1%)
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	233	44,379	28,214
private-kernel-ordering	206 (+1%)	52,880	14,296
base-parity	3,926 (+9%)	128	311
root-parity	1,353 (+13%)	1,244	311
base-rollup	17,089 (+4%)	165,760	861
root-rollup	50.4	4,359	725
private-kernel-inner	303 (+2%)	73,795	28,214
public-kernel-app-logic	125 (+3%)	35,252	28,217
public-kernel-tail	169 (+2%)	40,928	28,217
merge-rollup	10.1 (+11%)	2,568	861
public-kernel-teardown	119 (+2%)	35,252	28,217
public-kernel-setup	118 (+3%)	35,252	28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1	16.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.587	0.498	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.9 (-3%)	72.2	232 (-1%)	447	875	1,728	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.481 (-3%)	0.445	0.422 (-1%)	0.417	0.415	0.414	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	55.5 (+1%)	107	340	661 (-2%)	1,315	2,621	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104 (-1%)	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.491 (+1%)	0.481	0.461 (-1%)	0.455 (-2%)	0.455	0.454	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.4 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.536

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,968	495,185

Transaction size based on fee payment method

Metric	none fee payment method	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	773	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	2,183 (+3%)	1,393 (+1%)	4,885 (+4%)

Metric	0 public data writes	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	14.3 (+18%)	724 (+3%)	538 (+4%)	1,461 (+2%)	590 (+2%)	2,543 (+2%)	681 (+2%)

spalladino

API looks a lot nicer, thanks for tackling this! I left a bunch of "Here" comments just as bookmarks so I can try doing something about those anys later, but I doubt I'll be able to crack it.

spalladino · 2024-03-21T14:24:45Z

yarn-project/world-state/src/world-state-db/merkle_tree_operations_facade.ts

+    treeId: ID,
+    index: bigint,
+  ): Promise<MerkleTreeLeafType<typeof treeId> | undefined> {
+    return this.trees.getLeafValue(treeId, index, this.includeUncommitted) as Promise<


spalladino · 2024-03-21T14:24:52Z

yarn-project/world-state/src/world-state-db/merkle_tree_snapshot_operations_facade.ts


 /**
 * Merkle tree operations on readonly tree snapshots.
 */
 export class MerkleTreeSnapshotOperationsFacade implements MerkleTreeOperations {
  #treesDb: MerkleTreeDb;
  #blockNumber: number;
-  #treeSnapshots: ReadonlyArray<TreeSnapshot | IndexedTreeSnapshot> = [];
+  #treeSnapshots: TreeSnapshots = {} as any;


spalladino · 2024-03-21T14:24:57Z

yarn-project/world-state/src/world-state-db/merkle_tree_snapshot_operations_facade.ts

    const tree = await this.#getTreeSnapshot(treeId);
-    return tree.findLeafIndex(value);
+    return tree.findLeafIndex(value as any);


spalladino · 2024-03-21T14:25:40Z

yarn-project/world-state/src/world-state-db/merkle_trees.ts

    includeUncommitted: boolean,
  ): Promise<bigint | undefined> {
    return await this.synchronize(() => {
      const tree = this.trees[treeId];
-      return Promise.resolve(tree.findLeafIndex(value, includeUncommitted));
+      return Promise.resolve(tree.findLeafIndex(value as any, includeUncommitted));


spalladino · 2024-03-21T14:25:51Z

yarn-project/world-state/src/world-state-db/merkle_trees.ts

    const tree = this.trees[treeId];
    if (!('appendLeaves' in tree)) {
      throw new Error('Tree does not support `appendLeaves` method');
    }
-    return await tree.appendLeaves(leaves);
+    return await tree.appendLeaves(leaves as any[]);


spalladino · 2024-03-21T14:25:56Z

yarn-project/world-state/src/world-state-db/merkle_trees.ts

@@ -64,7 +92,8 @@ class PublicDataTree extends StandardIndexedTree {
 * A convenience class for managing multiple merkle trees.
 */
 export class MerkleTrees implements MerkleTreeDb {
-  private trees: (AppendOnlyTree | UpdateOnlyTree)[] = [];
+  // gets initialized in #init
+  private trees: MerkleTreeMap = null as any;


I'd move the initialization logic to the static new method, and have the constructor receive the MerkleTreeMap already initialized, so we don't have to do this hack.

yarn-project/world-state/src/world-state-db/merkle_trees.ts

spalladino · 2024-03-21T14:26:51Z

cspell.json

@@ -79,6 +79,7 @@
    "erc",
    "falsey",
    "fargate",
+    "Fieldeable",


Where did you end up using it?

The type exists already and it has a squiggly line 😬

aztec-packages/yarn-project/foundation/src/serialize/serialize.ts

Line 124 in dfffe5d

export type Fieldeable =

PhilWindle

This is really nice!

yarn-project/merkle-tree/src/snapshots/snapshot_builder_test_suite.ts

alexghr · 2024-03-26T11:29:48Z

I have created #5448 to track all of the as any left in the codebase due to this PR and left comments referencing the issue in the codebase :)

Thanks for fixing the snapshots @spalladino

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.32.0</summary> ## [0.32.0](aztec-package-v0.31.0...aztec-package-v0.32.0) (2024-03-27) ### Features * Sequencer checks list of allowed FPCs ([#5310](#5310)) ([adf20dc](adf20dc)), closes [#5000](#5000) </details> <details><summary>barretenberg.js: 0.32.0</summary> ## [0.32.0](barretenberg.js-v0.31.0...barretenberg.js-v0.32.0) (2024-03-27) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.32.0</summary> ## [0.32.0](aztec-cli-v0.31.0...aztec-cli-v0.32.0) (2024-03-27) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.32.0</summary> ## [0.32.0](aztec-packages-v0.31.0...aztec-packages-v0.32.0) (2024-03-27) ### ⚠ BREAKING CHANGES * Brillig typed memory ([#5395](#5395)) ### Features * Add specific error for attempting `string[x] = ".."` (noir-lang/noir#4611) ([27bd8d3](27bd8d3)) * **avm:** Dynamic gas costs for arithmetic, calldatacopy, and set ([#5473](#5473)) ([bbd33fb](bbd33fb)) * **avm:** EQ opcode output u8 and execution ([#5402](#5402)) ([3450e24](3450e24)), closes [#5290](#5290) * Benchmark tx size with fee ([#5414](#5414)) ([543f8a2](543f8a2)), closes [#5403](#5403) * Brillig typed memory ([#5395](#5395)) ([16b0bdd](16b0bdd)) * Sequencer checks list of allowed FPCs ([#5310](#5310)) ([adf20dc](adf20dc)), closes [#5000](#5000) ### Bug Fixes * `l1-contracts/bootstrap.sh` ([#5479](#5479)) ([f7d1d70](f7d1d70)) * Add FPC to allowlist ([#5464](#5464)) ([424960f](424960f)) * **ci:** Fix earthly ctest ([#5424](#5424)) ([9cac8a4](9cac8a4)) * Docs example e2e test ([#5456](#5456)) ([ae5126a](ae5126a)) * Serial bb builds for mac ([#5462](#5462)) ([4317819](4317819)) * Slice coercions (noir-lang/noir#4640) ([27bd8d3](27bd8d3)) * **ssa:** Fix slice intrinsic handling in the capacity tracker (noir-lang/noir#4643) ([27bd8d3](27bd8d3)) * **ssa:** Use accurate type during SSA AsSlice simplficiation (noir-lang/noir#4610) ([27bd8d3](27bd8d3)) ### Miscellaneous * Append-only merkle tree generics ([#5355](#5355)) ([ef7bf79](ef7bf79)) * **avm:** Deterministic codegen from pil and some renaming ([#5476](#5476)) ([ba834a4](ba834a4)) * **avm:** Test cleanup and update yp to allow for zero gas ([#5459](#5459)) ([1829741](1829741)) * **avm:** Unify noir macros flow ([#5461](#5461)) ([54aee58](54aee58)) * **ci:** Add missing dependency to circleci config ([#5437](#5437)) ([753cb78](753cb78)) * **ci:** Add warning sticky comment (noir-lang/noir#4647) ([27bd8d3](27bd8d3)) * Convert `BlockExpression` into a standard struct (noir-lang/noir#4623) ([27bd8d3](27bd8d3)) * Delete `R1CSTransformer` (noir-lang/noir#4649) ([27bd8d3](27bd8d3)) * Fallback to building barretenberg targets sequentially when RAM constrained ([#5426](#5426)) ([29588e0](29588e0)) * Fix acvm crates reporting errors as JS packages (noir-lang/noir#4637) ([27bd8d3](27bd8d3)) * Fix versioning of `bn254_blackbox_solver` crate (noir-lang/noir#4638) ([27bd8d3](27bd8d3)) * **github:** Improve PR template "document later" checkbox description (noir-lang/noir#4625) ([27bd8d3](27bd8d3)) * Introduce selectors to enable range checks of 8-bit and 16-bit sizes ([#5465](#5465)) ([ef44674](ef44674)) * Leveraging `Bufferable` in `pedersenHash(...)` and `sha256ToField(...)` ([#5444](#5444)) ([0e0748c](0e0748c)) * Release Noir(0.26.0) (noir-lang/noir#4526) ([27bd8d3](27bd8d3)) * Renaming rand() as unsafe_rand() ([#5457](#5457)) ([19ad2bb](19ad2bb)), closes [#3746](#3746) * Replace relative paths to noir-protocol-circuits ([d332ad1](d332ad1)) * Timestamp as u64 instead of a Field ([#5453](#5453)) ([d80dbbf](d80dbbf)), closes [#5446](#5446) * Typed encrypted and unencrypted L2 log containers ([#5422](#5422)) ([a4d4ee8](a4d4ee8)) * Update docs with function names to match version 0.25.0 specifications (noir-lang/noir#4466) ([27bd8d3](27bd8d3)) * Update integers.md to note support for Fields using `from_integer` (noir-lang/noir#4536) ([27bd8d3](27bd8d3)) ### Documentation * **yp:** Spec how bytecode is encoded in class registerer ([#5471](#5471)) ([e3bced2](e3bced2)) </details> <details><summary>barretenberg: 0.32.0</summary> ## [0.32.0](barretenberg-v0.31.0...barretenberg-v0.32.0) (2024-03-27) ### ⚠ BREAKING CHANGES * Brillig typed memory ([#5395](#5395)) ### Features * **avm:** EQ opcode output u8 and execution ([#5402](#5402)) ([3450e24](3450e24)), closes [#5290](#5290) * Brillig typed memory ([#5395](#5395)) ([16b0bdd](16b0bdd)) ### Bug Fixes * **ci:** Fix earthly ctest ([#5424](#5424)) ([9cac8a4](9cac8a4)) * Serial bb builds for mac ([#5462](#5462)) ([4317819](4317819)) ### Miscellaneous * **avm:** Deterministic codegen from pil and some renaming ([#5476](#5476)) ([ba834a4](ba834a4)) * Fallback to building barretenberg targets sequentially when RAM constrained ([#5426](#5426)) ([29588e0](29588e0)) * Introduce selectors to enable range checks of 8-bit and 16-bit sizes ([#5465](#5465)) ([ef44674](ef44674)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.32.0</summary> ## [0.32.0](AztecProtocol/aztec-packages@aztec-package-v0.31.0...aztec-package-v0.32.0) (2024-03-27) ### Features * Sequencer checks list of allowed FPCs ([#5310](AztecProtocol/aztec-packages#5310)) ([adf20dc](AztecProtocol/aztec-packages@adf20dc)), closes [#5000](AztecProtocol/aztec-packages#5000) </details> <details><summary>barretenberg.js: 0.32.0</summary> ## [0.32.0](AztecProtocol/aztec-packages@barretenberg.js-v0.31.0...barretenberg.js-v0.32.0) (2024-03-27) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.32.0</summary> ## [0.32.0](AztecProtocol/aztec-packages@aztec-cli-v0.31.0...aztec-cli-v0.32.0) (2024-03-27) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.32.0</summary> ## [0.32.0](AztecProtocol/aztec-packages@aztec-packages-v0.31.0...aztec-packages-v0.32.0) (2024-03-27) ### ⚠ BREAKING CHANGES * Brillig typed memory ([#5395](AztecProtocol/aztec-packages#5395)) ### Features * Add specific error for attempting `string[x] = ".."` (noir-lang/noir#4611) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) * **avm:** Dynamic gas costs for arithmetic, calldatacopy, and set ([#5473](AztecProtocol/aztec-packages#5473)) ([bbd33fb](AztecProtocol/aztec-packages@bbd33fb)) * **avm:** EQ opcode output u8 and execution ([#5402](AztecProtocol/aztec-packages#5402)) ([3450e24](AztecProtocol/aztec-packages@3450e24)), closes [#5290](AztecProtocol/aztec-packages#5290) * Benchmark tx size with fee ([#5414](AztecProtocol/aztec-packages#5414)) ([543f8a2](AztecProtocol/aztec-packages@543f8a2)), closes [#5403](AztecProtocol/aztec-packages#5403) * Brillig typed memory ([#5395](AztecProtocol/aztec-packages#5395)) ([16b0bdd](AztecProtocol/aztec-packages@16b0bdd)) * Sequencer checks list of allowed FPCs ([#5310](AztecProtocol/aztec-packages#5310)) ([adf20dc](AztecProtocol/aztec-packages@adf20dc)), closes [#5000](AztecProtocol/aztec-packages#5000) ### Bug Fixes * `l1-contracts/bootstrap.sh` ([#5479](AztecProtocol/aztec-packages#5479)) ([f7d1d70](AztecProtocol/aztec-packages@f7d1d70)) * Add FPC to allowlist ([#5464](AztecProtocol/aztec-packages#5464)) ([424960f](AztecProtocol/aztec-packages@424960f)) * **ci:** Fix earthly ctest ([#5424](AztecProtocol/aztec-packages#5424)) ([9cac8a4](AztecProtocol/aztec-packages@9cac8a4)) * Docs example e2e test ([#5456](AztecProtocol/aztec-packages#5456)) ([ae5126a](AztecProtocol/aztec-packages@ae5126a)) * Serial bb builds for mac ([#5462](AztecProtocol/aztec-packages#5462)) ([4317819](AztecProtocol/aztec-packages@4317819)) * Slice coercions (noir-lang/noir#4640) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) * **ssa:** Fix slice intrinsic handling in the capacity tracker (noir-lang/noir#4643) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) * **ssa:** Use accurate type during SSA AsSlice simplficiation (noir-lang/noir#4610) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) ### Miscellaneous * Append-only merkle tree generics ([#5355](AztecProtocol/aztec-packages#5355)) ([ef7bf79](AztecProtocol/aztec-packages@ef7bf79)) * **avm:** Deterministic codegen from pil and some renaming ([#5476](AztecProtocol/aztec-packages#5476)) ([ba834a4](AztecProtocol/aztec-packages@ba834a4)) * **avm:** Test cleanup and update yp to allow for zero gas ([#5459](AztecProtocol/aztec-packages#5459)) ([1829741](AztecProtocol/aztec-packages@1829741)) * **avm:** Unify noir macros flow ([#5461](AztecProtocol/aztec-packages#5461)) ([54aee58](AztecProtocol/aztec-packages@54aee58)) * **ci:** Add missing dependency to circleci config ([#5437](AztecProtocol/aztec-packages#5437)) ([753cb78](AztecProtocol/aztec-packages@753cb78)) * **ci:** Add warning sticky comment (noir-lang/noir#4647) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) * Convert `BlockExpression` into a standard struct (noir-lang/noir#4623) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) * Delete `R1CSTransformer` (noir-lang/noir#4649) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) * Fallback to building barretenberg targets sequentially when RAM constrained ([#5426](AztecProtocol/aztec-packages#5426)) ([29588e0](AztecProtocol/aztec-packages@29588e0)) * Fix acvm crates reporting errors as JS packages (noir-lang/noir#4637) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) * Fix versioning of `bn254_blackbox_solver` crate (noir-lang/noir#4638) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) * **github:** Improve PR template "document later" checkbox description (noir-lang/noir#4625) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) * Introduce selectors to enable range checks of 8-bit and 16-bit sizes ([#5465](AztecProtocol/aztec-packages#5465)) ([ef44674](AztecProtocol/aztec-packages@ef44674)) * Leveraging `Bufferable` in `pedersenHash(...)` and `sha256ToField(...)` ([#5444](AztecProtocol/aztec-packages#5444)) ([0e0748c](AztecProtocol/aztec-packages@0e0748c)) * Release Noir(0.26.0) (noir-lang/noir#4526) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) * Renaming rand() as unsafe_rand() ([#5457](AztecProtocol/aztec-packages#5457)) ([19ad2bb](AztecProtocol/aztec-packages@19ad2bb)), closes [#3746](AztecProtocol/aztec-packages#3746) * Replace relative paths to noir-protocol-circuits ([d332ad1](AztecProtocol/aztec-packages@d332ad1)) * Timestamp as u64 instead of a Field ([#5453](AztecProtocol/aztec-packages#5453)) ([d80dbbf](AztecProtocol/aztec-packages@d80dbbf)), closes [#5446](AztecProtocol/aztec-packages#5446) * Typed encrypted and unencrypted L2 log containers ([#5422](AztecProtocol/aztec-packages#5422)) ([a4d4ee8](AztecProtocol/aztec-packages@a4d4ee8)) * Update docs with function names to match version 0.25.0 specifications (noir-lang/noir#4466) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) * Update integers.md to note support for Fields using `from_integer` (noir-lang/noir#4536) ([27bd8d3](AztecProtocol/aztec-packages@27bd8d3)) ### Documentation * **yp:** Spec how bytecode is encoded in class registerer ([#5471](AztecProtocol/aztec-packages#5471)) ([e3bced2](AztecProtocol/aztec-packages@e3bced2)) </details> <details><summary>barretenberg: 0.32.0</summary> ## [0.32.0](AztecProtocol/aztec-packages@barretenberg-v0.31.0...barretenberg-v0.32.0) (2024-03-27) ### ⚠ BREAKING CHANGES * Brillig typed memory ([#5395](AztecProtocol/aztec-packages#5395)) ### Features * **avm:** EQ opcode output u8 and execution ([#5402](AztecProtocol/aztec-packages#5402)) ([3450e24](AztecProtocol/aztec-packages@3450e24)), closes [#5290](AztecProtocol/aztec-packages#5290) * Brillig typed memory ([#5395](AztecProtocol/aztec-packages#5395)) ([16b0bdd](AztecProtocol/aztec-packages@16b0bdd)) ### Bug Fixes * **ci:** Fix earthly ctest ([#5424](AztecProtocol/aztec-packages#5424)) ([9cac8a4](AztecProtocol/aztec-packages@9cac8a4)) * Serial bb builds for mac ([#5462](AztecProtocol/aztec-packages#5462)) ([4317819](AztecProtocol/aztec-packages@4317819)) ### Miscellaneous * **avm:** Deterministic codegen from pil and some renaming ([#5476](AztecProtocol/aztec-packages#5476)) ([ba834a4](AztecProtocol/aztec-packages@ba834a4)) * Fallback to building barretenberg targets sequentially when RAM constrained ([#5426](AztecProtocol/aztec-packages#5426)) ([29588e0](AztecProtocol/aztec-packages@29588e0)) * Introduce selectors to enable range checks of 8-bit and 16-bit sizes ([#5465](AztecProtocol/aztec-packages#5465)) ([ef44674](AztecProtocol/aztec-packages@ef44674)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

spalladino approved these changes Mar 21, 2024

View reviewed changes

PhilWindle reviewed Mar 22, 2024

View reviewed changes

yarn-project/merkle-tree/src/snapshots/snapshot_builder_test_suite.ts Outdated Show resolved Hide resolved

alexghr force-pushed the 03-20-refactor_append-only_merkle_tree_generics branch from 9a8af31 to 9b26b13 Compare March 25, 2024 11:26

alexghr marked this pull request as ready for review March 25, 2024 11:26

alexghr force-pushed the 03-20-refactor_append-only_merkle_tree_generics branch from 9b26b13 to 26ca197 Compare March 25, 2024 12:02

alexghr mentioned this pull request Mar 26, 2024

Fix "as any" in merkle tree find operations #5448

Closed

alexghr force-pushed the 03-20-refactor_append-only_merkle_tree_generics branch from 26ca197 to a8497ac Compare March 26, 2024 11:26

alexghr force-pushed the 03-20-refactor_append-only_merkle_tree_generics branch 2 times, most recently from 19e2df3 to fd4f972 Compare March 26, 2024 14:17

alexghr enabled auto-merge (squash) March 26, 2024 14:17

alexghr and others added 2 commits March 26, 2024 14:31

refactor: append-only merkle tree generics

93ce80a

Remove anys in getSnapshot

0060129

alexghr force-pushed the 03-20-refactor_append-only_merkle_tree_generics branch from fd4f972 to 0060129 Compare March 26, 2024 14:32

alexghr merged commit ef7bf79 into master Mar 26, 2024
105 of 138 checks passed

alexghr deleted the 03-20-refactor_append-only_merkle_tree_generics branch March 26, 2024 15:01

AztecBot mentioned this pull request Mar 26, 2024

chore(master): Release 0.32.0 #5455

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: append-only merkle tree generics #5355

refactor: append-only merkle tree generics #5355

alexghr commented Mar 20, 2024

alexghr commented Mar 20, 2024

AztecBot commented Mar 20, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

spalladino left a comment

spalladino Mar 21, 2024

spalladino Mar 21, 2024

spalladino Mar 21, 2024

spalladino Mar 21, 2024

spalladino Mar 21, 2024

spalladino Mar 21, 2024

spalladino Mar 21, 2024

alexghr Mar 26, 2024

PhilWindle left a comment

alexghr commented Mar 26, 2024 •

edited

Loading

refactor: append-only merkle tree generics #5355

refactor: append-only merkle tree generics #5355

Conversation

alexghr commented Mar 20, 2024

alexghr commented Mar 20, 2024

AztecBot commented Mar 20, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

spalladino left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PhilWindle left a comment

Choose a reason for hiding this comment

alexghr commented Mar 26, 2024 • edited Loading

AztecBot commented Mar 20, 2024 •

edited

Loading

alexghr commented Mar 26, 2024 •

edited

Loading