chore: Typed encrypted and unencrypted L2 log containers

[spalladino]

The FunctionL2Logs class held untyped buffers as logs, rather than deserialize them into UnencryptedL2Log objects or Encrypted ones (the latter didn't exist). This led to bugs where a user would parse the buffer incorrectly (eg here).

This PR types the logs FunctionL2Logs as either Encrypted or Unencrypted logs, and introduces Encrypted and Unencrypted versions for Function, Tx, and BlockLogs containers.

[fcarreiro]

Approval for public_executor files. Doesn't seem to really impact AVM. I'll let actual reviewers give LGTM and formal approval.

[benesjan]

Very nice. LGTM

[benesjan]

Do you know why we suddenly need the cast here?

[spalladino]

The RemoteObject wrapper was failing to handle the conditional return type for getLogs

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit ef446747 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,406	6,412
l1_rollup_execution_gas	585,745	585,739	585,745
l2_block_processing_time_in_ms	1,329 (+2%)	4,750 (-2%)	9,070 (-3%)
note_successful_decrypting_time_in_ms	186 (-27%)	533 (-9%)	1,003 (+5%)
note_trial_decrypting_time_in_ms	91.2 (+51%)	101 (-1%)	82.6 (-5%)
l2_block_building_time_in_ms	13,870 (+2%)	51,014 (+2%)	101,307 (+2%)
l2_block_rollup_simulation_time_in_ms	7,993 (+1%)	27,894 (+1%)	55,142 (+1%)
l2_block_public_tx_process_time_in_ms	5,855 (+3%)	23,069 (+3%)	46,065 (+3%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,871 (-5%)	26,845
note_history_successful_decrypting_time_in_ms	1,244 (-9%)	2,477 (-3%)
note_history_trial_decrypting_time_in_ms	92.9 (-33%)	132 (-32%)
node_database_size_in_bytes	18,675,792	35,045,456
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	233 (+2%)	44,378	28,214
private-kernel-ordering	206 (+2%)	52,880	14,296
base-parity	3,925 (+11%)	128	311
root-parity	1,451 (+12%)	1,244	311
base-rollup	17,226 (+5%)	165,760	861
root-rollup	50.6 (+2%)	4,359	725
private-kernel-inner	301 (+3%)	73,794	28,214
public-kernel-app-logic	127 (+6%)	35,251	28,217
public-kernel-tail	171 (+4%)	40,928	28,217
merge-rollup	8.51 (+2%)	2,568	861
public-kernel-teardown	117 (-1%)	35,252	28,217
public-kernel-setup	116 (-1%)	35,252	28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1	16.1 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.588	0.495 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.7 (-2%)	72.1	233 (+1%)	449	883 (+1%)	1,724	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.479 (-2%)	0.445	0.424 (+1%)	0.420	0.419 (+1%)	0.413	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	55.2	107	338 (-1%)	662	1,314	2,618 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104 (-1%)	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.487 (+1%)	0.480	0.460	0.455	0.454	0.455	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.5 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.537 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,967	495,185

Transaction size based on fee payment method

Metric	none fee payment method	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	773	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	2,187 (+4%)	1,394 (+2%)	4,784 (+1%)

Metric	0 public data writes	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	10.5 (-20%)	733 (+5%)	526 (+1%)	1,443 (-1%)	583 (-1%)	2,506	676