-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for the procedures for insertion/hot swap of Switch Fabric Module(SFM) by using "config chassis modules shutdown/startup" commands #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule (SFM) 1. Add chassis_module_config.py and its service. 2. When the cli command "sudo config chassis modules startup/shutdown" runs, calls chassis_module_set_admin_state.py to do the ralated operations.
mlok-nokia
reviewed
Apr 5, 2024
mlok-nokia
reviewed
Apr 5, 2024
mlok-nokia
reviewed
Apr 5, 2024
wumiaont
reviewed
Apr 8, 2024
jon-nokia
reviewed
Apr 8, 2024
This was referenced Apr 23, 2024
These two PRs have been replaced by the below new two PRS: sonic-net/sonic-utilities#3283 |
wumiaont
reviewed
Apr 25, 2024
mlok-nokia
reviewed
Apr 26, 2024
mlok-nokia
pushed a commit
that referenced
this pull request
May 9, 2024
…ule(SFM) by using "config chassis modules shutdown/startup" commands (#6) * Update for the Procedures for insertion/hot swap of Switch Fabric Module (SFM) 1. Add chassis_module_config.py and its service. 2. When the cli command "sudo config chassis modules startup/shutdown" runs, calls chassis_module_set_admin_state.py to do the ralated operations. * Fix some issues based on the review comments. * Fix a issue of syslog setting to enable the logger.log_info output. * Update for the procedures for insertion/hot swap of Switch Fabric Module(SFM) by using "config chassis modules shutdown/startup" commands * Revert "Fix a issue of syslog setting to enable the logger.log_info output." This reverts commit 8b30671. * Revert "Fix some issues based on the review comments." This reverts commit 4088912. * Revert "Update for the Procedures for insertion/hot swap of Switch Fabric Module (SFM)" This reverts commit f5ce311. * Update for the procedures for insertion/hot swap of Switch Fabric Module(SFM) by using "config chassis modules shutdown/startup" commands * Remove some log lines based on review comments. * Remove some log lines based on review comments. (cherry picked from commit 20f82d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
For the Nokia SONiC chassis procedures for insertion/hot swap of Switch Fabric Module(SFM),
the previous solution was using the below commands.
The below 4 PRs intend to add the below commands for the equivalent operations.
sonic-net/sonic-platform-daemons#491
sonic-net/sonic-utilities#3283
#6
sonic-net/sonic-buildimage#18938
The HLD for Shutdown and Startup of the Fabric Module is below:
sonic-net/SONiC#1694
The below PR was replaced.
sonic-net/sonic-buildimage#18578
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)