Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nokia PMON submodule #18938

Closed

Conversation

mlok-nokia
Copy link
Contributor

@mlok-nokia mlok-nokia commented May 10, 2024

Why I did it

Update Nokia sonic-platform submodule which contains commits below
Update for the procedures for insertion/hot swap of Switch Fabric Module(SFM) by using "config chassis modules shutdown/startup" commands (#6)

This PR associates with PRs below to support "config chassis module shutdown/startup <module_name>" command Fabric module in Nokia-IXR7250E platform
PR sonic-net/sonic-utilities#3283
PR sonic-net/sonic-platform-daemons#475

Work item tracking
  • Microsoft ADO (number only):

How I did it

Modify the set_admin_status() in module.py to shutdown/startup a Fabric Module.

How to verify it

The below test was carried out on FABRIC-CARD3 module on the supervisor card.
1. Shutdown
sudo config chassis modules shutdown FABRIC-CARD3

2. Check the status to see if the FABRIC-CARD3 was down.
$ show chassis modules status
        Name             Description    Physical-Slot    Oper-Status    Admin-Status       Serial
------------  ----------------------  ---------------  -------------  --------------  -----------
...
FABRIC-CARD3             Unavailable                4          Empty            down          N/A

sudo tail -f /var/log/syslog | grep "pmon#chassisd:"
May  1 00:07:54.192037 ixre-cpm-chassis15 WARNING pmon#chassisd: Module FABRIC-CARD3 went off-line!
 ...

 
3. Start up the module
sudo config chassis modules startup FABRIC-CARD3


4. Check the status
$ show chassis modules status
        Name             Description    Physical-Slot    Oper-Status    Admin-Status       Serial
------------  ----------------------  ---------------  -------------  --------------  -----------
...
FABRIC-CARD3                    SFM4                4         Online              up  01214400362

sudo tail -f /var/log/syslog | grep "pmon#chassisd:"
May  1 00:26:29.501687 ixre-cpm-chassis15 NOTICE pmon#chassisd: Module FABRIC-CARD3 recovered on-line!


5. To test if the operation is still valid when the system reboot. For example, first shut down, 
then after saving config and reboot, the module should keep shutdown status. 
$ sudo config save
Existing files will be overwritten, continue? [y/N]: y

Then check the status to see if the FABRIC-CARD3 was down.
$ show chassis modules status
        Name             Description    Physical-Slot    Oper-Status    Admin-Status       Serial
------------  ----------------------  ---------------  -------------  --------------  -----------
...
FABRIC-CARD3             Unavailable                4          Empty            down          N/A


Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Update for the procedures for insertion/hot swap of Switch Fabric Module(SFM) by using "config chassis modules shutdown/startup" commands (sonic-net#6)

Signed-off-by: mlok <marty.lok@nokia.com>
@mlok-nokia mlok-nokia requested a review from lguohan as a code owner May 10, 2024 14:28
@mlok-nokia
Copy link
Contributor Author

@judyjoseph Here is the PR to update the Nokia sonic-platform submodule to support "config chassis module shutdown/startup <module_name>" command for FABRIC module on Nokia-IXR7250 Supervisor card.

@JunhongMao
Copy link
Contributor

The HLD for Shutdown and Startup of the Fabric Module is below:
sonic-net/SONiC#1694

@judyjoseph
Copy link
Contributor

@JunhongMao @mlok-nokia please raise PR for master branch first for this change, we can cherry-pick to 202205 branch later.

@gechiang
Copy link
Collaborator

gechiang commented Jun 5, 2024

@mlok-nokia , is there a corresponding Master PR for this? I see that this PR is no longer needed as you already raised on directly in the MSFT repo 202205 branch (sonic-net/sonic-buildimage-msft#387).
But what is not clear is where is this same change for master branch? if not yet raised, can you please raise it in master first?
Thanks!

@gechiang
Copy link
Collaborator

gechiang commented Jun 6, 2024

@mlok-nokia , is there a corresponding Master PR for this? I see that this PR is no longer needed as you already raised on directly in the MSFT repo 202205 branch (sonic-net/sonic-buildimage-msft#387). But what is not clear is where is this same change for master branch? if not yet raised, can you please raise it in master first? Thanks!

According to @judyjoseph the master PR is this one: #18497

@judyjoseph
Copy link
Contributor

@gechiang the change in this PR is already present in master via nokia platform submodule update done in PR : #18497.

Since we cannot take this PR in 202205 public branch, we have raised this new PR : sonic-net/sonic-buildimage-msft#387 in MSFT repo. Please merge

@judyjoseph
Copy link
Contributor

we will be closing this PR

@mlok-nokia
Copy link
Contributor Author

Close this PR. PR sonic-net/sonic-buildimage-msft#387 has been used for 202205 sonic-buildimage-msft

@mlok-nokia mlok-nokia closed this Jun 7, 2024
@mlok-nokia mlok-nokia deleted the update-nokia-pmon-submodule branch September 27, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants