-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement queries #7 #74
Conversation
@nolanlawson This works but I do not like it. I wish to work with |
@leojpod Interesting. Is it not better in this case to use https://github.com/brianreavis/sifter.js/ than write your own? |
@broerse not sure if it is worse the trouble for his case: it is a temporary solution, using Do you think we should add support for more than regex and straight equal ? |
Regex and straight equal is fine. I only tend to us sifter.js when I need filtering and was wondering if I would use this. Thanks for this PR. |
I do think that the first step ought to be to integrate pouchdb-find into relational-pouch. Sorry for the radio silence, but I've been on vacation for the past few weeks. :) This next weekend I'll try to do a big push to get pouchdb-find closer to production status, and to get it integrated into relational-pouch. I know it's been a big ask from the community, so it's number one on my priority list. |
Related to pouchdb-community/relational-pouch#3 |
@nolanlawson just asking about what you are going to work on it , is it related to hasMany issue ? because I believe this is something need to solve soon because those issues has very close relation. Btw, nice work ... thanks a lot |
@patuku-roy The hasMany issue should be fixed with |
I'm not sure when ember-data added _shouldSerializeHasMany: function() { return true; } |
@broerse I don't have a chance yet to try that way, I will post the feedback if I have a chance, meanwhile I'm working on other stuff, while waiting the query stuff in here. @fsmanuel unfortunately I'm stuck with ED Beta-18 right now, the project has been too complicated to port to latest ED, do you have a chance looking at ED Beta-18 yet? @nolanlawson OOT, since the npm maintainer has been changed, are you still working on this? I really keen to hear the update about the query feature, this is a simple thing but very crucial on my project :) ... I've been tried integrate the pouchdb-find to ember-pouch but I guess I did the wrong direction because pouchdb-find suppose to be integrate inside relational-pouch rather than directly inside ember-pouch. So any updates about this, will be really helpful ... and really thanks for your great work 👍 👍 👍 |
Yes, I have a bunch of changes in store for pouchdb-find that I hope to integrate into relational-pouch (one PouchDB plugin can depend on another; it's easy). pouchdb-find improvements will be part of my project for the summer. :) |
@nolanlawson Cool, can't wait ... Thanks in advance for your work :) ... 👍 👍 👍 |
Sorry, my bad for leaving this PR hanging for so long. The tests look fantastic, and I would love to see this re-worked into a new PR, but I do think the right approach is to use In any case, I'm gonna close for now, please rebase and reopen if you have a chance to work on it. |
@nolanlawson No problem, this was just a temp fix :) I agree that it should be done in another way. I had looked at the |
This is a temporary implementation to support the queries in ember-pouch