Support resources with no uid, and maybe with no name #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This goes slightly against K8s API specification, but the reality is that some resources, e.g. `v1/ComponentStatus`, do not have uids. Thos should not fail the operator. For such cases, use a fallback scenario, where a sufficiently unique pseudo-uid is generated from those parts of the resource, that do not change over time, and ensure its time-space uniqueness (i.e. if a resource is deleted and a new one is created with the same name, it should be a different pseudo-uid).
|
This pull request introduces 1 alert when merging 836ed51 into 87456ff - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes slightly against K8s API specification, but the reality is that some resources, e.g.
v1/ComponentStatus, do not have uids. Thos should not fail the operator.For such cases, use a fallback scenario, where a sufficiently unique pseudo-uid is generated from those parts of the resource, that do not change over time, and ensure its time-space uniqueness (i.e. if a resource is deleted and a new one is created with the same name, it should be a different pseudo-uid).