Reference objects only by name+namespace #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 67cedbe into d5b9ac3 - view on LGTM.com new alerts:
|
nolar
force-pushed
the
simplify-object-referencing
branch
from
67cedbe to
f71af50
Compare
Identifying the objects by partial identities or by its body is not used for long time. Let's get rid of this code, and always identify them explicitly by name & namespace, even if namespace is `None` (for cluster-scoped API calls).
nolar
force-pushed
the
simplify-object-referencing
branch
from
f71af50 to
f01b4e3
Compare
nolar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifying the objects by partial identities or by its body is not used for long time. Let's get rid of this code, and always identify them explicitly by name & namespace, even if namespace is
None(for cluster-scoped API calls).For stricter typing, the body's name property is made more strict — it now raises if the critical field (
.metadata.name) is absent while it is always expected on the objects for URLs. Objects with no name cannot be served.Partially reverts #596 — the name cannot be absent, as it is used for URLs. No name — no URLs — the resource cannot be served.