Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | Virtual hosts configuration support #8003

Merged
merged 1 commit into from
May 1, 2024

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented May 1, 2024

Explain the changes

  1. Endpoint.js - Replace the inline check of process.env.VIRTUAL_HOSTS to check config.VIRTUAL_HOSTS.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed NSFS | NC | add VIRTUAL_HOSTS to config (currently only in env) #7888

Testing Instructions:

  1. Types Schema tests - sudo jest --testRegex=jest_tests/test_nc_nsfs_config_schema
  2. Full Virtual manual tests -
  • add domain name mapping to 127.0.0.1
sudo vi /etc/hosts
example - 
....
127.0.0.1        my.virtual.host.io my.virtual.host.bucket1.io
  • start nsfs.js (NooBaa Non Containerized) -
sudo node src/cmd/nsfs.js --debug=5
  • Set NooBaa's virtual host in config.json -
sudo vi /etc/noobaa.conf.d/config.json
...
{
"VIRTUAL_HOSTS": "my.virtual.host.io"
}
  • Set S3 CLI configuration -
aws configure set default.s3.addressing_style virtual
alias s3='AWS_ACCESS_KEY_ID=<your_access_key> AWS_SECRET_ACCESS_KEY=<your_secret_key>  aws --endpoint https://my.virtual.host.io:6443 --no-verify-ssl s3'
  • Call list objects on bucket1 and expect a valid response -
s3 ls s3://buck1
  • Doc added/updated
  • Tests added

@romayalon romayalon requested a review from guymguym May 1, 2024 14:46
@romayalon romayalon force-pushed the romy-virtual-hosts branch from 56de282 to 0b3194e Compare May 1, 2024 15:37
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>

fix code review

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon force-pushed the romy-virtual-hosts branch from 0b3194e to f3b303a Compare May 1, 2024 15:59
@guymguym guymguym merged commit ff0007a into noobaa:master May 1, 2024
10 checks passed
@romayalon romayalon mentioned this pull request May 2, 2024
2 tasks
@guymguym guymguym added this to the 5.15.3 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSFS | NC | add VIRTUAL_HOSTS to config (currently only in env)
2 participants