NC | Backport to stage_5.15.3 #8004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t has rw_access to underlying path 1. Add a check if the owner of the bucket has rw_access to the underlying path when creating or updating a bucket. 2. Move the functionality of verify_bucket_owner to validate_bucket_args before we check the access of the underlying path (so we will have the account's details - to reduce fetching the config file again). 3. Add a new error: InaccessibleStoragePath. 4. Edit the existing tests to permit read and write access to the bucket owner. 5. Minor style changes and renaming in test_nc_nsfs_bucket_cli.test.js. Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit b558799)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit 6ce452b)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> NC - fix server ip whitelist validation Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit 167ed0d)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> fix code review Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit f3b303a)
romayalon
force-pushed
the
romy-backport-stage_5.15.3-encryption
branch
from
3184e54 to
05d6c49
Compare
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
nimrod-becker
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
NSFS | NC | Manage NSFS | Create bucket - Add Check If Bucket Owner Has
rw_accessto Underlying Path #7913NC | generate_entropy() - add dasd disks to the supported devices #7994
NC | Whitelist Server IP Fix #8002
NC | Virtual hosts configuration support #8003
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: