seconds unit dropped for :animation when pretty print turned off when magnitude is X.0

[thedavidmeister]

I tried this:

{:animation [[:my-keyframes (u/s 3.0) :infinite :ease-in-out]]}

Works with pretty print turned off, but when it is turned on, the s for 3.0s gets dropped.

Changing the magnitude from 3.0 to 3 or 3.5 works. Seems like anything that ends in .0 drops the s when compiled without pretty print.

[thedavidmeister]

:transition seems to have the same problem, so i don't think it has anything to do with the rule, just the way units are handled.

[noprompt]

@thedavidmeister Thanks for opening up all of these issues. It would really help if you gave me some steps to reproduce. I need more than a snippet. I need the exact code that failed and what you expected the result to be.

[RadicalZephyr]

Not sure if you still need more to reproduce this issue, but I just noticed it as well.

(defstyles screen
    [:.test
   {:thing "10.0s"
    :two "10s"}])

produced:

.test {
    thing: 10.0;
    two: 10s
}

where it should have been:

.test {
    thing: 10.0s;
    two: 10s
}

(note the additional "s" in the value of the thing property)

[rafd]

Seems to also be an issue with non-animations:

(garden/css {:pretty-print? false} [:body {:font-size "1.0em"}])

Gives:

body{font-size:1.0}

Which is not valid.

It seems this is a YUI compressor issue: yui/yuicompressor#322

My workaround has been to do: 1em

[opqdonut]

bumped into this same issue with px:

(g/css {:pretty-print? false} (list [:foo {:bar (u/px 1200.0)}]))

generates

foo{bar:1200.0}

[noprompt]

YUI has been a continual source of pain and suffering. I think we should just cut it loose and continue without it. For 1.X.X releases we can continue with the simple compression provided with the goal of just getting Garden out of the compression business long-term.

Currently, I have a time obligation to Meander for the next couple months and, honestly, I'm not going to be able to devote any time to Garden until after Q3.

I would really appreciate someone taking the wheel on this one and eliminating YUI from the project.

[pavel-klavik]

This bug is very annoying because it is not something one suspects. While the long term solution of cutting YUI can be great, it would be great to add a quick hack which would fix it. It should be enought to add a check when converting maps describing units into strings whether the value is a float which is actually an integer, and if so, to automatically convert it into int. Something like this:

(if (and (float? value) (== value (int value))
  (int value)
  value)

[noprompt]

@pavel-klavik Are you able to submit a patch for this? If your proposal works to solve the issue, I'm happy to merge it.

[pavel-klavik]

This should work, tested in REPL. I am not sure how to actually build Garden for development, so it would be great if someone can test it fully or maybe adding automatic tests??