0 percentage keyframe keywords lose the % symbol when pretty print turned off #120
Labels
Milestone
Comments
|
Wait, no, I was wrong. Strings do not help, the |
|
@thedavidmeister Is that with or without minification? This seems eerily familiar to #116 that had a similar problem. |
noprompt
added a commit
that referenced
this issue
Nov 29, 2016
This patch rethinks the architecture of Garden in terms of well defined boundaries between parsing and compiling. Instead of directly compiling objects into CSS, Garden will first parse the objects into a CSS AST which can then be consumed by the compiler. This architecture is closer to what one might expect to find in a programming language implementation setting. This new architecture yields greater flexibility to introduce new features and semantics while vastly simplifying the work of the compiler. As a result many requested features and solutions to bugs have now been either implemented, solved, or are now trivial to implement or solve. Changelog updates forthcoming. Closes #31 Closes #109 Closes #115 Closes #116 Closes #119 Closes #120 Closes #121
|
Is using |
|
I noticed a similar bug with colors. (css {:pretty-print? false} [:.example {:color (saturate "#ccc" -10)}])This produces the following output, about which Chrome gives the error "Invalid property value". .example{color:hsla(0,0,80%,1.0)}The correct result would be: .example{color:hsla(0,0%,80%,1.0)} |
|
I'd really appreciate any help resolving this issue. I'm really busy with work, family, and other things at the moment and it's hard for me to make time to solve this problem on master. |
luontola
added a commit
to luontola/garden
that referenced
this issue
Feb 25, 2019
luontola
added a commit
to luontola/garden
that referenced
this issue
Feb 25, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried:
[:0% :50% :100% {:transform "scale(0.0)"}]Worked as expected with pretty print turned on.
With pretty print turned off, the
%from0%was dropped, which caused the whole keyframe rule to do nothing.Using strings like
"0%"instead of keywords like:0%seemed to workaround the issue.The text was updated successfully, but these errors were encountered: