Fix "0%" being replaced with "0" when pretty-printing is disabled #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test assertions used to show the intermediate garden.color.CSSColor value instead of the actual string value that was being compared.
|
This PR has been released as an unofficial build: |
|
Apologies for the delay on merging this. Thanks for fixing the bug. I'm not sure why the test suite needed to be changed in the manner it was but it's not important. |
|
@luontola I'm going to add you to the list of folks who can contribute directly to the project. In the future, try directly contacting me in Slack if I do not respond in a timely manner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Fixes #116
The root cause was in the YUI Compressor and required a dirty hack to prevent it from changing "0%" to "0". In the long run it might be preferable to switch to a CSS compressor which is still maintained. YUI Compressor's latest release is from 2013.