This repository has been archived by the owner on Oct 1, 2018. It is now read-only.
Refactored plugin hooks for newer XCode cli builds and codova >7 #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the plugin hooks to be compatible with pre cordova 7 and post cordova 7. Also made sure the new entitlements style of XCode is respected, so building from command line works.
This PR solves:
I did some tests on Android and iOS and all seems to work. I did not test any path specific links, but they should work also.
My
config.xml
looks like this:On the domain
https://myapp.mydomain.org
I have a fileapple-app-site-association
, filled as follows:Also I have a
build.json
that covers my builds, like:Now when I build from the command line all works like a charm.