Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoLand 2019.2 display wrong color for go code #69

Closed
smonv opened this issue Jul 31, 2019 · 15 comments · Fixed by #70 or #121
Closed

GoLand 2019.2 display wrong color for go code #69

smonv opened this issue Jul 31, 2019 · 15 comments · Fixed by #70 or #121

Comments

@smonv
Copy link

smonv commented Jul 31, 2019

I tried Nord plugin with GoLand 2019.2 but couldn't get north-bluish color like image demo at README.md

I felt like the color still come from Dracula instead of Nort

Screen Shot 2019-07-31 at 16 09 42

Screen Shot 2019-07-31 at 16 12 27

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jul 31, 2019

Hi @smonv 👋, thanks for your contribution 👍

I've also upgraded to 2019.2 some minutes ago and can confirm that the update broke the highlighting. I've also noticed some component using the default Darcula styles like tabs and the auto completion popup after updating to 2019.1.3. Seems like they changed the theme UI and editor color scheme API without really notifying theme authors or at least documenting the changes including an announcement as blog post or via Twitter 😞

I've marked the issue with high priority and taking a look into it right now. Requires me to set up a fresh container installation to debug the changes that are automatically applied by the IDE to the underlying theme files as soon as 2019.2 starts so hopefully I can track down the root cause.

@arcticicestudio arcticicestudio self-assigned this Jul 31, 2019
@smonv
Copy link
Author

smonv commented Jul 31, 2019 via email

@arcticicestudio
Copy link
Contributor

One cause might be the new introduction of support for 20+ new languages through the integration of TextMate. I currently scrawl through all the EAP builds of 2019.1 and 2019.2 to find a ticket that might contain more information about the changes.

@arcticicestudio
Copy link
Contributor

Alright, first results: found YouTrack issue IDEA-201007 that resulted in the implementation of more detailed linting output, e.g. showing deprecated theme API keys 🎉
At least this explains the "corrupted" styles of some IDE UI elements like tabs and the auto-completion popup and some more: The theme keys are deprecated and have been replaced with new ones resulting in a fallback value of the parent scheme darcula.

gh-69-research-youtrack-idea-201007-schema-deprecation-linting

I guess for the Go syntax highlighting there are also new keys or they changed the behaviour of not inheriting the global value by default so there are now many GO_ editor color scheme keys missing.

arcticicestudio added a commit that referenced this issue Jul 31, 2019
IntelliJ/Goland version 2019.2 introduced support for 20+ languages (1)
out-of-the-box by integrating TextMate schemes (2).
Unfortunately this resulted in a change for existing theme definition
where some editor color scheme keys that previously inherited the best
matching global key now used the attributes defined by the parent theme
_Darcula_. Therefore Nord's highlighting for Go broke and required to
explicitly define the values for some attributes in order to achieve
the same highlight like in previous versions that are matching Nord's
style guidelines.

References:
  (1) https://www.jetbrains.com/idea/whatsnew/#v2019-2-editor
  (2) https://macromates.com

GH-69
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jul 31, 2019

@smonv I've implemented the missing color scheme keys for Go in #70, seems like they changed the default inheritance behavior of some syntax definitions so some of the keys simply used the values from the parent Darcula theme.
I'll merge it tomorrow along with some other important changes that are required to provide full support for all 2019.2 IDE versions, e.g. adding the new UI theme keys that replaced some deprecated ones.

@smonv
Copy link
Author

smonv commented Aug 1, 2019

Thanks for detailed explanation and the fixes. Hope you can fixes UI key change and release soon

@smonv
Copy link
Author

smonv commented Aug 1, 2019

I just tried Nord 0.7.0 with Clion 2019.2 and seem like it display color correctly with UI auto-complete and rust code.

Screen Shot 2019-08-01 at 09 11 16

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Aug 1, 2019

Java works fine too using IntelliJ 2019.2, so it looks like only some languages are affected. Going to check all bundled Community & Ultimate Edition languages as well as some popular other language plugins, maybe it requires more PRs for the next version to be sure it works for 2019.2.

arcticicestudio added a commit that referenced this issue Aug 1, 2019
IntelliJ/Goland version 2019.2 introduced support for 20+ languages (1)
out-of-the-box by integrating TextMate schemes (2).
Unfortunately this resulted in a change for existing theme definition
where some editor color scheme keys that previously inherited the best
matching global key now used the attributes defined by the parent theme
_Darcula_. Therefore Nord's highlighting for Go broke and required to
explicitly define the values for some attributes in order to achieve
the same highlight like in previous versions that are matching Nord's
style guidelines.

References:
  (1) https://www.jetbrains.com/idea/whatsnew/#v2019-2-editor
  (2) https://macromates.com

Resolves GH-69
@arcticicestudio arcticicestudio removed their assignment Aug 1, 2019
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Aug 2, 2019

@smonv Version 0.8.0 has been released including #70, but not published to the JetBrains plugin registry yet since I'd like to get some test feedback if it works fine for other IDEs except IntelliJ. Could you please download the plugin JAR file from the release notes, uninstall the Nord plugin from the marketplace and install the plugin locally from disk to test if everything works fine now?

@smonv
Copy link
Author

smonv commented Aug 2, 2019

@arcticicestudio Thank for the quick fix.

Screen Shot 2019-08-02 at 16 08 29

Screen Shot 2019-08-02 at 16 09 17

I just tried with GoLand 2019.2 and seem like color displayed correctly.

@arcticicestudio
Copy link
Contributor

@smonv Great, I've deployed v0.8.0 to the marketplace some hours ago and it was already passed JetBrains validation process so you can uninstall the manually installed plugin again and use the normal installation process through the marketplace. Thanks again for testing 💪

@smonv
Copy link
Author

smonv commented Aug 2, 2019 via email

@arcticicestudio
Copy link
Contributor

You're welcome, it's one of the largest port projects and also my daily driver to develop Go/Rust/React/Java so it bothered me too 😄

@smonv
Copy link
Author

smonv commented Aug 4, 2019

@arcticicestudio Sorry for bother you on weekend but after update to Nord 0.8.0, my auto-complete not showing anything until I manually click to it box or press arrow up. I'm not sure this problem because of my code, my IDE setting or colorscheme. I never got any problem like this before.

Screen Shot 2019-08-04 at 10 27 11

@arcticicestudio
Copy link
Contributor

@smonv This has already been reported in #88 and fixed in #89. The patch version 0.8.1 has also already been released and deployed to the JetBrains marketplace, but it'll take some time until is passes JetBrains validation process because I guess they won't work on saturdays/sundays for this 😄

svengreb pushed a commit that referenced this issue Dec 2, 2019
Like already documented and fixed in GH-70, IntelliJ/Goland version
2019.3 also includes changes in Go's syntax highlight for the default
bundled color schemes [1].

Unfortunately this resulted again in a change for existing theme
definition where some editor color scheme keys that previously inherited
the best matching global key now used the attributes defined by the
parent theme Darcula. Therefore Nord's highlighting for Go broke again
and required to explicitly define the values for some attributes in
order to achieve the same highlight like in previous versions that are
matching Nord's style guidelines.

[1]: https://www.jetbrains.com/go/whatsnew/#v2019-3-code-editing

Related to GH-69, GH-70
GH-108
arcticicestudio added a commit that referenced this issue Dec 16, 2019
Like already documented and fixed in GH-70, IntelliJ/Goland version
2019.3 also includes changes in Go's syntax highlight for the default
bundled color schemes [1].

Unfortunately this resulted again in a change for existing theme
definition where some editor color scheme keys that previously inherited
the best matching global key now used the attributes defined by the
parent theme Darcula. Therefore Nord's highlighting for Go broke again
and required to explicitly define the values for some attributes in
order to achieve the same highlight like in previous versions that are
matching Nord's style guidelines.

[1]: https://www.jetbrains.com/go/whatsnew/#v2019-3-code-editing

Related to GH-69, GH-70
GH-108
svengreb pushed a commit that referenced this issue Dec 16, 2019
Like already documented and fixed in GH-70, IntelliJ/Goland version
2019.3 also includes changes in Go's syntax highlight for the default
bundled color schemes [1].

Unfortunately this resulted again in a change for existing theme
definition where some editor color scheme keys that previously inherited
the best matching global key now used the attributes defined by the
parent theme Darcula. Therefore Nord's highlighting for Go broke again
and required to explicitly define the values for some attributes in
order to achieve the same highlight like in previous versions that are
matching Nord's style guidelines.

[1]: https://www.jetbrains.com/go/whatsnew/#v2019-3-code-editing

Related to GH-69, GH-70
GH-108
svengreb pushed a commit that referenced this issue Feb 14, 2020
This commit implements a change for the meta-issue GH-120 that collects
and aggregates all information regarding the problems related to
"randomly breaking syntax highlighting".
There is an continuously increasing amount of issues related this bug
were the root cause is still a mystery.

The following timeline shows the problem based on reported issues in
this repository.

>>> 2019-07-31 - First breakages of Go & JavaScript syntax since IDE
                 versions 2019.2.x

The first cases are documented in GH-69 & GH-77 where the syntax
highlighting of some Go & JavaScript elements were wrong after updating
to IntelliJ version 2019.2.0, the update that introduced support for 20+
languages [1] out-of-the-box by integrating TextMate [2] schemes.

It resulted in a change for some Go & JavaScript editor color scheme
keys that previously inherited the best matching global keys, but used
the attributes defined by the parent theme "Darcula" after the update
instead. Therefore Nord's highlighting for Go & JavaScript broke and
required to explicitly define the values for the some attributes
(merged in GH-70 & GH-78) in order to achieve the same highlight like in
previous versions:

A comparison of the changes between Nord plugin version 0.6.0 and 0.7.0
[3] shows that there were absolutely no changes to the editor color
scheme related to the highlighting of Go & JavaScript code.
To this time the guess was that the root cause was the integration of
"TextMate" themes and the "fixes" have been released in version 0.8.0
[4].

>>> 2019-12-02 - Second breakage of Go syntax since IDE versions
                 2019.3.x

The second case is documented in GH-108 where the syntax highlighting of
some Go elements were wrong again after updating to IntelliJ version
2019.3.0. A comparison of the changes between Nord plugin version 0.8.0
and the time the issue was created (2019-12-02) [5] shows again that
there were no changes to the editor color scheme related to the
highlighting of Go code.

An interesting observation was that the wrong highlighting could be
fixed by disabling and enabling the Nord plugin again without restarting
the IDE (deny/postpone to later when the question dialog shows up).

Again, the "fixes" were then released in a the new plugin version
version 0.9.0 [6].

>>> 2020-01-28 - Another breakage of JavaScript & TypeScript syntax in
                 IDE versions 2019.3.x

On 2020-01-28 a new issue has been created that describes the breakage
of the syntax highlighting for JavaScript as well as TypeScript (which
inherits values from the JavaScript editor scheme keys) in GH-115.
This is really strange since the affected elements were fixed in GH-78
[7] to mitigate the first breakage!
To fix the problem again, the color definitions were then defined
explicitly in GH-116 [8] instead of relying on the non-working
inheritance of other theme keys.

The comparison of the changes between Nord plugin version 0.9.0 and the
time the issue was created (2020-01-28) [9] again showing that there
were no changes to the highlighting of JavaScript or TypeScript syntax
elements in the editor color scheme.

It was also possible again to temporarily work around the problem by
re-enabling or even re-installing the plugin. This definitely shows that
the root cause must be somewhere in the way the IDE loads themes and how
editor color scheme keys are inherited from other keys.

Again, the "fixes" were then released in a the new plugin
version 0.10.0 [10] on 2020-02-11.

>>> 2020-02-11 - Now PHP and general "markup" languages are also
                 broken...

The latest case occurred only several hours after [Nord plugin version
0.10.0 [10] was deployed and made public through the "JetBrains Plugin
Marketplace". This time the highlighting of strings and comments in PHP,
Markdown font styles (bold & italic) as well as other elements of
"markup" languages are broken.

Again, a comparison of the changes between Nord plugin version 0.9.0 and
0.10.0 [11] shows that there no changes to the highlighting for editor
color scheme keys for PHP, Markdown or any "markup" languages or
"Language Default" styles.

During the testing of Nord plugin version 0.10.0, that was released to
fix the problems of the broken JavaScript & TypeScript highlighting,
there were no problems regarding "markup" styles and all elements were
working fine in Markdown files.
Right after deploying the plugin to the "JetBrains Plugin Marketplace",
the highlighting suddenly broke "out of nowhere" after updating the
plugin for my IntelliJ.

>> Conclusion

These random breakages "drive me nuts" and it's frustrating as a theme
author to no being able to track down the root cause. Since the problem
occurs randomly, but can also be temporarily mitigated through one or
more plugin re-activation or re-installations, the problem origin must
be a bug in the IDE itself.

>> Mitigation Steps

This commit implements a workaround to prevent more styles from
breaking. It replaces all editor color scheme keys that inherit values
from other keys with the explicit style definitions instead.
This causes the code of the editor scheme to increase drastically due to
duplicate and repeated styles, but it currently the only way to work
around this non-working style inheritance in the IDE theme API.

[1]: https://www.jetbrains.com/idea/whatsnew/#v2019-2-editor
[2]: https://macromates.com
[3]: https://github.com/arcticicestudio/nord-jetbrains/compare/master@%7B2019-05-23%7D...master@%7B2019-07-16%7D
[4]: https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.8.0
[5]: https://github.com/arcticicestudio/nord-jetbrains/compare/v0.8.0...develop@%7B2019-12-02%7D
[6]: https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.9.0
[7]: https://github.com/arcticicestudio/nord-jetbrains/pull/78/files#diff-1146aace8d65c51b72c60139418ad4d0R1016-R1018
[8]: https://github.com/arcticicestudio/nord-jetbrains/pull/116/files#diff-1146aace8d65c51b72c60139418ad4d0R1118-R1133
[9]: https://github.com/arcticicestudio/nord-jetbrains/compare/v0.9.0...develop@%7B2020-01-28%7D
[10]: https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.10.0
[11]: v0.9.0...v0.10.0

Related to GH-69, GH-70, GH-77, GH-78, GH-108, GH-109, GH-115, GH-117,
           GH-119
GH-120
arcticicestudio added a commit that referenced this issue Feb 15, 2020
This commit implements a change for the meta-issue GH-120 that collects
and aggregates all information regarding the problems related to
"randomly breaking syntax highlighting".
There is an continuously increasing amount of issues related this bug
were the root cause is still a mystery.

The following timeline shows the problem based on reported issues in
this repository.

>>> 2019-07-31 - First breakages of Go & JavaScript syntax since IDE
                 versions 2019.2.x

The first cases are documented in GH-69 & GH-77 where the syntax
highlighting of some Go & JavaScript elements were wrong after updating
to IntelliJ version 2019.2.0, the update that introduced support for 20+
languages [1] out-of-the-box by integrating TextMate [2] schemes.

It resulted in a change for some Go & JavaScript editor color scheme
keys that previously inherited the best matching global keys, but used
the attributes defined by the parent theme "Darcula" after the update
instead. Therefore Nord's highlighting for Go & JavaScript broke and
required to explicitly define the values for the some attributes
(merged in GH-70 & GH-78) in order to achieve the same highlight like in
previous versions:

A comparison of the changes between Nord plugin version 0.6.0 and 0.7.0
[3] shows that there were absolutely no changes to the editor color
scheme related to the highlighting of Go & JavaScript code.
To this time the guess was that the root cause was the integration of
"TextMate" themes and the "fixes" have been released in version 0.8.0
[4].

>>> 2019-12-02 - Second breakage of Go syntax since IDE versions
                 2019.3.x

The second case is documented in GH-108 where the syntax highlighting of
some Go elements were wrong again after updating to IntelliJ version
2019.3.0. A comparison of the changes between Nord plugin version 0.8.0
and the time the issue was created (2019-12-02) [5] shows again that
there were no changes to the editor color scheme related to the
highlighting of Go code.

An interesting observation was that the wrong highlighting could be
fixed by disabling and enabling the Nord plugin again without restarting
the IDE (deny/postpone to later when the question dialog shows up).

Again, the "fixes" were then released in a the new plugin version
version 0.9.0 [6].

>>> 2020-01-28 - Another breakage of JavaScript & TypeScript syntax in
                 IDE versions 2019.3.x

On 2020-01-28 a new issue has been created that describes the breakage
of the syntax highlighting for JavaScript as well as TypeScript (which
inherits values from the JavaScript editor scheme keys) in GH-115.
This is really strange since the affected elements were fixed in GH-78
[7] to mitigate the first breakage!
To fix the problem again, the color definitions were then defined
explicitly in GH-116 [8] instead of relying on the non-working
inheritance of other theme keys.

The comparison of the changes between Nord plugin version 0.9.0 and the
time the issue was created (2020-01-28) [9] again showing that there
were no changes to the highlighting of JavaScript or TypeScript syntax
elements in the editor color scheme.

It was also possible again to temporarily work around the problem by
re-enabling or even re-installing the plugin. This definitely shows that
the root cause must be somewhere in the way the IDE loads themes and how
editor color scheme keys are inherited from other keys.

Again, the "fixes" were then released in a the new plugin
version 0.10.0 [10] on 2020-02-11.

>>> 2020-02-11 - Now PHP and general "markup" languages are also
                 broken...

The latest case occurred only several hours after [Nord plugin version
0.10.0 [10] was deployed and made public through the "JetBrains Plugin
Marketplace". This time the highlighting of strings and comments in PHP,
Markdown font styles (bold & italic) as well as other elements of
"markup" languages are broken.

Again, a comparison of the changes between Nord plugin version 0.9.0 and
0.10.0 [11] shows that there no changes to the highlighting for editor
color scheme keys for PHP, Markdown or any "markup" languages or
"Language Default" styles.

During the testing of Nord plugin version 0.10.0, that was released to
fix the problems of the broken JavaScript & TypeScript highlighting,
there were no problems regarding "markup" styles and all elements were
working fine in Markdown files.
Right after deploying the plugin to the "JetBrains Plugin Marketplace",
the highlighting suddenly broke "out of nowhere" after updating the
plugin for my IntelliJ.

>> Conclusion

These random breakages "drive me nuts" and it's frustrating as a theme
author to no being able to track down the root cause. Since the problem
occurs randomly, but can also be temporarily mitigated through one or
more plugin re-activation or re-installations, the problem origin must
be a bug in the IDE itself.

>> Mitigation Steps

This commit implements a workaround to prevent more styles from
breaking. It replaces all editor color scheme keys that inherit values
from other keys with the explicit style definitions instead.
This causes the code of the editor scheme to increase drastically due to
duplicate and repeated styles, but it currently the only way to work
around this non-working style inheritance in the IDE theme API.

[1]: https://www.jetbrains.com/idea/whatsnew/#v2019-2-editor
[2]: https://macromates.com
[3]: https://github.com/arcticicestudio/nord-jetbrains/compare/master@%7B2019-05-23%7D...master@%7B2019-07-16%7D
[4]: https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.8.0
[5]: https://github.com/arcticicestudio/nord-jetbrains/compare/v0.8.0...develop@%7B2019-12-02%7D
[6]: https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.9.0
[7]: https://github.com/arcticicestudio/nord-jetbrains/pull/78/files#diff-1146aace8d65c51b72c60139418ad4d0R1016-R1018
[8]: https://github.com/arcticicestudio/nord-jetbrains/pull/116/files#diff-1146aace8d65c51b72c60139418ad4d0R1118-R1133
[9]: https://github.com/arcticicestudio/nord-jetbrains/compare/v0.9.0...develop@%7B2020-01-28%7D
[10]: https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.10.0
[11]: v0.9.0...v0.10.0

Related to GH-69, GH-70, GH-77, GH-78, GH-108, GH-109, GH-115, GH-117,
           GH-119
GH-120
arcticicestudio added a commit that referenced this issue Feb 15, 2020
This commit implements a change for the meta-issue GH-120 that collects
and aggregates all information regarding the problems related to
"randomly breaking syntax highlighting".
There is an continuously increasing amount of issues related this bug
were the root cause is still a mystery.

The following timeline shows the problem based on reported issues in
this repository.

>>> 2019-07-31 - First breakages of Go & JavaScript syntax since IDE
                 versions 2019.2.x

The first cases are documented in GH-69 & GH-77 where the syntax
highlighting of some Go & JavaScript elements were wrong after updating
to IntelliJ version 2019.2.0, the update that introduced support for 20+
languages [1] out-of-the-box by integrating TextMate [2] schemes.

It resulted in a change for some Go & JavaScript editor color scheme
keys that previously inherited the best matching global keys, but used
the attributes defined by the parent theme "Darcula" after the update
instead. Therefore Nord's highlighting for Go & JavaScript broke and
required to explicitly define the values for the some attributes
(merged in GH-70 & GH-78) in order to achieve the same highlight like in
previous versions:

A comparison of the changes between Nord plugin version 0.6.0 and 0.7.0
[3] shows that there were absolutely no changes to the editor color
scheme related to the highlighting of Go & JavaScript code.
To this time the guess was that the root cause was the integration of
"TextMate" themes and the "fixes" have been released in version 0.8.0
[4].

>>> 2019-12-02 - Second breakage of Go syntax since IDE versions
                 2019.3.x

The second case is documented in GH-108 where the syntax highlighting of
some Go elements were wrong again after updating to IntelliJ version
2019.3.0. A comparison of the changes between Nord plugin version 0.8.0
and the time the issue was created (2019-12-02) [5] shows again that
there were no changes to the editor color scheme related to the
highlighting of Go code.

An interesting observation was that the wrong highlighting could be
fixed by disabling and enabling the Nord plugin again without restarting
the IDE (deny/postpone to later when the question dialog shows up).

Again, the "fixes" were then released in a the new plugin version
version 0.9.0 [6].

>>> 2020-01-28 - Another breakage of JavaScript & TypeScript syntax in
                 IDE versions 2019.3.x

On 2020-01-28 a new issue has been created that describes the breakage
of the syntax highlighting for JavaScript as well as TypeScript (which
inherits values from the JavaScript editor scheme keys) in GH-115.
This is really strange since the affected elements were fixed in GH-78
[7] to mitigate the first breakage!
To fix the problem again, the color definitions were then defined
explicitly in GH-116 [8] instead of relying on the non-working
inheritance of other theme keys.

The comparison of the changes between Nord plugin version 0.9.0 and the
time the issue was created (2020-01-28) [9] again showing that there
were no changes to the highlighting of JavaScript or TypeScript syntax
elements in the editor color scheme.

It was also possible again to temporarily work around the problem by
re-enabling or even re-installing the plugin. This definitely shows that
the root cause must be somewhere in the way the IDE loads themes and how
editor color scheme keys are inherited from other keys.

Again, the "fixes" were then released in a the new plugin
version 0.10.0 [10] on 2020-02-11.

>>> 2020-02-11 - Now PHP and general "markup" languages are also
                 broken...

The latest case occurred only several hours after [Nord plugin version
0.10.0 [10] was deployed and made public through the "JetBrains Plugin
Marketplace". This time the highlighting of strings and comments in PHP,
Markdown font styles (bold & italic) as well as other elements of
"markup" languages are broken.

Again, a comparison of the changes between Nord plugin version 0.9.0 and
0.10.0 [11] shows that there no changes to the highlighting for editor
color scheme keys for PHP, Markdown or any "markup" languages or
"Language Default" styles.

During the testing of Nord plugin version 0.10.0, that was released to
fix the problems of the broken JavaScript & TypeScript highlighting,
there were no problems regarding "markup" styles and all elements were
working fine in Markdown files.
Right after deploying the plugin to the "JetBrains Plugin Marketplace",
the highlighting suddenly broke "out of nowhere" after updating the
plugin for my IntelliJ.

>> Conclusion

These random breakages "drive me nuts" and it's frustrating as a theme
author to no being able to track down the root cause. Since the problem
occurs randomly, but can also be temporarily mitigated through one or
more plugin re-activation or re-installations, the problem origin must
be a bug in the IDE itself.

>> Mitigation Steps

This commit implements a workaround to prevent more styles from
breaking. It replaces all editor color scheme keys that inherit values
from other keys with the explicit style definitions instead.
This causes the code of the editor scheme to increase drastically due to
duplicate and repeated styles, but it currently the only way to work
around this non-working style inheritance in the IDE theme API.

[1]: https://www.jetbrains.com/idea/whatsnew/#v2019-2-editor
[2]: https://macromates.com
[3]: https://github.com/arcticicestudio/nord-jetbrains/compare/master@%7B2019-05-23%7D...master@%7B2019-07-16%7D
[4]: https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.8.0
[5]: https://github.com/arcticicestudio/nord-jetbrains/compare/v0.8.0...develop@%7B2019-12-02%7D
[6]: https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.9.0
[7]: https://github.com/arcticicestudio/nord-jetbrains/pull/78/files#diff-1146aace8d65c51b72c60139418ad4d0R1016-R1018
[8]: https://github.com/arcticicestudio/nord-jetbrains/pull/116/files#diff-1146aace8d65c51b72c60139418ad4d0R1118-R1133
[9]: https://github.com/arcticicestudio/nord-jetbrains/compare/v0.9.0...develop@%7B2020-01-28%7D
[10]: https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.10.0
[11]: v0.9.0...v0.10.0

Related to GH-69, GH-70, GH-77, GH-78, GH-108, GH-109, GH-115, GH-117,
           GH-119
GH-120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment