Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code completion text is not visible until keyboard interaction #88

Closed
alekc opened this issue Aug 2, 2019 · 9 comments · Fixed by #89
Closed

Code completion text is not visible until keyboard interaction #88

alekc opened this issue Aug 2, 2019 · 9 comments · Fixed by #89
Labels
context-ui priority-high scope-compatibility scope-ux status-accepted status-pending type-bug
Milestone
0.8.1

Comments

@alekc
Copy link

alekc commented Aug 2, 2019

There is a weird bug triggered on intellisense on
GoLand 2019.2
Build #GO-192.5728.103, built on July 23, 2019

Basically code competition window (which appears while you are writing code), is ileggible until you press some key (i.e. move with arrows up or down). Issues is not triggered if I press ctrl space and call for intellisense in explicit manner.
@arcticicestudio
Copy link
Contributor

Hi @alekc 👋 , thanks for your report 👍

  1. Please post the name and version of your operating system.
  2. Is the problem reproducible with other (official) themes like Darcula or IntelliJ (Default)?
    If yes this bug should be reported to YouTrack.
    I've quickly checked the latest reports, but only found a problem regarding text that gets cut off in the popup for the Rider IDE and multiple performance problems (that are marked as critical/„show stopper“) regarding high CPU usage for IntelliSense.
  3. What's the version of the Nord plugin you're using? If it's not the latest version v0.8.0 please update since this version includes explicit support for the latest JetBrains 2019.2 products.
  4. If you're using the latest Nord plugin version could and the problem still exists, could you please try to delete the colors directory in Goland's configuration directory? The folder only might contain a copy of the Nord theme when you've ever modified any part of the UI/editor color scheme so this might conflict with the plugin leading to compatibility problems.

@arcticicestudio arcticicestudio added this to the Next milestone Aug 3, 2019
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Aug 3, 2019 •
edited
Loading

I've been able to reproduce the problem using IntelliJ and GoLand. All items are "invisible" until the up or down arrow button has been pressed to navigate through the list. I'll need to check if any UI theme key is the root cause or theme API v2019.2 introduced any new key the theme currently misses. Otherwise I'll create a report in JetBrains bug tracker so this can be analysed as soon as possible.

gh-88-nord

@arcticicestudio
Copy link
Contributor

Also I currently don't know if this is related to the problem or the already known performance problems mentioned in the YouTrack tickets linked above, but the whole IDE seems to be way slower than any version of 2019.1. Maybe the list in the popup is not loaded correctly due to internal errors.

@arcticicestudio
Copy link
Contributor

The official bundled themes are working fine, so the problem is definitely scoped to Nord only.

Darcula

IntelliJ/Light (Default)

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Aug 3, 2019 •
edited
Loading

It looks like the JetBrains 2019.2 products are currently all affected by performance problems. My IntelliJ Ultimate Edition 2019.2 closed for the first time ever with an "out of memory" error some moments ago (16GB RAM, IntelliJ is allowed to use ~6GB of it). It completely polluted my system with log and dump files taking more than 12GB. It's not possible to debug the theme at the moment.

I'll try some known workarounds as well as switching the boot JRE of IntelliJ to a JetBrains specific JRE:

-XX:TieredStopAtLevel=1
-XX:CICompilerCount=2
-XX:Tier4MinInvocationThreshold=100000
-XX:Tier4InvocationThreshold=110000
-XX:Tier4CompileThreshold=120000

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Aug 3, 2019 •
edited
Loading

I've identified the root cause 🎉
In v0.8.0 some new UI theme keys have been added and deprecated ones modified or removed through #86 and PR #87. This includes the ui.CompletionPopup.nonFocusedMask key that has been set to nord0 without a alpha layer value. Since the auto completion popup of IntelliSense is not focused but the editor itself, the overlay mask gets applied. As soon as the up or down arrow keys are pressed the popup gets the focus and therefore the mask gets removed showing the list items with correct styles.

The key will be removed, the popup should be shown the same like in focused state for better readable text and easy recognition of the desired auto complete entry. The fix will be released as new bugfix plugin version 0.8.1.

arcticicestudio added a commit that referenced this issue Aug 3, 2019
@arcticicestudio
Fix unreadable completion popup list items in non-focused state
1ee3f17 
In version 0.8.0 (1) some new UI theme keys have been added and
deprecated ones modified or removed through GH-86 and PR GH-87.
This included the `ui.CompletionPopup.nonFocusedMask` key that has been
set to `nord0` without a alpha layer value. Since the auto completion
popup of IntelliSense if not focused but the editor itself, the overlay
mask gets applied. As soon as the up or down arrow keys are pressed the
popup gets the focus and therefore the mask gets removed showing the
list items with correct styles.

The key has been removed, the popup should be shown the same like in
focused state for better readable text and easy recognition of the
desired auto complete entry.

References:
  (1) https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.8.0

GH-88
@arcticicestudio arcticicestudio mentioned this issue Aug 3, 2019
Merged
arcticicestudio added a commit that referenced this issue Aug 3, 2019
@arcticicestudio
Fix unreadable completion popup list items in non-focused state (#89)
a88dc78 
In version 0.8.0 (1) some new UI theme keys have been added and
deprecated ones modified or removed through GH-86 and PR GH-87.
This included the `ui.CompletionPopup.nonFocusedMask` key that has been
set to `nord0` without a alpha layer value. Since the auto completion
popup of IntelliSense if not focused but the editor itself, the overlay
mask gets applied. As soon as the up or down arrow keys are pressed the
popup gets the focus and therefore the mask gets removed showing the
list items with correct styles.

The key has been removed, the popup should be shown the same like in
focused state for better readable text and easy recognition of the
desired auto complete entry.

References:
  (1) https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.8.0

Fixes GH-88
@arcticicestudio
Copy link
Contributor

The fix has been merged in #89 and release version 0.8.1 published and deployed to the JetBrains marketplace. As soon as the new plugin version passes the JetBrains validation process the update will be available through the IDE plugin auto-update.

@wzhudev
Copy link

wzhudev commented Aug 3, 2019

Great! I came across this problem today and it got fixed so quick!

@smonv smonv mentioned this issue Aug 4, 2019
Closed
@arcticicestudio arcticicestudio mentioned this issue Aug 4, 2019
Closed
@dallbee
Copy link

dallbee commented Aug 4, 2019

Just noticed this today, thanks for fixing it so fast!

@wezleytsai wezleytsai mentioned this issue Aug 6, 2019
Closed
@arcticicestudio arcticicestudio changed the title Code competition window background Code completion text is not visible until keyboard interaction Aug 7, 2019
This was referenced Aug 7, 2019
Closed
Closed
@alekc alekc mentioned this issue Aug 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-ui priority-high scope-compatibility scope-ux status-accepted status-pending type-bug
Projects
None yet
Milestone
0.8.1
Development

Successfully merging a pull request may close this issue.

Fix unreadable completion popup list items in non-focused state nordtheme/jetbrains
4 participants
@alekc @dallbee @arcticicestudio @wzhudev