Selection background in code competition #95
Labels
Milestone
Comments
svengreb
pushed a commit
that referenced
this issue
Feb 11, 2020
Before this commit, the background color of the marked entry in the completion popup when triggered while typing (enabled "Show suggestions as you type" option in preferences) [1] was the same like the background of the popup itself. As a result, the user did not know which entry was selected to complete the current line. The problem only occured when the completion popup was triggered while typing but not when being explicitly invoked using the configured keymapping [2] (`Ctrl` / `⌃` + `Space` by default). This was because when the popup is invoked while typing, the matching entry in the list is "inactive", but the color for inative entries was the same like the background color of the popup itself. This problem is now fixed by changing the color of the co#rresponding UI theme key `ui.CompletionPopup.selectionInactiveBackground` from `nord1` to `nord3`. [1]: https://www.jetbrains.com/help/idea/auto-completing-code.html#configure-code-completion [2]: https://www.jetbrains.com/help/idea/auto-completing-code.html#invoke-basic-completion Related to GH-94 GH-95
|
Related to #94 Hi @alekc 👋, thanks for your contribution 👍 I've found the root cause and submitted #118 to fix it. It'll be included in the next release version 0.10.0. |
arcticicestudio
added a commit
that referenced
this issue
Feb 11, 2020
Before this commit, the background color of the marked entry in the completion popup when triggered while typing (enabled "Show suggestions as you type" option in preferences) [1] was the same like the background of the popup itself. As a result, the user did not know which entry was selected to complete the current line. The problem only occurred when the completion popup was triggered while typing but not when being explicitly invoked using the configured keymapping [2] (`Ctrl` / `⌃` + `Space` by default). This was because when the popup is invoked while typing, the matching entry in the list is "inactive", but the color for inactive entries was the same like the background color of the popup itself. This problem is now fixed by changing the color of the corresponding UI theme key `ui.CompletionPopup.selectionInactiveBackground` from `nord1` to `nord3`. [1]: https://www.jetbrains.com/help/idea/auto-completing-code.html#configure-code-completion [2]: https://www.jetbrains.com/help/idea/auto-completing-code.html#invoke-basic-completion Related to GH-94 Fixes GH-95
svengreb
pushed a commit
that referenced
this issue
Feb 11, 2020
Before this commit, the background color of the marked entry in the completion popup when triggered while typing (enabled "Show suggestions as you type" option in preferences) [1] was the same like the background of the popup itself. As a result, the user did not know which entry was selected to complete the current line. The problem only occurred when the completion popup was triggered while typing but not when being explicitly invoked using the configured keymapping [2] (`Ctrl` / `⌃` + `Space` by default). This was because when the popup is invoked while typing, the matching entry in the list is "inactive", but the color for inactive entries was the same like the background color of the popup itself. This problem is now fixed by changing the color of the corresponding UI theme key `ui.CompletionPopup.selectionInactiveBackground` from `nord1` to `nord3`. [1]: https://www.jetbrains.com/help/idea/auto-completing-code.html#configure-code-completion [2]: https://www.jetbrains.com/help/idea/auto-completing-code.html#invoke-basic-completion Related to GH-94 Fixes GH-95
|
The fix has been merged and released in version 0.10.0 🏷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Possibly related to #88 and #94
0.8.1 version fixed the issue with global background (thx again for that), but there is one small issue: when the code competition is triggered automatically, first selected item misses it's background which will not appear until a key up/down is pressed. If the window is triggered by ctrl-space, then everything works as it should
As with #88 product affected is GoLang (have not tried with another IDE) on windows 10. Nord version is 0.8.1 (installed manually from release page)
The text was updated successfully, but these errors were encountered: