Skip to content

Commit

Permalink
Fix invisible background color of inactive completion popup item (#118)
Browse files Browse the repository at this point in the history
Before this commit, the background color of the marked entry in the
completion popup when triggered while typing
(enabled "Show suggestions as you type" option in preferences) [1]
was the same like the background of the popup itself. As a result,
the user did not know which entry was selected to complete the current
line.
The problem only occurred when the completion popup was triggered while
typing but not when being explicitly invoked using the configured
keymapping [2] (`Ctrl` / `⌃` + `Space` by default).
This was because when the popup is invoked while typing, the matching
entry in the list is "inactive", but the color for inactive entries was
the same like the background color of the popup itself.

This problem is now fixed by changing the color of the corresponding UI
theme key `ui.CompletionPopup.selectionInactiveBackground` from `nord1`
to `nord3`.

[1]: https://www.jetbrains.com/help/idea/auto-completing-code.html#configure-code-completion
[2]: https://www.jetbrains.com/help/idea/auto-completing-code.html#invoke-basic-completion

Related to GH-94
Fixes GH-95
  • Loading branch information
arcticicestudio authored Feb 11, 2020
1 parent 061fd42 commit 23cea02
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/nord.theme.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"matchSelectionForeground": "#88c0d0",
"nonFocusedState": "#2e3440",
"selectionBackground": "#4c566a",
"selectionInactiveBackground": "#3b4252",
"selectionInactiveBackground": "#4c566a",
"selectionInactiveInfoForeground": "#4c566a",
"selectionInfoForeground": "#eceff4"
},
Expand Down

0 comments on commit 23cea02

Please sign in to comment.