Fix invisible background color of inactive completion popup item #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the background color of the marked entry in the completion popup when triggered while typing (enabled "Show suggestions as you type" option in preferences) [1] was the same like the background of the popup itself. As a result, the user did not know which entry was selected to complete the current line. The problem only occured when the completion popup was triggered while typing but not when being explicitly invoked using the configured keymapping [2] (`Ctrl` / `⌃` + `Space` by default). This was because when the popup is invoked while typing, the matching entry in the list is "inactive", but the color for inative entries was the same like the background color of the popup itself. This problem is now fixed by changing the color of the co#rresponding UI theme key `ui.CompletionPopup.selectionInactiveBackground` from `nord1` to `nord3`. [1]: https://www.jetbrains.com/help/idea/auto-completing-code.html#configure-code-completion [2]: https://www.jetbrains.com/help/idea/auto-completing-code.html#invoke-basic-completion Related to GH-94 GH-95
This was referenced Feb 11, 2020
svengreb
approved these changes
Feb 11, 2020
arcticicestudio
deleted the
bugfix/gh-95-inactive-background-color-completion-popup
branch
svengreb
pushed a commit
that referenced
this pull request
Feb 11, 2020
Before this commit, the background color of the marked entry in the completion popup when triggered while typing (enabled "Show suggestions as you type" option in preferences) [1] was the same like the background of the popup itself. As a result, the user did not know which entry was selected to complete the current line. The problem only occurred when the completion popup was triggered while typing but not when being explicitly invoked using the configured keymapping [2] (`Ctrl` / `⌃` + `Space` by default). This was because when the popup is invoked while typing, the matching entry in the list is "inactive", but the color for inactive entries was the same like the background color of the popup itself. This problem is now fixed by changing the color of the corresponding UI theme key `ui.CompletionPopup.selectionInactiveBackground` from `nord1` to `nord3`. [1]: https://www.jetbrains.com/help/idea/auto-completing-code.html#configure-code-completion [2]: https://www.jetbrains.com/help/idea/auto-completing-code.html#invoke-basic-completion Related to GH-94 Fixes GH-95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95
Related to #94
Before this PR, the background color of the marked entry in the completion popup when triggered while typing (enabled “Show suggestions as you type“ option in preferences) was the same like the background of the popup itself. As a result, the user did not know which entry was selected to complete the current line.
The problem only occurred when the completion popup was triggered while typing but not when being explicitly invoked using the configured keymapping (
Ctrl/⌃+Spaceby default).This was because the matching entry in the list, when invoked while typing, is inactive, but the color for inactive entries was the same like the background color of the popup itself.
This problem is now fixed by changing the color of the corresponding UI theme key
ui.CompletionPopup.selectionInactiveBackgroundfromnord1tonord3.Before
After