Code completion selection background is inconsistent #94
Comments
cjkent
changed the title
|
In the second case, the background colour changes from dark to light when the selection changes. |
Before this commit, the background color of the marked entry in the completion popup when triggered while typing (enabled "Show suggestions as you type" option in preferences) [1] was the same like the background of the popup itself. As a result, the user did not know which entry was selected to complete the current line. The problem only occured when the completion popup was triggered while typing but not when being explicitly invoked using the configured keymapping [2] (`Ctrl` / `⌃` + `Space` by default). This was because when the popup is invoked while typing, the matching entry in the list is "inactive", but the color for inative entries was the same like the background color of the popup itself. This problem is now fixed by changing the color of the co#rresponding UI theme key `ui.CompletionPopup.selectionInactiveBackground` from `nord1` to `nord3`. [1]: https://www.jetbrains.com/help/idea/auto-completing-code.html#configure-code-completion [2]: https://www.jetbrains.com/help/idea/auto-completing-code.html#invoke-basic-completion Related to GH-94 GH-95
|
Hi @cjkent 👋, thanks for your contribution 👍 Is the problem the same like described in #95? If so, a fix has been submitted in #118 that'll be included in the next release version 0.10.0. |
Before this commit, the background color of the marked entry in the completion popup when triggered while typing (enabled "Show suggestions as you type" option in preferences) [1] was the same like the background of the popup itself. As a result, the user did not know which entry was selected to complete the current line. The problem only occurred when the completion popup was triggered while typing but not when being explicitly invoked using the configured keymapping [2] (`Ctrl` / `⌃` + `Space` by default). This was because when the popup is invoked while typing, the matching entry in the list is "inactive", but the color for inactive entries was the same like the background color of the popup itself. This problem is now fixed by changing the color of the corresponding UI theme key `ui.CompletionPopup.selectionInactiveBackground` from `nord1` to `nord3`. [1]: https://www.jetbrains.com/help/idea/auto-completing-code.html#configure-code-completion [2]: https://www.jetbrains.com/help/idea/auto-completing-code.html#invoke-basic-completion Related to GH-94 Fixes GH-95
Before this commit, the background color of the marked entry in the completion popup when triggered while typing (enabled "Show suggestions as you type" option in preferences) [1] was the same like the background of the popup itself. As a result, the user did not know which entry was selected to complete the current line. The problem only occurred when the completion popup was triggered while typing but not when being explicitly invoked using the configured keymapping [2] (`Ctrl` / `⌃` + `Space` by default). This was because when the popup is invoked while typing, the matching entry in the list is "inactive", but the color for inactive entries was the same like the background color of the popup itself. This problem is now fixed by changing the color of the corresponding UI theme key `ui.CompletionPopup.selectionInactiveBackground` from `nord1` to `nord3`. [1]: https://www.jetbrains.com/help/idea/auto-completing-code.html#configure-code-completion [2]: https://www.jetbrains.com/help/idea/auto-completing-code.html#invoke-basic-completion Related to GH-94 Fixes GH-95
Don't apologise, thanks for the beautiful theme! It's very similar, but it's not quite the same problem. In #95 the background for the selected item is missing (or is the same as unselected items) when the completion popup appears automatically. The problem I see is that the background of the selected item is darker than unselected items when the popup appears automatically, and it is lighter than the background of unselected items when you press ctrl-space. It seems possible that the underlying cause is the same and my problem will be fixed in 0.10.0. If the problem is still there in 0.10.0 I'll comment again on this issue. |
|
It's fixed in 0.10.0. Thanks again for a great theme. |
The background colour of the selected item in the code completion popup is different depending on how the pop was triggered.
If the popup is triggered manually (by pressing ctrl+space) then the background of the selected item is lighter than the other items.
If the popup is triggered automatically as you're typing then the background of the selected item is darker than the other items (check the option "show suggestions as you type" to see this behaviour).
Having the selected item darker in one case and lighter in the other is very confusing.
Also the background of the selected item is too similar to the other items in both cases. It would be easier to see which item is selected if there was a bigger difference between the background colours.
The text was updated successfully, but these errors were encountered: