-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIP-115 Yet Another Geo Tag (ISO-3166-1/2/3) #952
Conversation
hum... some clients may crash on You know.. all these |
It won't really be combined with the That's why all possible g values must not have ambiguous meanings (NA shouldn't mean a country or a continent). So we shouldn't for instance represent a country with 4 standards, and instead should pick just one that won't collide with other g entities. |
Sounds like a client-issue, their implementations should be defensive and fault tolerant. Geohashes are always lowercase
👍
This is not an issue. You post-process the results using
It's not being represented with 4 standards. ISO-3166 is one standard, that has multiple drafts, and different ways (formats) to express the country. With changes, there will be no more collisions. Anyways, I removed |
Looks good. |
|
Removed
|
|
…ployed anyways) - collisions section that outlines collisions - `ISO-3166` omissions section that mentions omissions of standard from NIP.
- update list - update tags table
found two theoretical collisions in `cityName`, though cannot find any real examples.
This seems fine, pretty clean and clear, although my preference would be to make the following changes:
|
My primary argument against this is collisions.
As it is written,
Makes sense. |
The only possible danger is that only for events using multiple
I don't understand this. My suggestion is that you don't change |
As written this NIP is strictly additive, so this statement doesn't actually change. Being nostr, I could (and am) publishing events with
I would argue that |
Primary updates
Non-standardized values or values with ISO collisions such as Need to do rewrite and rerun collision tests. requested review from everyone, but tagging @vitorpamplona because has an open review. |
…mpatibility table
This NIP sits somewhere between
g
defined inNIP-52
and "places" over in #927. Itextends theaddsg
tagG
tag]. This is the result of patiently watching from the sidelines and conversations from #763. After writingnostr-geotags
it was apparent that withNIP-32
, a specification for interoperability would still be required. And after all was said and done, would still require domain knowledge of ISO standards to properly use. This NIP providesalmost*full coverage over the well-established ISO-3166 standard (ISO-3166-1/2/3)* ISO-3166-1:numeric was removed because it has possible collisions with geohashesPrimary issues I found with using NIP-32 for geotags:
Implementations:
nostr-geotags
is in line with this NIPI'll add an option tonostr-geotags
that produces tags proposed here instead of the NIP-32 tags.