Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added COSE envelope implementation #75

Merged
merged 18 commits into from
Sep 29, 2022

Conversation

patrickzheng200
Copy link

@patrickzheng200 patrickzheng200 commented Sep 14, 2022

This PR adds COSE envelope implementation in cose/envelope.go.
This is based on the previous merged refactor envelope and signer to support cose.

image

Signed-off-by: Patrick Zheng patrickzheng@microsoft.com

binbin-li and others added 3 commits September 13, 2022 08:22
Signed-off-by: Binbin Li <libinbin@microsoft.com>
)

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
Two-Hearts and others added 5 commits September 15, 2022 11:31
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@shizhMSFT shizhMSFT deleted the branch notaryproject:main September 21, 2022 03:34
@shizhMSFT shizhMSFT closed this Sep 21, 2022
@shizhMSFT shizhMSFT reopened this Sep 21, 2022
@shizhMSFT shizhMSFT changed the base branch from stage/cose to main September 21, 2022 03:43
@shizhMSFT shizhMSFT added this to the RC-1 milestone Sep 21, 2022
@shizhMSFT shizhMSFT requested review from a team September 21, 2022 03:49
@shizhMSFT shizhMSFT added the enhancement New feature or request label Sep 21, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Merging #75 (f746e7f) into main (009c09a) will increase coverage by 3.79%.
The diff coverage is 96.27%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   75.56%   79.35%   +3.79%     
==========================================
  Files          27       28       +1     
  Lines        1678     2054     +376     
==========================================
+ Hits         1268     1630     +362     
- Misses        315      324       +9     
- Partials       95      100       +5     
Impacted Files Coverage Δ
signature/cose/envelope.go 96.27% <96.27%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions.

signature/cose/envelope.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
signature/cose/envelope.go Outdated Show resolved Hide resolved
signature/cose/envelope.go Show resolved Hide resolved
signature/cose/envelope.go Show resolved Hide resolved
signature/cose/envelope.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion.

signature/cose/envelope.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants