Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number in NumberPropertyValue needs to be Nullable. #164

Closed
Scantheus opened this issue Oct 3, 2021 · 1 comment · Fixed by #167
Closed

Number in NumberPropertyValue needs to be Nullable. #164

Scantheus opened this issue Oct 3, 2021 · 1 comment · Fixed by #167
Assignees
@kashifsoofi
Labels
bug Something isn't working hacktoberfest
Milestone
2.2.0

Comments

@Scantheus
Copy link

As per 2021-08-16 Notion API version, empty database properties are now returned as null.

https://developers.notion.com/changelog/notion-version-2021-08-16#empty-database-properties-are-now-returned-as-null

I got this exception when querying and a record hand an empty Number type field.
Exception : Error converting value {null} to type 'System.Double'. Path 'number', line 1, position 1237.

I did not check other property types that may now be nullable.
@KoditkarVedant KoditkarVedant added bug Something isn't working hacktoberfest labels Oct 4, 2021
@kashifsoofi
Copy link
Contributor

Can I take this one

@kashifsoofi kashifsoofi mentioned this issue Oct 4, 2021
Merged
6 tasks
@KoditkarVedant KoditkarVedant added this to the 2.2.0 milestone Oct 5, 2021
KoditkarVedant added a commit that referenced this issue Oct 5, 2021
@KoditkarVedant
Merge pull request #167 from kashifsoofi/#164-Make-Property-Nullable
ce76079 
Make Number nullable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kashifsoofi kashifsoofi

Labels
bug Something isn't working hacktoberfest
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

Make number nullable
3 participants
@kashifsoofi @KoditkarVedant @Scantheus