Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make number nullable #167

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Make number nullable #167

merged 3 commits into from
Oct 5, 2021

Conversation

kashifsoofi
Copy link
Contributor

Description

Make number property nullable.

Fixes #164

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • All unit tests passing

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@KoditkarVedant KoditkarVedant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kashifsoofi First of all thank you for your contribution. You also need to make date, email, and rollup types nullable. You can find them in their respective PropertyValue type classes.

@kashifsoofi
Copy link
Contributor Author

Sure I think i checked those, let me update, thanks

@kashifsoofi
Copy link
Contributor Author

Email is string so that is nullable and so are the objects

Copy link
Contributor

@KoditkarVedant KoditkarVedant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kashifsoofi I've left a small comment. Rest LGTM.

Copy link
Contributor

@KoditkarVedant KoditkarVedant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KoditkarVedant KoditkarVedant merged commit ce76079 into notion-dotnet:main Oct 5, 2021
@kashifsoofi kashifsoofi deleted the #164-Make-Property-Nullable branch October 5, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number in NumberPropertyValue needs to be Nullable.
2 participants