Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web,novui): initial implementation of var autocomplete in controls #6097
feat(web,novui): initial implementation of var autocomplete in controls #6097
Changes from 40 commits
c7f67c1
dfb900e
c5fafde
75baf54
6f2dea5
506f7c1
3002b97
9fd199b
8aa698f
2577fe7
2c7914f
bc1de1b
f54815b
af5f717
51440b7
de5f506
d325612
22e1790
4266a34
f2b05fa
eb67ffa
5b5a52a
ec774c0
7e37745
5721b30
76f9a40
f94c695
9c1f0b3
477e219
f9e93ab
b39cbf3
21a7f8f
8aeea70
092bcab
714d683
1f039e5
ecae780
70a0898
ffe1835
390cf3d
3b391b6
fcf37b0
00cdda0
3cddea1
046ae4c
e4adee6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: Do we have more explicit types for
schemaObject
? Please add if soThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically its type should be the
RJSFSchema
that comes from the@rjsf/utils
package that we don't import in web.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha -- then it sounds to me like this helper should live in
novui
!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it, but it feels like we are already adding too much logic to novui, which we shouldn't do in a design system. No?
This file was deleted.