Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Add Novu-managed Bridge endpoint per environment #6451

Merged
merged 112 commits into from
Oct 15, 2024
Merged

feat(api): Add Novu-managed Bridge endpoint per environment #6451

merged 112 commits into from
Oct 15, 2024

Conversation

rifont
Copy link
Contributor

@rifont rifont commented Sep 6, 2024 •
edited
Loading

What changed? Why was the change needed?

  • Add custom Novu-managed Bridge-endpoint endpoint at /v1/environments/:environmentId/bridge
    • dynamically constructs a Framework workflow derived from the persisted Workflow definition
  • Refactor all use-cases making requests to Novu Bridge endpoints to use ExecuteBridgeRequest. This provides a central location for:
    • HTTP concerns
    • error handling
    • fetching environment secret key
    • hmac signature creation for bridge request authenticity

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@rifont rifont marked this pull request as draft September 6, 2024 16:46
@rifont rifont requested a review from tatarco September 6, 2024 16:46
@rifont rifont changed the title refactor(api): add novu bridge handler and update methods feat(api): Add Novu-managed Bridge endpoint per environment Sep 6, 2024
rifont
rifont commented Oct 15, 2024
View reviewed changes
apps/api/src/app/events/e2e/bridge-trigger.e2e.ts
@@ -1488,6 +1488,7 @@ describe('Novu-Hosted Bridge Trigger', () => {
name: 'Test Workflow',
description: 'Test Workflow',
__source: WorkflowCreationSourceEnum.DASHBOARD,
workflowId: 'test-workflow',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djabarovgeorge I'm adding the workflowId during creation here for the time being, let's discuss separately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related comment: https://github.com/novuhq/novu/pull/6657/files#r1801824493

@rifont rifont merged commit d454d17 into next Oct 15, 2024
40 checks passed
@rifont rifont deleted the novu-managed-bridge-endpoint branch October 15, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SokratisVidros SokratisVidros SokratisVidros approved these changes

@tatarco tatarco Awaiting requested review from tatarco

Assignees
No one assigned
Labels
@novu/api @novu/shared @novu/web @novu/worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rifont @SokratisVidros @tatarco