-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add Novu-managed Bridge endpoint per environment #6451
Merged
Merged
Changes from 1 commit
Commits
Show all changes
112 commits
Select commit
Hold shift + click to select a range
8e09300
refactor(api): add novu bridge handler and update methods
rifont 6c7291f
fix: Correct spelling error in variable name
rifont a3d012a
docs(environments): update TODO comment in GET handler
rifont e51c309
refactor(environments): rename NovuBridgeHandler to NovuNestjsHandler
rifont 69f6d04
feat(api): add EnvironmentsBridgeController
rifont 40612b2
feat(environments): add OPTIONS method and refactor code
rifont 2cff9ad
fix(environments): remove unnecessary @Options decorator
rifont ba266c4
fix(environments): fix method type in handleRequest call
rifont dfb0428
refactor(api): add novu bridge handler and update methods
rifont a4b1eaa
fix: Correct spelling error in variable name
rifont e0e12ef
docs(environments): update TODO comment in GET handler
rifont 4c288d0
refactor(environments): rename NovuBridgeHandler to NovuNestjsHandler
rifont b54451d
feat(api): add EnvironmentsBridgeController
rifont dcd8f58
feat(environments): add OPTIONS method and refactor code
rifont 57b9fe9
fix(environments): remove unnecessary @Options decorator
rifont 43f7c2f
fix(environments): fix method type in handleRequest call
rifont 8d5c4b8
Merge branch 'novu-managed-bridge-endpoint' of ssh://github.com/novuh…
rifont 9d33b7d
feat: Add NestJS support to framework
rifont 2e931b8
Merge branch 'next' into novu-managed-bridge-endpoint
rifont 43c6b4f
docs(nest.module): update JSON middleware usage example
rifont 3745a20
refactor(nest): simplify request handling logic
rifont c9d5ae6
refactor(nest): simplify handleRequest method call
rifont 65d903b
refactor(nest.controller): replace @All with specific methods
rifont 279d0ce
Merge branch 'next' into novu-managed-bridge-endpoint
rifont f26fd0d
refactor: remove unused NestJS files
rifont 621d605
revert changes
rifont b9991e8
revert changes
rifont 772245e
refactor(api): remove novu-nestjs-handler file
rifont 0279f35
refactor(environments): remove bridge controller
rifont 3b14d62
fix(novu-bridge-client): correct action enum check logic
rifont 73aa9d8
fix(execute-bridge-job): correct IDs for control vars lookup
rifont 7cc7c82
fix(novu-bridge-client): handle missing step template
rifont 640a035
Merge branch 'next' into novu-managed-bridge-endpoint
rifont ff46ad9
refactor(novu-bridge-client): update step type handling
rifont 1de53c5
style: Remove unused import in novu-bridge-client
rifont 28eb94a
style: Update tsconfig and remove unused import
rifont 7c330d7
refactor(api): rename validateBridgeUrlUsecase variable
rifont 236c03d
refactor(novu-bridge): use command pattern in workflow creation
rifont dd78f10
refactor(environments): rename create to construct
rifont ff3c8d4
docs(api): add comments for NovuBridgeClient class
rifont efcb21c
refactor: Rename createFrameworkWorkflow variable
rifont 0337e46
refactor(construct-framework-workflow): enhance step options
rifont 82cef5d
Merge branch 'next' into novu-managed-bridge-endpoint
rifont 913d52b
style: Simplify comment syntax
rifont e853ade
style: Add type assertion for StepOptions
rifont b262cbd
refactor(api): add novu bridge handler and update methods
rifont a46310a
fix: Correct spelling error in variable name
rifont 850eae7
docs(environments): update TODO comment in GET handler
rifont 4158d6b
refactor(environments): rename NovuBridgeHandler to NovuNestjsHandler
rifont 2141915
feat(api): add EnvironmentsBridgeController
rifont 4a3bddc
feat(environments): add OPTIONS method and refactor code
rifont b5c05f8
fix(environments): remove unnecessary @Options decorator
rifont 48cf9d9
fix(environments): fix method type in handleRequest call
rifont d96c57e
refactor(api): add novu bridge handler and update methods
rifont a591636
fix: Correct spelling error in variable name
rifont 68b9839
docs(environments): update TODO comment in GET handler
rifont 35f90b7
refactor(environments): rename NovuBridgeHandler to NovuNestjsHandler
rifont f8b0e34
feat(api): add EnvironmentsBridgeController
rifont c005246
feat: Add NestJS support to framework
rifont 995d2b2
refactor(nest): simplify request handling logic
rifont 54ab80c
refactor: remove unused NestJS files
rifont 329ae1d
revert changes
rifont f5d27df
refactor(api): remove novu-nestjs-handler file
rifont 23eb424
refactor(environments): remove bridge controller
rifont 8712f28
fix(novu-bridge-client): correct action enum check logic
rifont 61f1cb6
fix(execute-bridge-job): correct IDs for control vars lookup
rifont 3472cba
fix(novu-bridge-client): handle missing step template
rifont 9984034
refactor(novu-bridge-client): update step type handling
rifont d7ba8f9
style: Remove unused import in novu-bridge-client
rifont 689ab2f
style: Update tsconfig and remove unused import
rifont 6083329
refactor(api): rename validateBridgeUrlUsecase variable
rifont be5d3d2
refactor(novu-bridge): use command pattern in workflow creation
rifont 077beac
refactor(environments): rename create to construct
rifont 86d1389
docs(api): add comments for NovuBridgeClient class
rifont 050ea33
refactor: Rename createFrameworkWorkflow variable
rifont 48308d8
refactor(construct-framework-workflow): enhance step options
rifont bb534b2
style: Simplify comment syntax
rifont 8d2663a
style: Add type assertion for StepOptions
rifont f01932c
Merge branch 'novu-managed-bridge-endpoint' of ssh://github.com/novuh…
rifont f226829
refactor(headers): remove duplicate enum entry
rifont 45ad34a
style(analytics): remove unnecessary line breaks
rifont 9f83947
Merge branch 'next' into novu-managed-bridge-endpoint
rifont bd3ebe3
fix: handle undefined bridge URL fallback
rifont 59bb34b
refactor(construct-workflow): remove controlValues param
rifont 78a9b0b
chore: add "Maily" to cspell dictionary
rifont d85982f
refactor(construct-framework): extract step logic
rifont 13da6e2
Merge branch 'next' into novu-managed-bridge-endpoint
rifont f6f5248
style: Update hydration logic comments
rifont 955d25b
docs: add TODO comment for step options resolution
rifont f0e8e19
refactor(construct-framework): add StepOutput return type
rifont 308b1e6
refactor: remove unused controlValues parameter
rifont b8a58bb
refactor(execute-bridge-request): use error constants
rifont c02d843
feat: Add logging for job step details
rifont 9f9cfb3
refactor(construct-framework-workflow): remove TODO comments
rifont 0afbe95
refactor(api): add novu bridge handler and update methods
rifont 5bbfdbc
Merge branch 'novu-managed-bridge-endpoint' of ssh://github.com/novuh…
rifont a991f46
feat(upsert-workflow): use slugify for stepId creation
rifont c36d9bb
fix(upsert-workflow): handle missing step ID exception
rifont 2e1a312
fix(api): Hide bridge controller from OAS
rifont fe006a9
fix: update exception type for missing step elements
rifont bf92708
fix(workflow): change exception to InternalServerErrorException
rifont 95bc9d4
feat: add error logging for bridge endpoint issues
rifont 169ee2a
feat(e2e): add novu-hosted bridge trigger test
rifont 05f70e9
feat: use slug instead of name for workflow triggers
rifont 8368d7b
refactor(notification-template-mapper): remove undefined return
rifont 5b4dff2
feat(workflows-v2): add schema controls to steps
rifont dcd2033
Merge branch 'next' into novu-managed-bridge-endpoint
rifont c665dbe
refactor(workflow): replace slug with workflowId usage
rifont 63e236d
refactor(upsert-workflow): remove unused import slugify
rifont f11ef8a
fix(upsert-workflow): correct stepId to _templateId mapping
rifont 8e9ba81
refactor(upsert-workflow): remove unused import
rifont a421f74
feat(workflows): prevent duplicate step IDs creation
rifont File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djabarovgeorge I'm adding the
workflowId
during creation here for the time being, let's discuss separately.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related comment: https://github.com/novuhq/novu/pull/6657/files#r1801824493