fix(application-generic, api, worker): Throw client timeout exception for Bridge timeout errors #6737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
commented
Oct 21, 2024
| 504, // Gateway Timeout | ||
| 521, // CloudFlare TCP Error | ||
| 522, // CloudFlare Web Server Connection Error | ||
| 524, // CloudFlate Timeout Error |
There was a problem hiding this comment.
Removed 413 and 502 as they are typically not retryable status codes (ref)
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
libs/application-generic/src/usecases/execute-bridge-request/execute-bridge-request.usecase.ts
Outdated
Show resolved
Hide resolved
djabarovgeorge
approved these changes
Oct 21, 2024
SokratisVidros
approved these changes
Oct 21, 2024
…xecute-bridge-request.usecase.ts Co-authored-by: George Djabarov <39195835+djabarovgeorge@users.noreply.github.com>
rifont
commented
Oct 22, 2024
libs/application-generic/src/usecases/execute-bridge-request/execute-bridge-request.usecase.ts
Outdated
Show resolved
Hide resolved
…xecute-bridge-request.usecase.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
504 GatewayTimeoutexception was thrown, which was inaccurate as the server was not at fault. This is replaced by a more accurate408 Request Timeout, indicating the client was unable to fulfil the request within the time the server was prepared to wait.Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer