-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework): add class-validator support #6945
base: next
Are you sure you want to change the base?
feat(framework): add class-validator support #6945
Conversation
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com>
…validator-support' into feat-package-class-validator-support
….com/paulwer/novu into feat-package-class-validator-support
…validator-support
…hq/novu into import-utils-refactor-schemas
…validator-support
👷 Deploy request for novu-stg-vite-dashboard-poc pending review.Visit the deploys page to approve it
|
i could resolve them tomorrow morning, if that fits your schedule. |
packages/framework/src/resources/workflow/discover-custom-step-factory.ts
Outdated
Show resolved
Hide resolved
….com/paulwer/novu into feat-package-class-validator-support
when trying to use a discriminated union type an error occurs because class-validator-jsonschema cannot directly infer a discriminated union type using decorators like @type inside the union classes. Since class-validator-jsonschema doesn’t fully support conditional @type decorators. the following is therefore not possible to implement:
Feature Request: epiphone/class-validator-jsonschema#114 |
similar for oneOf |
@rifont ready again:
|
"reflect-metadata": { | ||
"optional": true | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rifont should we remove reflect-metadata from the peer-deps and deps also?
technicaly they are only required for development and the user has to use it on their server entrypoint in order to have a working class-validator/class-transformer setup.
So i am not sure how to interpret this in scope of this lib :(
What changed? Why was the change needed?
Class Validator support for @novu/framework
Screenhots
Class validator peer dependency import failure message
Expand for optional sections
### Related enterprise PRSpecial notes for your reviewer
closes #6682
reference #6840