Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PostGIS columns with the proper type constraints #719

Closed
roji opened this issue Nov 22, 2018 · 1 comment
Closed

Create PostGIS columns with the proper type constraints #719

roji opened this issue Nov 22, 2018 · 1 comment
Assignees
@roji
Labels
enhancement New feature or request NetTopologySuite

Comments

@roji
Copy link
Member

roji commented Nov 22, 2018 •
edited
Loading

We currently generate PostGIS columns with type GEOMETRY and GEOGRAPHY, when we should be looking at the NTS CLR type (Point, LineString) and generating columns such as GEOMETRY (POINT).

See #717 for a similar request to constrain the SRID in the generated column.

Note: we need to think about what this implies in terms of backwards compatibility with 2.1.

Originally raised in #718
@roji roji added the bug Something isn't working label Nov 22, 2018
@roji roji added this to the 2.2.0 milestone Nov 22, 2018
@roji roji mentioned this issue Nov 22, 2018
Closed
@roji roji self-assigned this Nov 22, 2018
@roji roji added enhancement New feature or request and removed bug Something isn't working labels Nov 23, 2018
@roji roji mentioned this issue Nov 23, 2018
Closed
roji added a commit to roji/efcore.pg that referenced this issue Nov 24, 2018
@roji
Generate GEOMETRY (POINT) columns
bc37402 
We previously generated PostgreSQL GEOMETRY (or GEOGRAPHY) columns, not
taking into account the CLR type. We now include that as a constraint on
the column.

Note that SRID support still needs to be done (npgsql#717).

Fixes npgsql#719
@roji roji mentioned this issue Nov 24, 2018
Merged
roji added a commit to roji/efcore.pg that referenced this issue Nov 30, 2018
@roji
Generate GEOMETRY (POINT) columns
2174ba7 
We previously generated PostgreSQL GEOMETRY (or GEOGRAPHY) columns, not
taking into account the CLR type. We now include that as a constraint on
the column.

Note that SRID support still needs to be done (npgsql#717).

Fixes npgsql#719
@roji roji closed this as completed in #721 Nov 30, 2018
roji added a commit that referenced this issue Nov 30, 2018
@roji
Generate GEOMETRY (POINT) columns (#721)
4c44469 
We previously generated PostgreSQL GEOMETRY (or GEOGRAPHY) columns, not
taking into account the CLR type. We now include that as a constraint on
the column.

Note that SRID support still needs to be done (#717).

Fixes #719
roji added a commit that referenced this issue Dec 5, 2018
@roji
Generate GEOMETRY (POINT) columns
4441b26 
We previously generated PostgreSQL GEOMETRY (or GEOGRAPHY) columns, not
taking into account the CLR type. We now include that as a constraint on
the column.

Note that SRID support still needs to be done (#717).

Fixes #719
@roji roji mentioned this issue Dec 7, 2018
Closed
roji added a commit to roji/efcore.pg that referenced this issue Dec 7, 2018
@roji
Remove release note on npgsql#719 which was rolled back
8392dce
@roji roji mentioned this issue Dec 7, 2018
Merged
roji added a commit that referenced this issue Dec 7, 2018
@roji
Remove release note on #719 which was rolled back
ee5c844
@roji
Copy link
Member Author

roji commented Dec 7, 2018

Reverted via #738.

@roji roji removed this from the 2.2.0 milestone Dec 7, 2018
roji added a commit to roji/efcore.pg that referenced this issue Dec 12, 2018
@roji
Add docs on constraining spatial columns
ec13bfb 
See npgsql#719
@roji roji mentioned this issue Dec 12, 2018
Merged
roji added a commit that referenced this issue Dec 13, 2018
@roji
Add docs on constraining spatial columns (#751)
77a41de 
Add docs on constraining spatial columns

See #719
roji added a commit that referenced this issue Dec 13, 2018
@roji
Add docs on constraining spatial columns (#751)
00bbc9b 
See #719
roji added a commit that referenced this issue Dec 13, 2018
@roji
Add docs on constraining spatial columns
d5fc5e3 
See #719
roji added a commit that referenced this issue Dec 13, 2018
@roji
Add docs on constraining spatial columns
c2703f0 
See #719

(cherry picked from commit d5fc5e3)
roji added a commit that referenced this issue Dec 13, 2018
@roji
Add docs on constraining spatial columns
8fc58b2 
See #719

(cherry picked from commit d5fc5e3)
@roji roji mentioned this issue Feb 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
enhancement New feature or request NetTopologySuite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roji