Generate GEOMETRY (POINT) columns #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @bricelam in case you're curious. PostgreSQL supports PostGIS column names such as |
bricelam
approved these changes
Nov 26, 2018
austindrenski
approved these changes
Nov 26, 2018
test/EFCore.PG.Tests/Storage/NpgsqlNetTopologySuiteTypeMappingSourcePluginTest.cs
Outdated
Show resolved
Hide resolved
src/EFCore.PG.NTS/Storage/Internal/NpgsqlNetTopologySuiteTypeMappingSourcePlugin.cs
Outdated
Show resolved
Hide resolved
src/EFCore.PG.NTS/Storage/Internal/NpgsqlNetTopologySuiteTypeMappingSourcePlugin.cs
Outdated
Show resolved
Hide resolved
test/EFCore.PG.Tests/Storage/NpgsqlNetTopologySuiteTypeMappingSourcePluginTest.cs
Show resolved
Hide resolved
We previously generated PostgreSQL GEOMETRY (or GEOGRAPHY) columns, not taking into account the CLR type. We now include that as a constraint on the column. Note that SRID support still needs to be done (npgsql#717). Fixes npgsql#719
|
@austindrenski will wait for your feedback on the above before merging. |
austindrenski
approved these changes
Nov 29, 2018
roji
force-pushed
the
spatial-types-and-srid
branch
from
bc37402 to
3719c5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously generated PostgreSQL GEOMETRY (or GEOGRAPHY) columns, not
taking into account the CLR type. We now include that as a constraint on
the column.
Note that SRID support still needs to be done (#717).
Fixes #719