Added Postgresql specific aggregation functions. #1745
Conversation
(cherry picked from commit e23739b)
Fixes npgsql#1585 (cherry picked from commit 55cf1f2)
(cherry picked from commit 9f222de)
Closes npgsql#1589 Closes npgsql#1590 (cherry picked from commit e3923d7)
Fixes npgsql#1596 (cherry picked from commit 8c5e77d)
Fixes npgsql#1606 (cherry picked from commit 463b49e)
) Fixes npgsql#1611 (cherry picked from commit 92433ce)
(cherry picked from commit ca3c2ea)
Fixes npgsql#1631 (cherry picked from commit bf6e1d2)
Closes npgsql#1626 (cherry picked from commit bb02267)
Fixes npgsql#1563 (cherry picked from commit e016657)
Fixes npgsql#1652 (cherry picked from commit ccd6f01)
There was a problem hiding this comment.
@nathannau thanks for submitting this.
Fully supporting provider-specific aggregate functions is a goal for EF Core 6.0 (see dotnet/efcore#22957) - this should fix some of the issues (e.g. copy out the private GroupingElementExpression, support for using aggregate methods on queryable/top-level). I've done some exploratory work in #1531.
Once things are properly implemented upstream in EF Core, the actual implementation of the PG aggregate methods would likely look different (e.g. I doubt we'll be adding Translate* methods for each and every method on NpgsqlSqlTranslationExpressionVisitor - we'd likely have method translators). So I think it's better to wait until things are probably done in EF Core before doing this in the PG provider.
|
As written in the above review, proper support for PG-specific aggregate functions depends on dotnet/efcore#22957. I'll go ahead and close this until PR until that issue is implemented on the EF Core side. |
No description provided.