[BUG] Files directive breaks the "files" directive

[MarshallOfSound]

Is there an existing issue for this?

• I have searched the existing issues

This issue exists in the latest npm version

• I am using the latest npm

Current Behavior

An entry in the files array in your package.json in the format foo/* does not include deeper files in nested directories

Expected Behavior

An entry in the files array in your package.json in the format foo/* includes all files inside the foo folder and its children

Steps To Reproduce

git clone https://github.com/MarshallOfSound/npm-files-bug.git
cd npm-files-bug
npx npm@8 pack
npx npm@9 pack

npm 8 output

npm notice === Tarball Contents ===
npm notice 0B   folder/one/file
npm notice 0B   folder/two/file2
npm notice 275B package.json
npm notice === Tarball Details ===

npm 9 output

npm notice === Tarball Contents ===
npm notice 275B package.json
npm notice === Tarball Details ===

Environment

• npm: 9.1.3
• Node.js: 16.17.0
• OS Name: macOS 12.6
• System Model Name: Macbook Pro M1 MAX
• npm config:

; "user" config from /Users/samuel/.npmrc

@fortawesome:registry = "https://npm.fontawesome.com/"
//npm.fontawesome.com/:_authToken = (protected)
//registry.npmjs.org/:_authToken = (protected)

; "cli" config from command line options

location = "project"

; node bin location = /Users/samuel/.nvm/versions/node/v16.17.0/bin/node
; node version = v16.17.0
; npm local prefix = /Users/samuel/projects/electron/npm-demo
; npm version = 9.1.3
; cwd = /Users/samuel/projects/electron/npm-demo
; HOME = /Users/samuel
; Run `npm config ls -l` to show all defaults.

[MarshallOfSound]

Looks like this was broken in npm/npm-packlist#88 maybe unintentionally? Shout-out @JasonEtco for diving into npm internals to find that PR with me

cc @nlf

[lukekarrys]

Thanks for the report @MarshallOfSound (and the help @JasonEtco).

Just dropping one note here while triaging, that both of the following work the same across npm 8 and 9: "files": ["folder"] and "files": ["folder/"].