Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: treat glob the same as globstar #147

Merged
merged 3 commits into from
Dec 7, 2022
Merged

fix: treat glob the same as globstar #147

merged 3 commits into from
Dec 7, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Dec 7, 2022 •
edited
Loading

This makes directory/* work the same as directory/** to maintain backwards compatibility with previous versions of npm pack.

Ref: npm/cli#5918

@lukekarrys lukekarrys changed the title wip: failing test fix: treat glob the same as globstar Dec 7, 2022
@lukekarrys lukekarrys marked this pull request as ready for review December 7, 2022 02:06
@lukekarrys lukekarrys requested a review from a team as a code owner December 7, 2022 02:06
@lukekarrys lukekarrys merged commit c6f2b69 into main Dec 7, 2022
@lukekarrys lukekarrys deleted the lk/directory-glob branch December 7, 2022 17:15
@github-actions github-actions bot mentioned this pull request Dec 7, 2022
Merged
This was referenced Nov 3, 2023
Closed
Closed
@wraithgar wraithgar mentioned this pull request Dec 14, 2023
Closed
1 task
@everett1992 everett1992 mentioned this pull request May 13, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukekarrys @wraithgar