Isaacs/set envs fix #1652
Closed
Isaacs/set envs fix #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/set-envs-fix
branch
from
c682b87
to
8209b29
Compare
MylesBorins
approved these changes
Aug 11, 2020
darcyclarke
reviewed
Aug 11, 2020
| } | ||
|
|
||
| const envVal = val => Array.isArray(val) ? val.join('\n\n') : val | ||
| const envVal = val => Array.isArray(val) ? val.map(v => envVal(v)).join('\n\n') | ||
| : val === null || val === undefined || val === false ? '' |
There was a problem hiding this comment.
o_O can we at least start nesting these? ex.
const envVal = val => Array.isArray(val) ? val.map(v => envVal(v)).join('\n\n')
: val === null || val === undefined || val === false ? ''
: typeof val === 'object' ? null
: String(val)
There was a problem hiding this comment.
We've moved to lining up the : for easier scanning down a straight left-edge, so the CLI matches all the other repos.
darcyclarke
approved these changes
Aug 11, 2020
isaacs
added a commit
that referenced
this pull request
Aug 11, 2020
Fix #1650 PR-URL: #1652 Credit: @isaacs Close: #1652 Reviewed-by: @MylesBorins
|
Landed and published on 7.0.0-beta.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the changes in npm/rfcs#183, and set environment variables properly when they are not strings.
Also adds tests for the set-envs util.