-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: npm pkg #3487
feat: npm pkg #3487
Conversation
cc @ljharb |
abe65be
to
e4e480e
Compare
in this first pass I'm also making it so that we just npm pkg set scripts="$(npm pkg get scripts --prefix=../some-other-project)" --json I'm now sold on it and want it to happen 😍 |
Implements `npm pkg get|set|delete` support. It enables retrieving and modifying values in a `package.json` file of any given project. Included are the implementation based on npm/rfcs#402 along with extensive tests and user documentation. Relates to: npm/rfcs#402 Fixes: npm/statusboard#368
04d466d
to
674e3c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big thanks to @ljharb for helping review this. Gave it another look and the code itself looks well laid out and maintainable, docs are all good. Functionality is as planned.
Implements `npm pkg get|set|delete` support. It enables retrieving and modifying values in a `package.json` file of any given project. Included are the implementation based on npm/rfcs#402 along with extensive tests and user documentation. Relates to: npm/rfcs#402 Fixes: npm/statusboard#368 PR-URL: #3487 Credit: @ruyadorno Close: #3487 Reviewed-by: @wraithgar
Landed in f17aca5 |
feat: npm pkg
Implements
npm pkg get|set|delete
support. It enables retrieving andmodifying values in a
package.json
file of any given project.Included are the implementation based on npm/rfcs#402
along with extensive tests and user documentation.
Relates to: npm/rfcs#402
Fixes: npm/statusboard#368