Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: npm pkg #402

Closed
wants to merge 1 commit into from
Closed

RFC: npm pkg #402

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented Jun 23, 2021

@ruyadorno ruyadorno force-pushed the ruyadorno/npm-pkg branch from c6284bd to 77517ea Compare June 30, 2021 15:11
accepted/0000-npm-pkg.md Outdated Show resolved Hide resolved
accepted/0000-npm-pkg.md Outdated Show resolved Hide resolved
ruyadorno added a commit to npm/cli that referenced this pull request Jul 2, 2021
Implements `npm pkg get|set|delete` support. It enables retrieving and
modifying values in a `package.json` file of any given project.

Included are the implementation based on npm/rfcs#402
along with extensive tests and user documentation.

Relates to: npm/rfcs#402
Fixes: npm/statusboard#368
@ruyadorno ruyadorno force-pushed the ruyadorno/npm-pkg branch from 77517ea to dd01b3d Compare July 2, 2021 21:58
ruyadorno added a commit to npm/cli that referenced this pull request Jul 12, 2021
Implements `npm pkg get|set|delete` support. It enables retrieving and
modifying values in a `package.json` file of any given project.

Included are the implementation based on npm/rfcs#402
along with extensive tests and user documentation.

Relates to: npm/rfcs#402
Fixes: npm/statusboard#368

PR-URL: #3487
Credit: @ruyadorno
Close: #3487
Reviewed-by: @wraithgar
@ruyadorno ruyadorno force-pushed the ruyadorno/npm-pkg branch from dd01b3d to 802e2b5 Compare July 12, 2021 15:22
@ruyadorno ruyadorno closed this in 529e5a1 Jul 12, 2021
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Jul 12, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

It also adds support to negative indexes, so it's now also possible to
retrieve the last item of an array without knowing an exact index, e.g:

npm pkg get keywords[-1]

Relates to: npm/rfcs#402
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Jul 12, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Jul 14, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402
ruyadorno added a commit to npm/cli that referenced this pull request Jul 15, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402

PR-URL: #3539
Credit: @ruyadorno
Close: #3539
Reviewed-by: @darcyclarke, @ljharb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants