Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix git configs for git 2.23 and above #456

Closed
wants to merge 1 commit into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Nov 8, 2019

Config values are now case-sensitive, so commit.gpgsign=false was
doing nothing.

What / Why

n/a

References

  • n/a

@isaacs isaacs requested a review from a team as a code owner November 8, 2019 23:40
@isaacs isaacs requested a review from mikemimik November 8, 2019 23:41
@claudiahdz claudiahdz added semver:patch semver patch level for changes Release 6.x work is associated with a specific npm 6 release labels Nov 12, 2019
Copy link
Contributor

@mikemimik mikemimik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -84,6 +84,7 @@ function tarballToVersion (name, tb) {
} else {
matchRegTarball = new RegExp(`^${registry}(.*)?/-/\\1-(.*)[.]tgz$`)
}
if (!tb) return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: @isaacs what is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems... unrelated to this commit. Must be something I was testing out? I'll back it out.

claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
Config values are now case-sensitive, so `commit.gpgsign=false` was
doing nothing.

PR-URL: #456
Credit: @isaacs
Close: #456
Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
Config values are now case-sensitive, so `commit.gpgsign=false` was
doing nothing.

PR-URL: #456
Credit: @isaacs
Close: #456
Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
Config values are now case-sensitive, so `commit.gpgsign=false` was
doing nothing.

PR-URL: #456
Credit: @isaacs
Close: #456
Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
Config values are now case-sensitive, so `commit.gpgsign=false` was
doing nothing.

PR-URL: #456
Credit: @isaacs
Close: #456
Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
Config values are now case-sensitive, so `commit.gpgsign=false` was
doing nothing.

PR-URL: #456
Credit: @isaacs
Close: #456
Reviewed-by: @claudiahdz
Copy link
Contributor

@mikemimik mikemimik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change needs to be backed out. Otherwise LGTM!

Config values are now case-sensitive, so `commit.gpgsign=false` was
doing nothing.
@isaacs
Copy link
Contributor Author

isaacs commented Nov 14, 2019

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants