-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix git configs for git 2.23 and above #456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lib/install/inflate-shrinkwrap.js
Outdated
@@ -84,6 +84,7 @@ function tarballToVersion (name, tb) { | |||
} else { | |||
matchRegTarball = new RegExp(`^${registry}(.*)?/-/\\1-(.*)[.]tgz$`) | |||
} | |||
if (!tb) return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: @isaacs what is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems... unrelated to this commit. Must be something I was testing out? I'll back it out.
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacs Close: #456 Reviewed-by: @claudiahdz
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacs Close: #456 Reviewed-by: @claudiahdz
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacs Close: #456 Reviewed-by: @claudiahdz
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacs Close: #456 Reviewed-by: @claudiahdz
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacs Close: #456 Reviewed-by: @claudiahdz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change needs to be backed out. Otherwise LGTM!
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing.
c4a61e6
to
653bd29
Compare
Updated. |
Config values are now case-sensitive, so
commit.gpgsign=false
wasdoing nothing.
What / Why
References