Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid caching manifests as promises #7468

Closed
wants to merge 1 commit into from
Closed

fix: avoid caching manifests as promises #7468

wants to merge 1 commit into from

Commits on May 6, 2024

  1. fix: avoid caching manifests as promises 

    Somewhat related to #7276 and #7463. I don't think there is a reason to cache the promise here. And if we ever did choose to replace this with an LRUCache we would need to know the size of what we are caching which will be easier if we only cache the resulting manifest.

I also added a comment about why I think we are removing the license from manifests here. License was removed in #7126 which looks to be a purposeful change but I could not find a reason. Adding the license back in causes many snapshots to fail because the license is now present in lockfiles, so that's how I came up with the comment.
    @lukekarrys
    lukekarrys committed May 6, 2024
    Configuration menu
    Copy the full SHA
    49d044f View commit details
    Browse the repository at this point in the history