Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace lru-cache dependency #704

Merged
merged 3 commits into from
May 2, 2024
Merged

replace lru-cache dependency #704

merged 3 commits into from
May 2, 2024

Conversation

wraithgar
Copy link
Member

This is a rebase of #697 to
isolate the changes into two discrete commits.

  • deps: remove lru-cache
  • fix: use internal cache implementation

@wraithgar wraithgar requested a review from a team as a code owner May 1, 2024 20:00
@wraithgar
Copy link
Member Author

Our linting rules have updated, I'll add a third linting commit to this PR

@wraithgar
Copy link
Member Author

Test failures are due to removal of test runners. We still test in those node versions in other parts of the testing matrix.

mbtools and others added 2 commits May 1, 2024 13:38
This change removes the dependency on the `lru-cache` package. It is
replaced by a comparable, but much simpler class in this package.
@mbtools
Copy link
Contributor

mbtools commented May 2, 2024

nice 👍

@wraithgar wraithgar merged commit c570a34 into main May 2, 2024
22 of 26 checks passed
@wraithgar wraithgar deleted the gar/pr697 branch May 2, 2024 14:01
This was referenced May 2, 2024
lukekarrys pushed a commit that referenced this pull request May 4, 2024
#704 removed usage of `lru-cache`, but the dependency wasn't removed
from `package.json`
wraithgar pushed a commit that referenced this pull request May 7, 2024
🤖 I have created a release *beep* *boop*
---


## [7.6.1](v7.6.0...v7.6.1)
(2024-05-04)

### Bug Fixes

*
[`c570a34`](c570a34)
[#704](#704) linting:
no-unused-vars (@wraithgar)
*
[`ad8ff11`](ad8ff11)
[#704](#704) use internal cache
implementation (@mbtools)
*
[`ac9b357`](ac9b357)
[#682](#682) typo in compareBuild
debug message (#682) (@mbtools)

### Dependencies

*
[`988a8de`](988a8de)
[#709](#709) uninstall
`lru-cache` (#709)
*
[`3fabe4d`](3fabe4d)
[#704](#704) remove lru-cache

### Chores

*
[`dd09b60`](dd09b60)
[#705](#705) bump
@npmcli/template-oss to 4.22.0 (@lukekarrys)
*
[`ec49cdc`](ec49cdc)
[#701](#701) chore: chore:
postinstall for dependabot template-oss PR (@lukekarrys)
*
[`b236c3d`](b236c3d)
[#696](#696) add benchmarks
(#696) (@H4ad)
*
[`692451b`](692451b)
[#688](#688) various improvements
to README (#688) (@mbtools)
*
[`5feeb7f`](5feeb7f)
[#705](#705) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`074156f`](074156f)
[#701](#701) bump
@npmcli/template-oss from 4.21.3 to 4.21.4 (@dependabot[bot])

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants