-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: uninstall lru-cache
#709
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperchupuDev
changed the title
remove unused
deps: uninstall May 4, 2024
lru-cache
dependencylru-cache
lukekarrys
approved these changes
May 4, 2024
Merged
I'm really confused what happened here. 3fabe4d very much did remove this dep. |
Oh I see what happened, the commit I pulled from the other PR put it back cause of merge conflict shenanigans. Thanks for catching this. |
wraithgar
pushed a commit
that referenced
this pull request
May 7, 2024
🤖 I have created a release *beep* *boop* --- ## [7.6.1](v7.6.0...v7.6.1) (2024-05-04) ### Bug Fixes * [`c570a34`](c570a34) [#704](#704) linting: no-unused-vars (@wraithgar) * [`ad8ff11`](ad8ff11) [#704](#704) use internal cache implementation (@mbtools) * [`ac9b357`](ac9b357) [#682](#682) typo in compareBuild debug message (#682) (@mbtools) ### Dependencies * [`988a8de`](988a8de) [#709](#709) uninstall `lru-cache` (#709) * [`3fabe4d`](3fabe4d) [#704](#704) remove lru-cache ### Chores * [`dd09b60`](dd09b60) [#705](#705) bump @npmcli/template-oss to 4.22.0 (@lukekarrys) * [`ec49cdc`](ec49cdc) [#701](#701) chore: chore: postinstall for dependabot template-oss PR (@lukekarrys) * [`b236c3d`](b236c3d) [#696](#696) add benchmarks (#696) (@H4ad) * [`692451b`](692451b) [#688](#688) various improvements to README (#688) (@mbtools) * [`5feeb7f`](5feeb7f) [#705](#705) postinstall for dependabot template-oss PR (@lukekarrys) * [`074156f`](074156f) [#701](#701) bump @npmcli/template-oss from 4.21.3 to 4.21.4 (@dependabot[bot]) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Sep 17, 2024
This was referenced Sep 22, 2024
This was referenced Sep 30, 2024
Merged
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#704 removed usage of
lru-cache
, but the dependency wasn't removed frompackage.json
References
Related to #704