Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ignore-walk and fix tests #204

Merged
merged 3 commits into from
Dec 6, 2023
Merged

update ignore-walk and fix tests #204

merged 3 commits into from
Dec 6, 2023
+40 −8

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Nov 29, 2023 •
edited
Loading

  • deps: ignore-walk@6.0.4
  • chore: tests reflect fixed ignore-walk rules
  • fix: always exclude .npmrc files

@wraithgar wraithgar requested a review from a team as a code owner November 29, 2023 18:07
@wraithgar wraithgar mentioned this pull request Dec 1, 2023
Merged
@mohd-akram
Copy link
Contributor

24344a2 should be reverted as well as it no longer has an effect and was a workaround for the bug in ignore-walk. It also modifies the global variable allLevels which isn't right.

@wraithgar wraithgar self-assigned this Dec 1, 2023
@wraithgar
Copy link
Member Author

Thanks for the heads up @mohd-akram. I reverted the code in this PR but kept the test and readme change since those were still relevant.

@mohd-akram
Copy link
Contributor

Sorry, the revert will need to be reverted. The test just happened to coincidently pass because of the *.js glob in test/package-json-negate-non-root.js. It can be changed to lib instead of *.js to better test the functionality. I guess the allLevels bug can be fixed separately.

@wraithgar wraithgar force-pushed the deps/ignore-walk branch 2 times, most recently from 6eef548 to a5886bb Compare December 6, 2023 16:52
@wraithgar
Copy link
Member Author

Reverted as-is. I'm also adding a safeguard against .npmrc which was missing, and we'll call this PR good. Tweaking the test can be a future concern, we really need to land this so we can finally cut an npm release today there's a lot in the pipeline.

@wraithgar wraithgar merged commit 8fc4df1 into main Dec 6, 2023
27 checks passed
@wraithgar wraithgar deleted the deps/ignore-walk branch December 6, 2023 17:36
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Merged
wraithgar pushed a commit that referenced this pull request Dec 6, 2023
@github-actions
chore: release 8.0.1 (#206)
0de7f91 
🤖 I have created a release *beep* *boop*
---


## [8.0.1](v8.0.0...v8.0.1)
(2023-12-06)

### Bug Fixes

*
[`8fc4df1`](8fc4df1)
[#204](#204) always ignore
.npmrc files at every level (@wraithgar)
*
[`cd5ddbd`](cd5ddbd)
[#205](#205) preserve slashes in
specified files (#205) (@mohd-akram)

### Dependencies

*
[`6058cc5`](6058cc5)
[#204](#204) `ignore-walk@6.0.4`

### Chores

*
[`20fe0cd`](20fe0cd)
[#207](#207) bump
@npmcli/template-oss from 4.21.1 to 4.21.2 (#207) (@dependabot[bot],
@lukekarrys)
*
[`f8be7bd`](f8be7bd)
[#202](#202) bump
@npmcli/template-oss from 4.19.0 to 4.21.1 (#202) (@dependabot[bot],
@lukekarrys)
*
[`8e1d900`](8e1d900)
[#204](#204) tests reflect fixed
ignore-walk rules (@wraithgar)
*
[`6d7cbe9`](6d7cbe9)
[#181](#181) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`80ec501`](80ec501)
[#181](#181) bump
@npmcli/template-oss from 4.18.1 to 4.19.0 (@dependabot[bot])
*
[`f327738`](f327738)
[#179](#179) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`a770a96`](a770a96)
[#179](#179) bump
@npmcli/template-oss from 4.18.0 to 4.18.1 (@dependabot[bot])

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukekarrys lukekarrys lukekarrys approved these changes

Assignees

@wraithgar wraithgar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wraithgar @mohd-akram @lukekarrys