Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve slashes in specified files #205

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: preserve slashes in specified files #205

merged 1 commit into from
Dec 1, 2023

Conversation

mohd-akram
Copy link
Contributor

This change ensures files selected at the root level are not also selected in child directories and that files don't match as directories.

@mohd-akram mohd-akram requested a review from a team as a code owner November 30, 2023 21:51
@wraithgar
Copy link
Member

wraithgar commented Dec 1, 2023

It looks like possibly your branch isn't current with main in this repo. That's my guess based on what tests are failing in CI.

Nope those tests fail in main and I even have a PR in flight to fix it and already forgot about it. What a week it's been.

@wraithgar wraithgar merged commit cd5ddbd into npm:main Dec 1, 2023
5 of 26 checks passed
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
@mohd-akram mohd-akram deleted the fix-slash branch December 1, 2023 18:28
wraithgar pushed a commit that referenced this pull request Dec 6, 2023
🤖 I have created a release *beep* *boop*
---


## [8.0.1](v8.0.0...v8.0.1)
(2023-12-06)

### Bug Fixes

*
[`8fc4df1`](8fc4df1)
[#204](#204) always ignore
.npmrc files at every level (@wraithgar)
*
[`cd5ddbd`](cd5ddbd)
[#205](#205) preserve slashes in
specified files (#205) (@mohd-akram)

### Dependencies

*
[`6058cc5`](6058cc5)
[#204](#204) `ignore-walk@6.0.4`

### Chores

*
[`20fe0cd`](20fe0cd)
[#207](#207) bump
@npmcli/template-oss from 4.21.1 to 4.21.2 (#207) (@dependabot[bot],
@lukekarrys)
*
[`f8be7bd`](f8be7bd)
[#202](#202) bump
@npmcli/template-oss from 4.19.0 to 4.21.1 (#202) (@dependabot[bot],
@lukekarrys)
*
[`8e1d900`](8e1d900)
[#204](#204) tests reflect fixed
ignore-walk rules (@wraithgar)
*
[`6d7cbe9`](6d7cbe9)
[#181](#181) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`80ec501`](80ec501)
[#181](#181) bump
@npmcli/template-oss from 4.18.1 to 4.19.0 (@dependabot[bot])
*
[`f327738`](f327738)
[#179](#179) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`a770a96`](a770a96)
[#179](#179) bump
@npmcli/template-oss from 4.18.0 to 4.18.1 (@dependabot[bot])

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
danpere added a commit to danpere/npm-packlist that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants