Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation with SYNCHDMLC FULL leaves not possible #489

Closed
ojalaj opened this issue Oct 23, 2018 · 4 comments
Closed

Simulation with SYNCHDMLC FULL leaves not possible #489

ojalaj opened this issue Oct 23, 2018 · 4 comments
Assignees
@blakewalters
Labels
bug

Comments

@ojalaj
Copy link

ojalaj commented Oct 23, 2018 •
edited by ftessier
Loading

If one tries to use the SYNCHDMLC FULL leaf model to simulate Varian HDMLC, the following problem arises. 5 leaf groups has to be defined - 1 FULL leaf, 13 HALF leaves, 32 QUARTER leaves, 13 HALF leaves and 1 FULL leaf. However, for HALF leaf groups following problems is output:

 ***ERROR IN CM   5 (MLC)
 Leaf group   2 consists of TARGET/ISOCENTER pairs but
 does not have an even number of leaves.

 ***ERROR IN CM   5 (MLC)
 Leaf group   4 consists of TARGET/ISOCENTER pairs but
 does not have an even number of leaves.

This could be solved by having model for OUTBOARD/FULL leaf #1 and #60 separately and if they would together with HALF leaf groups form even number of leaves on both sides of QUARTER leaves. Or if this is not possible, then just allowing odd number of HALF leaves.
@rtownson rtownson added the bug label Oct 29, 2018
@blakewalters
Copy link
Contributor

Yes, I see what you mean, @ojalaj. I'll see what's involved in relaxing the restriction of having an even number of half and quarter leaves.

blakewalters added a commit that referenced this issue Feb 17, 2019
@blakewalters
Fix #489: Allow odd no. of TARGET/ISOCENTER leaves in SYNCHDMLC
5460380 
Allows more accurate modeling of Varian HD 120 MLC.  Accompanying
changes to GUI and documentation included.
@blakewalters
Copy link
Contributor

Hi @ojalaj: Please give PR#514 a try and let me know if this allows you to model the HD 120 more realistically.

@ojalaj
Copy link
Author

ojalaj commented Feb 17, 2019

Hi @blakewalters! Thanks for the contribution. I'm out-of-office (and actually running a long queue of simulations) for another two weeks. Are you planning to merge this to 2019 release, i.e. how soon you wish me to test this?

@ojalaj ojalaj closed this as completed Feb 17, 2019
@ojalaj ojalaj reopened this Feb 17, 2019
@blakewalters
Copy link
Contributor

Thanks @ojalaj. It would be nice to get this into the 2019 release, maybe @ftessier can give us an idea of the timeline.

@ojalaj ojalaj mentioned this issue Apr 23, 2019
Merged
ftessier pushed a commit that referenced this issue Nov 21, 2019
@blakewalters @ftessier
Fix #489: allow odd number of leaves in SYNCHDMLC
a52aef8 
Allow odd number of TARGET and ISOCENTER leaves in the BEAMnrc SYNCHDMLC
component module, for more accurate modeling of Varian HD 120 multi-leaf
collimator. Update gui and documentation accordingly.
ftessier pushed a commit that referenced this issue Nov 21, 2019
@blakewalters @ftessier
Fix #489: allow odd number of leaves in SYNCHDMLC
17eaefa 
Allow odd number of TARGET and ISOCENTER leaves in the BEAMnrc SYNCHDMLC
component module, for more accurate modeling of Varian HD 120 multi-leaf
collimator. Update gui and documentation accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blakewalters blakewalters

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rtownson @blakewalters @ojalaj