Testing pull request #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was just a test of the pull request mechanism, so we close the request without merging. |
Closed
mxxo
added a commit
to mxxo/EGSnrc
that referenced
this pull request
Jul 27, 2021
After compiling egs_view with asan support, there was a buffer overflow
error traced back to the memcpy call in ImageWindow::paintEvent.
```
ERROR: AddressSanitizer: dynamic-stack-buffer-overflow ...
READ of size 400 at 0x7ffe71889e40 thread T0
#0 0x7f543595ecdf (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x99cdf)
nrc-cnrc#1 0x55dc3acdbb15 in memcpy
nrc-cnrc#2 0x55dc3acdbb15 in ImageWindow::paintEvent(QPaintEvent*)
nrc-cnrc#3 0x7f5434f86047 in QWidget::event(QEvent*)
```
The issue is that memcpy will always copy sizeof(lastRegions) bytes,
into the array `regions`, but before this change `regions` could be
shorter than `lastRegions`, leading to a buffer overflow. After this
change, `maxreg` is always set to `N_REG_MAX`, the length of
`lastRegions`.
ftessier
pushed a commit
to mxxo/EGSnrc
that referenced
this pull request
Jun 27, 2022
After compiling egs_view with asan support, there was a buffer overflow
error traced back to the memcpy call in ImageWindow::paintEvent.
ERROR: AddressSanitizer: dynamic-stack-buffer-overflow ...
READ of size 400 at 0x7ffe71889e40 thread T0
#0 0x7f543595ecdf (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x99cdf)
nrc-cnrc#1 0x55dc3acdbb15 in memcpy
nrc-cnrc#2 0x55dc3acdbb15 in ImageWindow::paintEvent(QPaintEvent*)
nrc-cnrc#3 0x7f5434f86047 in QWidget::event(QEvent*)
The issue is that memcpy will always copy sizeof(lastRegions) bytes,
into the array regions, but before this change regions could be shorter
than lastRegions, leading to a buffer overflow. After this change,
maxreg is always set to N_REG_MAX, the length of lastRegions.
ftessier
pushed a commit
to mxxo/EGSnrc
that referenced
this pull request
Jun 27, 2022
After compiling egs_view with asan support, there was a buffer overflow
error traced back to the memcpy call in ImageWindow::paintEvent.
ERROR: AddressSanitizer: dynamic-stack-buffer-overflow ...
READ of size 400 at 0x7ffe71889e40 thread T0
#0 0x7f543595ecdf (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x99cdf)
nrc-cnrc#1 0x55dc3acdbb15 in memcpy
nrc-cnrc#2 0x55dc3acdbb15 in ImageWindow::paintEvent(QPaintEvent*)
nrc-cnrc#3 0x7f5434f86047 in QWidget::event(QEvent*)
The issue is that memcpy will always copy sizeof(lastRegions) bytes into
the array regions. But before this change, regions could be shorter than
lastRegions, leading to a buffer overflow. After this change, maxreg is
always set to N_REG_MAX, the length of lastRegions.
ftessier
pushed a commit
to mxxo/EGSnrc
that referenced
this pull request
Jun 27, 2022
After compiling egs_view with asan support, there was a buffer overflow
error traced back to the memcpy call in ImageWindow::paintEvent.
ERROR: AddressSanitizer: dynamic-stack-buffer-overflow ...
READ of size 400 at 0x7ffe71889e40 thread T0
#0 0x7f543595ecdf (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x99cdf)
nrc-cnrc#1 0x55dc3acdbb15 in memcpy
nrc-cnrc#2 0x55dc3acdbb15 in ImageWindow::paintEvent(QPaintEvent*)
nrc-cnrc#3 0x7f5434f86047 in QWidget::event(QEvent*)
The issue is that memcpy will always copy sizeof(lastRegions) bytes into
the array regions. But before this change, regions could be shorter than
lastRegions, leading to a buffer overflow. After this change, maxreg is
always set to N_REG_MAX, the length of lastRegions.
ftessier
pushed a commit
that referenced
this pull request
Jun 30, 2022
After compiling egs_view with asan support, there was a buffer overflow
error traced back to the memcpy call in ImageWindow::paintEvent.
ERROR: AddressSanitizer: dynamic-stack-buffer-overflow ...
READ of size 400 at 0x7ffe71889e40 thread T0
#0 0x7f543595ecdf (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x99cdf)
#1 0x55dc3acdbb15 in memcpy
#2 0x55dc3acdbb15 in ImageWindow::paintEvent(QPaintEvent*)
#3 0x7f5434f86047 in QWidget::event(QEvent*)
The issue is that memcpy will always copy sizeof(lastRegions) bytes into
the array regions. But before this change, regions could be shorter than
lastRegions, leading to a buffer overflow. After this change, maxreg is
always set to N_REG_MAX, the length of lastRegions.
mchamberland
pushed a commit
to mchamberland/EGSnrc
that referenced
this pull request
Jul 11, 2023
Changing rad generation weighting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply testing how pull request from EGSnrc developers will show up in the EGSnrc repository