Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #945, #804: egs_chamber examples don't run by default #952

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Fix #945, #804: egs_chamber examples don't run by default #952

merged 1 commit into from
Jan 16, 2023

Conversation

rtownson
Copy link
Collaborator

@rtownson rtownson commented Jan 9, 2023

Fix the egs_chamber examples so that they now run without needing to compile any BEAMnrc accelerators or make changes to the input file. Also fix a typo in the example2 water box size.

@rtownson rtownson self-assigned this Jan 9, 2023
@rtownson rtownson requested a review from a team as a code owner January 9, 2023 19:40
ftessier
ftessier approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@ftessier ftessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@ftessier ftessier added this to the Release 2023 milestone Jan 9, 2023
mainegra
mainegra approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@mainegra mainegra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

blakewalters
blakewalters requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@blakewalters blakewalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one thing: When I run example2_chamber_dd, I get a bunch of:
"initScoring: missing/wrong 'sub geometries' for geometry ..." messages
followed by:
"initScoring: different medium 0 in region 5 compared to medium 2 in region 1 for geometry phsp_scoring_geometry.
Hope you know what you are doing"
And then my run immediately fails with a segmentation fault. The latter may be a function of my system (using the Mac clang compiler), but what about those warning/error messages? Are they also due to my system?

@rtownson
Copy link
Collaborator Author

Looks good, but one thing: When I run example2_chamber_dd, I get a bunch of: "initScoring: missing/wrong 'sub geometries' for geometry ..." messages followed by: "initScoring: different medium 0 in region 5 compared to medium 2 in region 1 for geometry phsp_scoring_geometry. Hope you know what you are doing" And then my run immediately fails with a segmentation fault. The latter may be a function of my system (using the Mac clang compiler), but what about those warning/error messages? Are they also due to my system?

The warnings are normal! The segmentation fault is not.

@blakewalters
Copy link
Contributor

blakewalters commented Jan 13, 2023 •
edited
Loading

@rtownson, do you know if anyone else gets the segmentation fault on a Mac? I'll go ahead and change this to an approval, because even if this is a Mac-related issue, it would be a separate PR.

@mchamberland
Copy link
Contributor

@rtownson, do you know if anyone else gets the segmentation fault on a Mac? I'll go ahead and change this to an approval, because even if this is a Mac-related issue, it would be a separate PR.

I will try reproducing this weekend.

@mchamberland
Copy link
Contributor

@rtownson, do you know if anyone else gets the segmentation fault on a Mac? I'll go ahead and change this to an approval, because even if this is a Mac-related issue, it would be a separate PR.

@blakewalters @rtownson Could not reproduce the seg fault on my M2 Mac with the latest GCC toolkit from Homebrew.

@rtownson @ftessier
Fix #945, #804: egs_chamber examples don't work
540738c 
Fix the egs_chamber examples so that they now run without needing to
compile any BEAMnrc accelerators or make changes to the input file. Also
fix a typo in the example2 water box size.
@ftessier
Copy link
Member

Just trimmed the commit title to fit.

@ftessier ftessier merged commit 4074a60 into develop Jan 16, 2023
@ftessier ftessier deleted the fix-egs-chamber-examples branch August 2, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftessier ftessier ftessier approved these changes

@mainegra mainegra mainegra approved these changes

@blakewalters blakewalters blakewalters approved these changes

Assignees

@rtownson rtownson

Labels
documentation
Projects
None yet
Milestone
Release 2023
Development

Successfully merging this pull request may close these issues.
5 participants
@rtownson @blakewalters @mchamberland @ftessier @mainegra