lib: bsdlib: rename to nrf_modem

[lemrey]

Rename bsdlib to nrf_modem (library) and libmodem nrf_modem_lib (glue).
reminder! The two commits must be squashed.

[evenl]

I am a bit confused about the different naming conventions used for this library:

Before with bsdlib:

Files: libbsd_nrf9160_xxaa.a, bsd_os.c, bsdlib.c, nrf91_sockets.c
Folder: bsdlib (both nrf and nrfxlib)
Kconfig nrfxlib: CONFIG_BSD_LIB_
Kconfig nrf: CONFIG_BSD_LIBRARY_, CONFIG_NRF91_SOCKET

Today with modemlib:

File libmodem.a (nrfxlib), libmodem.c (nrf), nrf91_sockets.c (nrf), nrf_modem_os.c (nrf)
Folder: nrf_modem (nrfxlib), libmodem (nrf)
Kconfig nrfxlib: CONFIG_NRF_MODEM
Kconfig nrf: CONFIG_LIBMODEM, CONFIG_NRF91_SOCKETS_

I think it make more sense to call the folder in nrf for nrf_ modem (same as nrfxlib) instead of libmodem? I think it also make more sense to rename libmodem.c to nrf_modem.c, and the CONFIG_LIBMODEM kconfig parameters to CONFIG_NRF_MODEM_LIB_. I am fine with the .a file other that it should probably contain some device information like nrf9160 at least.

A common convention is to name the library file (.a) libfoobar.a, but any references to the library is usually "foobar library" or "foobar lib". Of course both conventions can be found, but for me nrf_modem, nrf_modem_lib or nrf_modem_library make more sense for folders, files and kconfig paramters extern to the library it self, and align more with the naming convention used for bsdlib.

[lemrey]

@evenl The point was to create a distinction (or rather maintain one) between the glue and the library. I think there needs to be.
Here we have libmodem.h, libmodem_init, libmodem.c (under /libmodem) and it's clear that it's glue and it belongs to sdk-nrf.

Following your suggestion, if I renamed the glue to nrf_modem we'd end up with:

• nrf_modem.h, duplicate of main header in nrfxlib/nrf_modem/include/nrf_modem.h
• nrf_modem.c, which would not be the implementation of above header from nrfxlib
• nrf_modem_init in sdk-nrf nrf_modem.c, duplicate of nrf_modem_init in above header

So in conclusion it would be hard to make that distinction anymore (including the distinction between library-defined configurations and glue-defined configurations) and we'd have collisions.

[evenl]

Yes, I understand, but my point is that it is not clear to me that the libmodem prefixed stuff and the nrf_modem stuff belongs together. For bsdlib it was bsd_ for the nrfxlib stuff, and bsdlib_ for the OS integration part, which I think is fairly easy to understand that it belongs together. I think it would have been much more logical with for instance nrf_modem_ for the nrfxlib stuff and nrf_modem_lib_ for the OS integration part.

[rlubos]

I think that Even might have a point here, that libmodem might not be easily connected to nrf_modem for someone not familiarized with the nomenclature. nrf_modem_lib sounds to be better associated with the actual nrfxlib component, the name (and the prefix) is a bit long, but to be honest, nothing better comes to my mind.

[evenl]

Yes, I agree that it's a bit long, but same here, I can not come up with any better.

[lemrey]

I see, point taken. I can change to nrf_modem_lib though I preferred libmodem :)

[lemrey]

I suppose these should stop at the same column as BSD library, check elsewhere too

[umapraseeda]

Fixed these..

[lemrey]

Rebased again to try and get CI green.