tests: lib: date_time: correct comments in build files #3560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments in CMakeLists.txt and prj.conf were in C style. Signed-off-by: Emanuele Di Santo <emdi@nordicsemi.no>
lemrey
force-pushed
the
fix-tests-datetime
branch
from
e67000b to
fb0e32e
Compare
rlubos
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Interesting, apparently it does fail in the CI, but it is ignored:
https://jenkins-ncs.nordicsemi.no/blue/organizations/jenkins/latest%2Fsdk-nrf/detail/PR-3558/9/pipeline/182#step-737-log-71
CC @thst-nordic
Anyway, the change seems sane so approve.
|
@rlubos thanks. I can't merge, please go ahead :) |
|
Well we need more approvals for me to merge as well, let's add some more reviewers. |
tejlmand
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments in CMakeLists.txt and prj.conf were in C style.
This is breaking my CI build in #3394.
That license was added 2 months ago, how did it pass CI then and how did it only affect my CI build but not others?